[sandbox] Enable Module Tampering Protection for CIG processes [chromium/src : main]

[Klaus Vampirelights (Gerrit)]

Attention needed from Alex Gough

Klaus Vampirelights voted and added 1 comment

Votes added by Klaus Vampirelights

Auto-Submit

+1

1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Klaus Vampirelights . resolved

Hi, PTAL thanks!

Open in Gerrit

Related details

Attention is currently required from:

• Alex Gough

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ie63fa447abd7cd5e85c29c5f9ed0288a6a94a170

Gerrit-Change-Number: 7725712

Gerrit-PatchSet: 1

Gerrit-Owner: Klaus Vampirelights <vampire...@gmail.com>

Gerrit-Reviewer: Alex Gough <aj...@chromium.org>

Gerrit-Reviewer: Klaus Vampirelights <vampire...@gmail.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Alex Gough <aj...@chromium.org>

Gerrit-Comment-Date: Mon, 06 Apr 2026 15:58:23 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Klaus Vampirelights (Gerrit)]

Attention needed from James Forshaw

Klaus Vampirelights added 1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Klaus Vampirelights . resolved

Hi, PTAL thanks!

Open in Gerrit

Related details

Attention is currently required from:

• James Forshaw

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ie63fa447abd7cd5e85c29c5f9ed0288a6a94a170

Gerrit-Change-Number: 7725712

Gerrit-PatchSet: 1

Gerrit-Owner: Klaus Vampirelights <vampire...@gmail.com>

Gerrit-Reviewer: Alex Gough <aj...@chromium.org>

Gerrit-Reviewer: James Forshaw <for...@chromium.org>

Gerrit-Reviewer: Klaus Vampirelights <vampire...@gmail.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: James Forshaw <for...@chromium.org>

Gerrit-Comment-Date: Mon, 06 Apr 2026 16:00:22 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Will Harris (Gerrit)]

Attention needed from James Forshaw and Klaus Vampirelights

Will Harris added 1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Will Harris . unresolved

Hi thanks for the CL. Please place this behind a disabled by default base::Feature, and parameterize the tests to test for feature enabled and disabled.

Open in Gerrit

Related details

Attention is currently required from:

• James Forshaw
• Klaus Vampirelights

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• No-Unresolved-Comments

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ie63fa447abd7cd5e85c29c5f9ed0288a6a94a170

Gerrit-Change-Number: 7725712

Gerrit-PatchSet: 1

Gerrit-Owner: Klaus Vampirelights <vampire...@gmail.com>

Gerrit-Reviewer: Alex Gough <aj...@chromium.org>

Gerrit-Reviewer: James Forshaw <for...@chromium.org>

Gerrit-Reviewer: Klaus Vampirelights <vampire...@gmail.com>

Gerrit-Reviewer: Will Harris <w...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: James Forshaw <for...@chromium.org>

Gerrit-Attention: Klaus Vampirelights <vampire...@gmail.com>

Gerrit-Comment-Date: Mon, 06 Apr 2026 19:11:51 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Klaus Vampirelights (Gerrit)]

Attention needed from James Forshaw and Will Harris

Klaus Vampirelights voted and added 1 comment

Votes added by Klaus Vampirelights

Auto-Submit

+1

1 comment

Patchset-level comments

File-level comment, Patchset 1:

Will Harris . resolved

Hi thanks for the CL. Please place this behind a disabled by default base::Feature, and parameterize the tests to test for feature enabled and disabled.

Klaus Vampirelights

Done.

Open in Gerrit

Related details

Attention is currently required from:

• James Forshaw
• Will Harris

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ie63fa447abd7cd5e85c29c5f9ed0288a6a94a170

Gerrit-Change-Number: 7725712

Gerrit-PatchSet: 2

Gerrit-Owner: Klaus Vampirelights <vampire...@gmail.com>

Gerrit-Reviewer: Alex Gough <aj...@chromium.org>

Gerrit-Reviewer: James Forshaw <for...@chromium.org>

Gerrit-Reviewer: Klaus Vampirelights <vampire...@gmail.com>

Gerrit-Reviewer: Will Harris <w...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: James Forshaw <for...@chromium.org>

Gerrit-Attention: Will Harris <w...@chromium.org>

Gerrit-Comment-Date: Tue, 07 Apr 2026 11:05:33 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

Comment-In-Reply-To: Will Harris <w...@chromium.org>

[Will Harris (Gerrit)]

Attention needed from James Forshaw and Klaus Vampirelights

Will Harris added 2 comments

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Will Harris . unresolved

looks good I don't know if we would actually turn this on but I can run a trial on canary/dev.

I'm unsure what this actually gets us though, it seems like it would cause perf issues but improve stability?

File sandbox/policy/features.h

Line 40, Patchset 2 (Latest): kWinSboxModuleTamperingProtection);

Will Harris . unresolved

can you add this to the display in chrome://sandbox please, there should be a list somewhere of all the features, and how they map.

Open in Gerrit

Related details

Attention is currently required from:

• James Forshaw
• Klaus Vampirelights

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• No-Unresolved-Comments

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ie63fa447abd7cd5e85c29c5f9ed0288a6a94a170

Gerrit-Change-Number: 7725712

Gerrit-PatchSet: 2

Gerrit-Owner: Klaus Vampirelights <vampire...@gmail.com>

Gerrit-Reviewer: Alex Gough <aj...@chromium.org>

Gerrit-Reviewer: James Forshaw <for...@chromium.org>

Gerrit-Reviewer: Klaus Vampirelights <vampire...@gmail.com>

Gerrit-Reviewer: Will Harris <w...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: James Forshaw <for...@chromium.org>

Gerrit-Attention: Klaus Vampirelights <vampire...@gmail.com>

Gerrit-Comment-Date: Wed, 08 Apr 2026 00:17:25 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Klaus Vampirelights (Gerrit)]

Attention needed from James Forshaw and Will Harris

Klaus Vampirelights voted and added 2 comments

Votes added by Klaus Vampirelights

Auto-Submit

+1

2 comments

Patchset-level comments

File-level comment, Patchset 2:

Will Harris . resolved

looks good I don't know if we would actually turn this on but I can run a trial on canary/dev.

I'm unsure what this actually gets us though, it seems like it would cause perf issues but improve stability?

Klaus Vampirelights

Thanks for canary/dev trial.

This shouldn't cause perf issues — the OS only remaps the image when IAT tampering is actually detected, and it's a one-time cost at process startup.The benefit is stability: some kernel drivers inject imports into the child process IAT, which causes CIG to crash the process on startup. Module Tampering Protection remaps a clean image so CIG works correctly despite the tampering.

File sandbox/policy/features.h

Line 40, Patchset 2: kWinSboxModuleTamperingProtection);

Will Harris . resolved

can you add this to the display in chrome://sandbox please, there should be a list somewhere of all the features, and how they map.

Klaus Vampirelights

Done.

Open in Gerrit

Related details

Attention is currently required from:

• James Forshaw
• Will Harris

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ie63fa447abd7cd5e85c29c5f9ed0288a6a94a170

Gerrit-Change-Number: 7725712

Gerrit-PatchSet: 5

Gerrit-Owner: Klaus Vampirelights <vampire...@gmail.com>

Gerrit-Reviewer: Alex Gough <aj...@chromium.org>

Gerrit-Reviewer: James Forshaw <for...@chromium.org>

Gerrit-Reviewer: Klaus Vampirelights <vampire...@gmail.com>

Gerrit-Reviewer: Will Harris <w...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: James Forshaw <for...@chromium.org>

Gerrit-Attention: Will Harris <w...@chromium.org>

Gerrit-Comment-Date: Thu, 09 Apr 2026 13:29:16 +0000

[Will Harris (Gerrit)]

Attention needed from James Forshaw and Klaus Vampirelights

Will Harris voted and added 1 comment

Votes added by Will Harris

Code-Review	+1
Commit-Queue	+2

1 comment

Patchset-level comments

File-level comment, Patchset 5 (Latest):

Will Harris . resolved

okay thanks. this will be interesting to see how it changes our data. I will do a dev/canary study for you and see what I can share. it sounds like this might have a memory/perf impact but if it improves stability it will be worth shipping.

Open in Gerrit

Related details

Attention is currently required from:

• James Forshaw
• Klaus Vampirelights

Submit Requirements:

• Code-Coverage
• Code-Owners

• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ie63fa447abd7cd5e85c29c5f9ed0288a6a94a170

Gerrit-Change-Number: 7725712

Gerrit-PatchSet: 5

Gerrit-Owner: Klaus Vampirelights <vampire...@gmail.com>

Gerrit-Reviewer: Alex Gough <aj...@chromium.org>

Gerrit-Reviewer: James Forshaw <for...@chromium.org>

Gerrit-Reviewer: Klaus Vampirelights <vampire...@gmail.com>

Gerrit-Reviewer: Will Harris <w...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: James Forshaw <for...@chromium.org>

Gerrit-Attention: Klaus Vampirelights <vampire...@gmail.com>

Gerrit-Comment-Date: Fri, 10 Apr 2026 16:12:45 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Will Harris (Gerrit)]

Attention needed from Alex Gough and James Forshaw

Will Harris added 1 comment

Patchset-level comments

File-level comment, Patchset 5 (Latest):

Will Harris . resolved

need a second lgtm from someone, so hopefully one of james/alex can rs it and +2

Open in Gerrit

Related details

Attention is currently required from:

• Alex Gough
• James Forshaw

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ie63fa447abd7cd5e85c29c5f9ed0288a6a94a170

Gerrit-Change-Number: 7725712

Gerrit-PatchSet: 5

Gerrit-Owner: Klaus Vampirelights <vampire...@gmail.com>

Gerrit-Reviewer: Alex Gough <aj...@chromium.org>

Gerrit-Reviewer: James Forshaw <for...@chromium.org>

Gerrit-Reviewer: Klaus Vampirelights <vampire...@gmail.com>

Gerrit-Reviewer: Will Harris <w...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: James Forshaw <for...@chromium.org>

Gerrit-Attention: Alex Gough <aj...@chromium.org>

Gerrit-Comment-Date: Fri, 10 Apr 2026 16:13:42 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Hewro Hewei (Gerrit)]

Attention needed from Alex Gough, James Forshaw and Klaus Vampirelights

Hewro Hewei voted

Code-Review	+1
Commit-Queue	+2

Open in Gerrit

Related details

Attention is currently required from:

• Alex Gough
• James Forshaw
• Klaus Vampirelights

Submit Requirements:

• Code-Coverage
• Code-Owners

• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ie63fa447abd7cd5e85c29c5f9ed0288a6a94a170

Gerrit-Change-Number: 7725712

Gerrit-PatchSet: 5

Gerrit-Owner: Klaus Vampirelights <vampire...@gmail.com>

Gerrit-Reviewer: Alex Gough <aj...@chromium.org>

Gerrit-Reviewer: Hewro Hewei <ihe...@chromium.org>

Gerrit-Reviewer: James Forshaw <for...@chromium.org>

Gerrit-Reviewer: Klaus Vampirelights <vampire...@gmail.com>

Gerrit-Reviewer: Will Harris <w...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: James Forshaw <for...@chromium.org>

Gerrit-Attention: Klaus Vampirelights <vampire...@gmail.com>

Gerrit-Attention: Alex Gough <aj...@chromium.org>

Gerrit-Comment-Date: Mon, 13 Apr 2026 08:39:01 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[James Forshaw (Gerrit)]

Attention needed from Alex Gough, Hewro Hewei and Klaus Vampirelights

James Forshaw voted and added 2 comments

Votes added by James Forshaw

Code-Review

+1

2 comments

Patchset-level comments

File-level comment, Patchset 5 (Latest):

James Forshaw . resolved

LGTM, although I did have a query about a definition which I don't believe is needed.

File sandbox/win/src/process_mitigations.cc

Line 46, Patchset 5 (Latest):#ifndef PROCESS_CREATION_MITIGATION_POLICY2_MODULE_TAMPERING_PROTECTION_ALWAYS_ON

James Forshaw . unresolved

Is this needed? Chromium uses an SDK which should already have this definition.

Open in Gerrit

Related details

Attention is currently required from:

• Alex Gough
• Hewro Hewei
• Klaus Vampirelights

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ie63fa447abd7cd5e85c29c5f9ed0288a6a94a170

Gerrit-Change-Number: 7725712

Gerrit-PatchSet: 5

Gerrit-Owner: Klaus Vampirelights <vampire...@gmail.com>

Gerrit-Reviewer: Alex Gough <aj...@chromium.org>

Gerrit-Reviewer: Hewro Hewei <ihe...@chromium.org>

Gerrit-Reviewer: James Forshaw <for...@chromium.org>

Gerrit-Reviewer: Klaus Vampirelights <vampire...@gmail.com>

Gerrit-Reviewer: Will Harris <w...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Klaus Vampirelights <vampire...@gmail.com>

Gerrit-Attention: Hewro Hewei <ihe...@chromium.org>

Gerrit-Attention: Alex Gough <aj...@chromium.org>

Gerrit-Comment-Date: Mon, 13 Apr 2026 10:20:29 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Klaus Vampirelights (Gerrit)]

Attention needed from Alex Gough, Hewro Hewei, James Forshaw and Will Harris

Klaus Vampirelights voted and added 1 comment

Votes added by Klaus Vampirelights

Auto-Submit

+1

1 comment

File sandbox/win/src/process_mitigations.cc

Line 46, Patchset 5:#ifndef PROCESS_CREATION_MITIGATION_POLICY2_MODULE_TAMPERING_PROTECTION_ALWAYS_ON

James Forshaw . resolved

Is this needed? Chromium uses an SDK which should already have this definition.

Klaus Vampirelights

You're right, removed. The SDK (10.0.26100.0) already defines it in WinBase.h.

Open in Gerrit

Related details

Attention is currently required from:

• Alex Gough
• Hewro Hewei
• James Forshaw
• Will Harris

Submit Requirements:

• Code-Coverage
• Code-Owners

• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ie63fa447abd7cd5e85c29c5f9ed0288a6a94a170

Gerrit-Change-Number: 7725712

Gerrit-PatchSet: 6

Gerrit-Owner: Klaus Vampirelights <vampire...@gmail.com>

Gerrit-Reviewer: Alex Gough <aj...@chromium.org>

Gerrit-Reviewer: Hewro Hewei <ihe...@chromium.org>

Gerrit-Reviewer: James Forshaw <for...@chromium.org>

Gerrit-Reviewer: Klaus Vampirelights <vampire...@gmail.com>

Gerrit-Reviewer: Will Harris <w...@chromium.org>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-CC: chromiu...@luci-project-accounts.iam.gserviceaccount.com <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: James Forshaw <for...@chromium.org>

Gerrit-Attention: Will Harris <w...@chromium.org>

Gerrit-Attention: Hewro Hewei <ihe...@chromium.org>

Gerrit-Attention: Alex Gough <aj...@chromium.org>

Gerrit-Comment-Date: Mon, 13 Apr 2026 12:05:18 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

Comment-In-Reply-To: James Forshaw <for...@chromium.org>