[scoped-registry] Ensure failed element has registry set if specified [chromium/src : main]

0 views
Skip to first unread message

Jayson Chen (Gerrit)

unread,
Sep 4, 2025, 1:19:59 PM (3 days ago) Sep 4
to Mason Freed, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, dominicc+...@chromium.org
Attention needed from Joey Arhar and Mason Freed

Jayson Chen voted and added 1 comment

Votes added by Jayson Chen

Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Jayson Chen . resolved

A small CL to ensure that registry is still set correctly in the scenario of element creation failure. PTAL, thanks!

Open in Gerrit

Related details

Attention is currently required from:
  • Joey Arhar
  • Mason Freed
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I4b2dff40392260ddfc989cdd5ff19c6c6a3af2be
Gerrit-Change-Number: 6912475
Gerrit-PatchSet: 2
Gerrit-Owner: Jayson Chen <jayso...@microsoft.com>
Gerrit-Reviewer: Jayson Chen <jayso...@microsoft.com>
Gerrit-Reviewer: Joey Arhar <jar...@chromium.org>
Gerrit-Reviewer: Mason Freed <mas...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Attention: Joey Arhar <jar...@chromium.org>
Gerrit-Attention: Mason Freed <mas...@chromium.org>
Gerrit-Comment-Date: Thu, 04 Sep 2025 17:19:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Joey Arhar (Gerrit)

unread,
Sep 4, 2025, 1:49:36 PM (3 days ago) Sep 4
to Jayson Chen, Mason Freed, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, dominicc+...@chromium.org
Attention needed from Jayson Chen and Mason Freed

Joey Arhar voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Jayson Chen
  • Mason Freed
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I4b2dff40392260ddfc989cdd5ff19c6c6a3af2be
Gerrit-Change-Number: 6912475
Gerrit-PatchSet: 2
Gerrit-Owner: Jayson Chen <jayso...@microsoft.com>
Gerrit-Reviewer: Jayson Chen <jayso...@microsoft.com>
Gerrit-Reviewer: Joey Arhar <jar...@chromium.org>
Gerrit-Reviewer: Mason Freed <mas...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Attention: Jayson Chen <jayso...@microsoft.com>
Gerrit-Attention: Mason Freed <mas...@chromium.org>
Gerrit-Comment-Date: Thu, 04 Sep 2025 17:49:25 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Mason Freed (Gerrit)

unread,
Sep 4, 2025, 5:24:49 PM (2 days ago) Sep 4
to Jayson Chen, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, dominicc+...@chromium.org
Attention needed from Jayson Chen

Mason Freed voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Jayson Chen
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I4b2dff40392260ddfc989cdd5ff19c6c6a3af2be
    Gerrit-Change-Number: 6912475
    Gerrit-PatchSet: 2
    Gerrit-Owner: Jayson Chen <jayso...@microsoft.com>
    Gerrit-Reviewer: Jayson Chen <jayso...@microsoft.com>
    Gerrit-Reviewer: Joey Arhar <jar...@chromium.org>
    Gerrit-Reviewer: Mason Freed <mas...@chromium.org>
    Gerrit-CC: Kentaro Hara <har...@chromium.org>
    Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
    Gerrit-Attention: Jayson Chen <jayso...@microsoft.com>
    Gerrit-Comment-Date: Thu, 04 Sep 2025 21:24:39 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Jayson Chen (Gerrit)

    unread,
    Sep 4, 2025, 7:51:18 PM (2 days ago) Sep 4
    to Mason Freed, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, dominicc+...@chromium.org

    Jayson Chen voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I4b2dff40392260ddfc989cdd5ff19c6c6a3af2be
    Gerrit-Change-Number: 6912475
    Gerrit-PatchSet: 2
    Gerrit-Owner: Jayson Chen <jayso...@microsoft.com>
    Gerrit-Reviewer: Jayson Chen <jayso...@microsoft.com>
    Gerrit-Reviewer: Joey Arhar <jar...@chromium.org>
    Gerrit-Reviewer: Mason Freed <mas...@chromium.org>
    Gerrit-CC: Kentaro Hara <har...@chromium.org>
    Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
    Gerrit-Comment-Date: Thu, 04 Sep 2025 23:51:04 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Jayson Chen (Gerrit)

    unread,
    Sep 4, 2025, 8:24:19 PM (2 days ago) Sep 4
    to Mason Freed, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, dominicc+...@chromium.org
    Gerrit-Comment-Date: Fri, 05 Sep 2025 00:24:07 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Sep 4, 2025, 9:11:13 PM (2 days ago) Sep 4
    to Jayson Chen, Mason Freed, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, dominicc+...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    [scoped-registry] Ensure failed element has registry set if specified

    In the event of getting exception during element creation thus creating
    a failed element to return, we still want to ensure that the registry is
    set if it was specified.
    Bug: 40826514
    Change-Id: I4b2dff40392260ddfc989cdd5ff19c6c6a3af2be
    Reviewed-by: Mason Freed <mas...@chromium.org>
    Reviewed-by: Joey Arhar <jar...@chromium.org>
    Commit-Queue: Jayson Chen <jayso...@microsoft.com>
    Cr-Commit-Position: refs/heads/main@{#1511256}
    Files:
    • M third_party/blink/renderer/bindings/core/v8/script_custom_element_definition.cc
    • M third_party/blink/renderer/core/html/custom/custom_element.cc
    • M third_party/blink/renderer/core/html/custom/custom_element.h
    • M third_party/blink/web_tests/virtual/scoped-custom-element-registry/external/wpt/custom-elements/registries/Element-customElementRegistry-exceptions-expected.txt
    Change size: S
    Delta: 4 files changed, 11 insertions(+), 8 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Mason Freed, +1 by Joey Arhar
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I4b2dff40392260ddfc989cdd5ff19c6c6a3af2be
    Gerrit-Change-Number: 6912475
    Gerrit-PatchSet: 3
    Gerrit-Owner: Jayson Chen <jayso...@microsoft.com>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Jayson Chen <jayso...@microsoft.com>
    Gerrit-Reviewer: Joey Arhar <jar...@chromium.org>
    Gerrit-Reviewer: Mason Freed <mas...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages