Add pyunit module scheme to chromedriver_py_test binaries [chromium/src : main]

0 views
Skip to first unread message

Benjamin Joyce (Ben) (Gerrit)

unread,
Sep 4, 2025, 7:14:12 PM (2 days ago) Sep 4
to Haiyang Pan, Chromium LUCI CQ, Mathias Bynens, AyeAye, chromium...@chromium.org, mac-r...@chromium.org
Attention needed from Haiyang Pan

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:
  • Haiyang Pan
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ieb2c6eaec82edf8cb11ee6a7f7d5c5a93e2db194
Gerrit-Change-Number: 6913491
Gerrit-PatchSet: 7
Gerrit-Owner: Benjamin Joyce (Ben) <bjo...@google.com>
Gerrit-Reviewer: Benjamin Joyce (Ben) <bjo...@google.com>
Gerrit-Reviewer: Haiyang Pan <hy...@google.com>
Gerrit-CC: Mathias Bynens <mat...@chromium.org>
Gerrit-Attention: Haiyang Pan <hy...@google.com>
Gerrit-Comment-Date: Thu, 04 Sep 2025 23:14:02 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Benjamin Joyce (Ben) (Gerrit)

unread,
Sep 4, 2025, 7:14:38 PM (2 days ago) Sep 4
to Haiyang Pan, Chromium LUCI CQ, Mathias Bynens, AyeAye, chromium...@chromium.org, mac-r...@chromium.org
Attention needed from Haiyang Pan

Benjamin Joyce (Ben) voted Auto-Submit+1

Auto-Submit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Haiyang Pan
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ieb2c6eaec82edf8cb11ee6a7f7d5c5a93e2db194
Gerrit-Change-Number: 6913491
Gerrit-PatchSet: 7
Gerrit-Owner: Benjamin Joyce (Ben) <bjo...@google.com>
Gerrit-Reviewer: Benjamin Joyce (Ben) <bjo...@google.com>
Gerrit-Reviewer: Haiyang Pan <hy...@google.com>
Gerrit-CC: Mathias Bynens <mat...@chromium.org>
Gerrit-Attention: Haiyang Pan <hy...@google.com>
Gerrit-Comment-Date: Thu, 04 Sep 2025 23:14:28 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Haiyang Pan (Gerrit)

unread,
Sep 4, 2025, 9:05:38 PM (2 days ago) Sep 4
to Benjamin Joyce (Ben), Chromium LUCI CQ, Mathias Bynens, AyeAye, chromium...@chromium.org, mac-r...@chromium.org
Attention needed from Benjamin Joyce (Ben)

Haiyang Pan voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Benjamin Joyce (Ben)
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ieb2c6eaec82edf8cb11ee6a7f7d5c5a93e2db194
Gerrit-Change-Number: 6913491
Gerrit-PatchSet: 8
Gerrit-Owner: Benjamin Joyce (Ben) <bjo...@google.com>
Gerrit-Reviewer: Benjamin Joyce (Ben) <bjo...@google.com>
Gerrit-Reviewer: Haiyang Pan <hy...@google.com>
Gerrit-CC: Mathias Bynens <mat...@chromium.org>
Gerrit-Attention: Benjamin Joyce (Ben) <bjo...@google.com>
Gerrit-Comment-Date: Fri, 05 Sep 2025 01:05:24 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Benjamin Joyce (Ben) (Gerrit)

unread,
Sep 5, 2025, 12:34:53 PM (2 days ago) Sep 5
to Haiyang Pan, Chromium LUCI CQ, Mathias Bynens, AyeAye, chromium...@chromium.org, mac-r...@chromium.org
Attention needed from Haiyang Pan

Benjamin Joyce (Ben) voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Haiyang Pan
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ieb2c6eaec82edf8cb11ee6a7f7d5c5a93e2db194
Gerrit-Change-Number: 6913491
Gerrit-PatchSet: 8
Gerrit-Owner: Benjamin Joyce (Ben) <bjo...@google.com>
Gerrit-Reviewer: Benjamin Joyce (Ben) <bjo...@google.com>
Gerrit-Reviewer: Haiyang Pan <hy...@google.com>
Gerrit-CC: Mathias Bynens <mat...@chromium.org>
Gerrit-Attention: Haiyang Pan <hy...@google.com>
Gerrit-Comment-Date: Fri, 05 Sep 2025 16:34:40 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Sep 5, 2025, 4:05:34 PM (2 days ago) Sep 5
to Benjamin Joyce (Ben), Haiyang Pan, Mathias Bynens, AyeAye, chromium...@chromium.org, mac-r...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
Add pyunit module scheme to chromedriver_py_test binaries

module scheme is currently only used by some experimental builders, so this shouldn't affect the other builders.

Support for the test uploader was landed in:
https://chromium-review.googlesource.com/c/chromium/src/+/6916708
and successfully tested in this job:
https://chromium-swarm.appspot.com/task?id=732ef7ad44157710


Bug: 440384377
Change-Id: Ieb2c6eaec82edf8cb11ee6a7f7d5c5a93e2db194
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6913491
Commit-Queue: Benjamin Joyce (Ben) <bjo...@google.com>
Reviewed-by: Haiyang Pan <hy...@google.com>
Auto-Submit: Benjamin Joyce (Ben) <bjo...@google.com>
Cr-Commit-Position: refs/heads/main@{#1511816}
Files:
  • M infra/config/generated/builders/build/Mac Builder Siso FYI/targets/chromium.build.fyi.json
  • M infra/config/generated/builders/build/Mac Tests Siso FYI/targets/chromium.build.fyi.json
  • M infra/config/generated/builders/ci/Linux Builder/targets/chromium.linux.json
  • M infra/config/generated/builders/ci/Linux Tests/targets/chromium.linux.json
  • M infra/config/generated/builders/ci/Mac Builder Next/targets/chromium.fyi.json
  • M infra/config/generated/builders/ci/Mac Builder/targets/chromium.mac.json
  • M infra/config/generated/builders/ci/Mac12 Tests/targets/chromium.mac.json
  • M infra/config/generated/builders/ci/Mac13 Tests/targets/chromium.mac.json
  • M infra/config/generated/builders/ci/Win x64 Builder (dbg)/targets/chromium.win.json
  • M infra/config/generated/builders/ci/Win x64 Builder/targets/chromium.win.json
  • M infra/config/generated/builders/ci/Win10 Tests x64 (dbg)/targets/chromium.win.json
  • M infra/config/generated/builders/ci/Win10 Tests x64/targets/chromium.win.json
  • M infra/config/generated/builders/ci/Win11 Tests x64/targets/chromium.win.json
  • M infra/config/generated/builders/ci/linux-code-coverage/targets/chromium.coverage.json
  • M infra/config/generated/builders/ci/linux-rel-cft/targets/chromium.cft.json
  • M infra/config/generated/builders/ci/linux-rel-no-external-ip/targets/chromium.fyi.json
  • M infra/config/generated/builders/ci/linux-structured-test-ids-rel-fyi/targets/chromium.fyi.json
  • M infra/config/generated/builders/ci/linux-win-cross-rel/targets/chromium.win.json
  • M infra/config/generated/builders/ci/mac-arm64-rel/targets/chromium.mac.json
  • M infra/config/generated/builders/ci/mac-osxbeta-rel/targets/chromium.fyi.json
  • M infra/config/generated/builders/ci/mac-rel-cft/targets/chromium.cft.json
  • M infra/config/generated/builders/ci/mac12-arm64-rel-tests/targets/chromium.mac.json
  • M infra/config/generated/builders/ci/mac13-arm64-rel-tests/targets/chromium.mac.json
  • M infra/config/generated/builders/ci/mac14-arm64-rel-tests/targets/chromium.mac.json
  • M infra/config/generated/builders/ci/mac14-tests/targets/chromium.mac.json
  • M infra/config/generated/builders/ci/mac15-arm64-rel-tests/targets/chromium.mac.json
  • M infra/config/generated/builders/ci/mac15-x64-rel-tests/targets/chromium.mac.json
  • M infra/config/generated/builders/ci/win-arm64-dbg/targets/chromium.win.json
  • M infra/config/generated/builders/ci/win-arm64-rel/targets/chromium.win.json
  • M infra/config/generated/builders/ci/win-rel-cft/targets/chromium.cft.json
  • M infra/config/generated/builders/ci/win10-rel-no-external-ip/targets/chromium.fyi.json
  • M infra/config/generated/builders/ci/win11-arm64-dbg-tests/targets/chromium.win.json
  • M infra/config/generated/builders/ci/win11-arm64-rel-tests/targets/chromium.win.json
  • M infra/config/generated/builders/try/linux-code-coverage/targets/chromium.coverage.json
  • M infra/config/generated/builders/try/linux-dcheck-off-rel/targets/chromium.linux.json
  • M infra/config/generated/builders/try/linux-full-remote-rel/targets/chromium.linux.json
  • M infra/config/generated/builders/try/linux-rel-cft/targets/chromium.cft.json
  • M infra/config/generated/builders/try/linux-rel-test-selection/targets/chromium.linux.json
  • M infra/config/generated/builders/try/linux-rel/targets/chromium.linux.json
  • M infra/config/generated/builders/try/linux-structured-test-ids-rel-fyi/targets/chromium.fyi.json
  • M infra/config/generated/builders/try/linux-win-cross-rel/targets/chromium.win.json
  • M infra/config/generated/builders/try/linux_chromium_compile_rel_ng/targets/chromium.linux.json
  • M infra/config/generated/builders/try/mac-builder-next/targets/chromium.fyi.json
  • M infra/config/generated/builders/try/mac-osxbeta-rel/targets/chromium.fyi.json
  • M infra/config/generated/builders/try/mac-rel-cft/targets/chromium.cft.json
  • M infra/config/generated/builders/try/mac-rel/targets/chromium.mac.json
  • M infra/config/generated/builders/try/mac12-arm64-rel/targets/chromium.mac.json
  • M infra/config/generated/builders/try/mac12-tests/targets/chromium.mac.json
  • M infra/config/generated/builders/try/mac13-arm64-rel/targets/chromium.mac.json
  • M infra/config/generated/builders/try/mac13-tests/targets/chromium.mac.json
  • M infra/config/generated/builders/try/mac14-arm64-rel/targets/chromium.mac.json
  • M infra/config/generated/builders/try/mac14-tests/targets/chromium.mac.json
  • M infra/config/generated/builders/try/mac15-arm64-rel/targets/chromium.mac.json
  • M infra/config/generated/builders/try/mac15-x64-rel-tests/targets/chromium.mac.json
  • M infra/config/generated/builders/try/mac_chromium_compile_rel_ng/targets/chromium.mac.json
  • M infra/config/generated/builders/try/win-arm64-compile-dbg/targets/chromium.win.json
  • M infra/config/generated/builders/try/win-arm64-dbg/targets/chromium.win.json
  • M infra/config/generated/builders/try/win-arm64-rel/targets/chromium.win.json
  • M infra/config/generated/builders/try/win-rel-cft/targets/chromium.cft.json
  • M infra/config/generated/builders/try/win-rel/targets/chromium.win.json
  • M infra/config/generated/builders/try/win10-dbg/targets/chromium.win.json
  • M infra/config/generated/builders/try/win11-rel/targets/chromium.win.json
  • M infra/config/targets/binaries.star
Change size: M
Delta: 63 files changed, 143 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Haiyang Pan
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ieb2c6eaec82edf8cb11ee6a7f7d5c5a93e2db194
Gerrit-Change-Number: 6913491
Gerrit-PatchSet: 9
Gerrit-Owner: Benjamin Joyce (Ben) <bjo...@google.com>
Gerrit-Reviewer: Benjamin Joyce (Ben) <bjo...@google.com>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Haiyang Pan <hy...@google.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages