Reland "chromium_codesearch: Enable use_siso in the package_index tool." [chromium/tools/build : main]

0 views
Skip to first unread message

Fumitoshi Ukai (Gerrit)

unread,
Jan 13, 2026, 11:37:24 PM (4 hours ago) Jan 13
to Marc Jin, Fumitoshi Ukai, LUCI CQ, Richard Wang, Junji Watanabe, chromium...@chromium.org
Attention needed from Junji Watanabe, Marc Jin and Richard Wang

Fumitoshi Ukai voted and added 1 comment

Votes added by Fumitoshi Ukai

Code-Review+1

1 comment

Commit Message
Line 10, Patchset 1 (Latest):
Fumitoshi Ukai . unresolved

explain reland reason?

Open in Gerrit

Related details

Attention is currently required from:
  • Junji Watanabe
  • Marc Jin
  • Richard Wang
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/tools/build
Gerrit-Branch: main
Gerrit-Change-Id: I6dab42b19fd7bb6620cf05510d929b6b850b300e
Gerrit-Change-Number: 7469598
Gerrit-PatchSet: 1
Gerrit-Owner: Marc Jin <jm...@google.com>
Gerrit-Reviewer: Fumitoshi Ukai <uk...@google.com>
Gerrit-Reviewer: Junji Watanabe <jw...@google.com>
Gerrit-Reviewer: Marc Jin <jm...@google.com>
Gerrit-Reviewer: Richard Wang <rich...@google.com>
Gerrit-Attention: Richard Wang <rich...@google.com>
Gerrit-Attention: Junji Watanabe <jw...@google.com>
Gerrit-Attention: Marc Jin <jm...@google.com>
Gerrit-Comment-Date: Wed, 14 Jan 2026 04:37:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Junji Watanabe (Gerrit)

unread,
12:32 AM (3 hours ago) 12:32 AM
to Marc Jin, Fumitoshi Ukai, LUCI CQ, Richard Wang, chromium...@chromium.org
Attention needed from Marc Jin and Richard Wang

Junji Watanabe added 1 comment

Commit Message
Line 10, Patchset 2 (Latest):https://chromium-review.googlesource.com/c/infra/infra/+/7457920 was
submitted to fix that.
Junji Watanabe . unresolved

We need to do a new Siso release.

Open in Gerrit

Related details

Attention is currently required from:
  • Marc Jin
  • Richard Wang
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/tools/build
Gerrit-Branch: main
Gerrit-Change-Id: I6dab42b19fd7bb6620cf05510d929b6b850b300e
Gerrit-Change-Number: 7469598
Gerrit-PatchSet: 2
Gerrit-Owner: Marc Jin <jm...@google.com>
Gerrit-Reviewer: Fumitoshi Ukai <uk...@google.com>
Gerrit-Reviewer: Junji Watanabe <jw...@google.com>
Gerrit-Reviewer: Marc Jin <jm...@google.com>
Gerrit-Reviewer: Richard Wang <rich...@google.com>
Gerrit-Attention: Richard Wang <rich...@google.com>
Gerrit-Attention: Marc Jin <jm...@google.com>
Gerrit-Comment-Date: Wed, 14 Jan 2026 05:32:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Junji Watanabe (Gerrit)

unread,
12:34 AM (3 hours ago) 12:34 AM
to Marc Jin, Fumitoshi Ukai, LUCI CQ, Richard Wang, chromium...@chromium.org
Attention needed from Marc Jin and Richard Wang

Junji Watanabe added 1 comment

Commit Message
Junji Watanabe . unresolved

We need to do a new Siso release.

Junji Watanabe

We need to do a new Siso release.

This is tracked in http://b/475340673.

Gerrit-Comment-Date: Wed, 14 Jan 2026 05:34:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Junji Watanabe <jw...@google.com>
satisfied_requirement
unsatisfied_requirement
open
diffy

Junji Watanabe (Gerrit)

unread,
12:36 AM (3 hours ago) 12:36 AM
to Marc Jin, Fumitoshi Ukai, LUCI CQ, Richard Wang, chromium...@chromium.org
Attention needed from Marc Jin and Richard Wang

Junji Watanabe added 1 comment

Commit Message
Junji Watanabe . resolved

We need to do a new Siso release.

Junji Watanabe

We need to do a new Siso release.

This is tracked in http://b/475340673.

Junji Watanabe

My bad. I was confused with Siso.

Gerrit-Comment-Date: Wed, 14 Jan 2026 05:36:53 +0000
satisfied_requirement
unsatisfied_requirement
open
diffy

Marc Jin (Gerrit)

unread,
12:38 AM (3 hours ago) 12:38 AM
to Fumitoshi Ukai, LUCI CQ, Richard Wang, Junji Watanabe, chromium...@chromium.org
Attention needed from Junji Watanabe and Richard Wang

Marc Jin added 2 comments

Commit Message
Line 10, Patchset 1:
Fumitoshi Ukai . resolved

explain reland reason?

Marc Jin

Done

Junji Watanabe . resolved

We need to do a new Siso release.

Junji Watanabe

We need to do a new Siso release.

This is tracked in http://b/475340673.

Junji Watanabe

My bad. I was confused with Siso.

Marc Jin

No worries!

Open in Gerrit

Related details

Attention is currently required from:
  • Junji Watanabe
  • Richard Wang
Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/tools/build
    Gerrit-Branch: main
    Gerrit-Change-Id: I6dab42b19fd7bb6620cf05510d929b6b850b300e
    Gerrit-Change-Number: 7469598
    Gerrit-PatchSet: 2
    Gerrit-Owner: Marc Jin <jm...@google.com>
    Gerrit-Reviewer: Fumitoshi Ukai <uk...@google.com>
    Gerrit-Reviewer: Junji Watanabe <jw...@google.com>
    Gerrit-Reviewer: Marc Jin <jm...@google.com>
    Gerrit-Reviewer: Richard Wang <rich...@google.com>
    Gerrit-Attention: Richard Wang <rich...@google.com>
    Gerrit-Attention: Junji Watanabe <jw...@google.com>
    Gerrit-Comment-Date: Wed, 14 Jan 2026 05:38:53 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Fumitoshi Ukai <uk...@google.com>
    Comment-In-Reply-To: Junji Watanabe <jw...@google.com>
    satisfied_requirement
    open
    diffy

    Junji Watanabe (Gerrit)

    unread,
    12:39 AM (3 hours ago) 12:39 AM
    to Marc Jin, Fumitoshi Ukai, LUCI CQ, Richard Wang, chromium...@chromium.org
    Attention needed from Junji Watanabe and Richard Wang

    Junji Watanabe voted and added 1 comment

    Votes added by Junji Watanabe

    Code-Review+1

    1 comment

    Commit Message
    Junji Watanabe . resolved

    We need to do a new Siso release.

    Junji Watanabe

    We need to do a new Siso release.

    This is tracked in http://b/475340673.

    Junji Watanabe

    My bad. I was confused with Siso.

    Gerrit-Comment-Date: Wed, 14 Jan 2026 05:39:17 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    Comment-In-Reply-To: Junji Watanabe <jw...@google.com>
    satisfied_requirement
    open
    diffy

    Marc Jin (Gerrit)

    unread,
    12:42 AM (3 hours ago) 12:42 AM
    to Junji Watanabe, Fumitoshi Ukai, LUCI CQ, Richard Wang, chromium...@chromium.org
    Attention needed from Junji Watanabe and Richard Wang

    Marc Jin voted Commit-Queue+2

    Commit-Queue+2
    Gerrit-Comment-Date: Wed, 14 Jan 2026 05:42:26 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    LUCI CQ (Gerrit)

    unread,
    12:47 AM (2 hours ago) 12:47 AM
    to Marc Jin, Junji Watanabe, Fumitoshi Ukai, Richard Wang, chromium...@chromium.org

    LUCI CQ submitted the change

    Change information

    Commit message:
    Reland "chromium_codesearch: Enable use_siso in the package_index tool."

    A previous land caused OOM for codesearch builder: b/474299329. Then
    This is a reland of commit a1da1f8967e53ecb321a257e17f02562f47ad2f7

    Original change's description:
    > chromium_codesearch: Enable use_siso in the package_index tool.
    >
    > This change will enable codesearch builders reading dependencies from
    > siso instead of translation_unit.
    >
    > Bug: 460271270
    > Change-Id: Iaa5720248ae98f5c1ca0961fecc1ee1e19e6b913
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/build/+/7409627
    > Reviewed-by: Junji Watanabe <jw...@google.com>
    > Reviewed-by: Richard Wang <rich...@google.com>
    > Commit-Queue: Marc Jin <jm...@google.com>
    Bug: 460271270
    Change-Id: I6dab42b19fd7bb6620cf05510d929b6b850b300e
    Reviewed-by: Junji Watanabe <jw...@google.com>
    Reviewed-by: Fumitoshi Ukai <uk...@google.com>
    Commit-Queue: Marc Jin <jm...@google.com>
    Files:
    • M recipes/recipes/chromium_codesearch.expected/full_codesearch_gen_chromium_linux.json
    • M recipes/recipes/chromium_codesearch.expected/full_codesearch_gen_chromium_linux_internal.json
    • M recipes/recipes/chromium_codesearch.expected/full_codesearch_gen_chromium_linux_internal_with_revision.json
    • M recipes/recipes/chromium_codesearch.expected/full_codesearch_gen_chromium_linux_last_compile_fail.json
    • M recipes/recipes/chromium_codesearch.expected/full_codesearch_gen_chromium_linux_sync_generated_files_fail.json
    • M recipes/recipes/chromium_codesearch.expected/full_codesearch_gen_chromium_linux_with_revision.json
    • M recipes/recipes/chromium_codesearch.expected/full_gen_linux_try_with_patch.json
    • M recipes/recipes/chromium_codesearch.py
    Change size: M
    Delta: 8 files changed, 184 insertions(+), 8 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Fumitoshi Ukai, +1 by Junji Watanabe
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/tools/build
    Gerrit-Branch: main
    Gerrit-Change-Id: I6dab42b19fd7bb6620cf05510d929b6b850b300e
    Gerrit-Change-Number: 7469598
    Gerrit-PatchSet: 3
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages