[DangerousDownloadInterstitial] Add handler for logging save dangerous from interstitial action. [chromium/src : main]

0 views

Skip to first unread message

gwsq (Gerrit)

unread,

9:27 PM (2 hours ago) 9:27 PM

to Kerry Meng-Lin, Chromium IPC Reviews, Tom Sepez, Xinghui Lu, Daniel Rubery, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, blundell+...@chromium.org, chlily...@chromium.org, druber...@chromium.org, dtraino...@chromium.org, ipc-securi...@chromium.org

Attention needed from Daniel Rubery, Tom Sepez and Xinghui Lu

Message from gwsq

From googleclient/chrome/chromium_gwsq/ipc/config.gwsq:
IPC: tse...@chromium.org

📎 It looks like you’re making a possibly security-sensitive change! 📎 IPC security review isn’t a rubberstamp, so your friendly security reviewer will need a fair amount of context to review your CL effectively. Please review your CL description and code comments to make sure they provide context for someone unfamiliar with your project/area. Pay special attention to where data comes from and which processes it flows between (and their privilege levels). Feel free to point your security reviewer at design docs, bugs, or other links if you can’t reasonably make a self-contained CL description. (Also see https://cbea.ms/git-commit/).

IPC reviewer(s): tse...@chromium.org

Reviewer source(s):
tse...@chromium.org is from context(googleclient/chrome/chromium_gwsq/ipc/config.gwsq)

Open in Gerrit