Remove xiyuan@ from various OWNERS [chromium/src : main]
0 views
Skip to first unread message
Xiyuan Xia (Gerrit)
Sep 23, 2025, 1:22:43 PM (2 days ago) Sep 23
to James Cook, Toni Barzic, Achuith Bhandarkar, Hidehiko Abe, Mitsuru Oshima, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, oshima...@chromium.org, rrsilva+wat...@google.com, tbarzi...@chromium.org
Attention needed from James Cook
Xiyuan Xia added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- James Cook
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
James Cook (Gerrit)
Sep 23, 2025, 1:53:39 PM (2 days ago) Sep 23
to Xiyuan Xia, Toni Barzic, Achuith Bhandarkar, Hidehiko Abe, Mitsuru Oshima, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, oshima...@chromium.org, rrsilva+wat...@google.com, tbarzi...@chromium.org
Attention needed from Xiyuan Xia
James Cook added 1 comment![]( "Open in Gerrit")
Patchset-level comments
James Cook . resolved
I hate to ask you to do this, but can you CC all the other owners for the files you're removing yourself from. I want to make sure they are aware you aren't an owner any more. Or you could email them separately and let me know. If you go the CC route it might be easier to break this CL into multiple smaller ones. Up to you.
Related details
Attention is currently required from:
- Xiyuan Xia
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
James Cook (Gerrit)
Sep 23, 2025, 1:54:42 PM (2 days ago) Sep 23
to Xiyuan Xia, Toni Barzic, Achuith Bhandarkar, Hidehiko Abe, Mitsuru Oshima, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, oshima...@chromium.org, rrsilva+wat...@google.com, tbarzi...@chromium.org
Attention needed from Xiyuan Xia
James Cook added 1 comment![]( "Open in Gerrit")
Patchset-level comments
James Cook . resolved
(My reasoning is that the existing owners may want to find a new owner to add, like you did with Toni.)
Related details
Attention is currently required from:
- Xiyuan Xia
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Xiyuan Xia (Gerrit)
Sep 23, 2025, 5:30:42 PM (2 days ago) Sep 23
to Yury Khmel, Alex Newcomer, Yichen Zhou, Greg Thompson, Chad Duffin, Xiaoqian Dai, Kyle Horimoto, Colin Blundell, Nico Weber, James Cook, Toni Barzic, Achuith Bhandarkar, Hidehiko Abe, Mitsuru Oshima, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, oshima...@chromium.org, rrsilva+wat...@google.com, tbarzi...@chromium.org
Xiyuan Xia added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Xiyuan Xia . resolved
cc more OWNERS in case they have inputs (e.g. including new OWNERS):
khmel@:
tbarzic@:
newcomer@:
ash/app_list/OWNERS,
ash/app_menu/OWNERS
ash/shelf/OWNERS
chrome/browser/ash/app_list/OWNERS,
achuith@:
hidehiko@:
ash/session/OWNERS
components/session_manager/OWNERS
achuith@:
yichenz@:
chrome/browser/ash/performance/OWNERS
grt@:
chrome/browser/upgrade_detector/OWNERS
chadduffin@:
chrome/test/base/ash/interactive/OWNERS
antrim@:
achuith@:
chromeos/ash/components/login/OWNERS
components/user_manager/OWNERS
jame...@chromium.org
osh...@chromium.org
xd...@chromium.org:
chromeos/ui/OWNERS
jame...@chromium.org
khor...@chromium.org
osh...@chromium.org
ui/chromeos/OWNERS
blun...@chromium.org
osh...@chromium.org
tha...@chromium.org
ui/OWNERS
osh...@chromium.org
ui/wm/OWNERS
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
James Cook (Gerrit)
Sep 23, 2025, 6:13:20 PM (2 days ago) Sep 23
to Xiyuan Xia, Yury Khmel, Alex Newcomer, Yichen Zhou, Greg Thompson, Chad Duffin, Xiaoqian Dai, Kyle Horimoto, Colin Blundell, Nico Weber, Toni Barzic, Achuith Bhandarkar, Hidehiko Abe, Mitsuru Oshima, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, oshima...@chromium.org, rrsilva+wat...@google.com, tbarzi...@chromium.org
Attention needed from Xiyuan Xia
James Cook voted and added 4 comments![]( "Open in Gerrit")
Votes added by James Cook
| Code-Review | +1 |
4 comments
Patchset-level comments
James Cook . resolved
LGTM. Thanks for CC-ing everybody. We'll miss you.
File ash/session/OWNERS
Line 1, Patchset 1 (Latest):
hide...@chromium.orgJames Cook . unresolved
hidehiko, we should probably find a second owner for this directory. Can you think of anyone? (Not for this CL)
File chrome/browser/upgrade_detector/OWNERS
Line 1, Patchset 1 (Latest):
g...@chromium.orgJames Cook . unresolved
grt, we should probably add another owner here. Can you think of anyone? (Not for this CL.)
File ui/wm/OWNERS
Line 1, Patchset 1 (Latest):
osh...@chromium.orgJames Cook . unresolved
oshima, can you think of another owner we could add here? (Not for this CL.)
Related details
Attention is currently required from:
- Xiyuan Xia
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alex Newcomer (Gerrit)
Sep 23, 2025, 6:16:24 PM (2 days ago) Sep 23
to Xiyuan Xia, James Cook, Yury Khmel, Yichen Zhou, Greg Thompson, Chad Duffin, Xiaoqian Dai, Kyle Horimoto, Colin Blundell, Nico Weber, Toni Barzic, Achuith Bhandarkar, Hidehiko Abe, Mitsuru Oshima, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, oshima...@chromium.org, rrsilva+wat...@google.com, tbarzi...@chromium.org
Attention needed from Xiyuan Xia
Alex Newcomer added 1 comment![]( "Open in Gerrit")
Patchset-level comments
James Cook . resolved
LGTM. Thanks for CC-ing everybody. We'll miss you.
Alex Newcomer
+1!
Yichen Zhou (Gerrit)
Sep 23, 2025, 6:18:55 PM (2 days ago) Sep 23
to Xiyuan Xia, James Cook, Yury Khmel, Alex Newcomer, Greg Thompson, Chad Duffin, Xiaoqian Dai, Kyle Horimoto, Colin Blundell, Nico Weber, Toni Barzic, Achuith Bhandarkar, Hidehiko Abe, Mitsuru Oshima, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, oshima...@chromium.org, rrsilva+wat...@google.com, tbarzi...@chromium.org
Attention needed from Alex Newcomer and Xiyuan Xia
Yichen Zhou added 1 comment![]( "Open in Gerrit")
Patchset-level comments
James Cook . resolved
Alex NewcomerLGTM. Thanks for CC-ing everybody. We'll miss you.
+1!
Attention is currently required from:
- Alex Newcomer
- Xiyuan Xia
Xiaoqian Dai (Gerrit)
Sep 23, 2025, 6:23:08 PM (2 days ago) Sep 23
to Xiyuan Xia, Xiaoqian Dai, James Cook, Yury Khmel, Alex Newcomer, Yichen Zhou, Greg Thompson, Chad Duffin, Kyle Horimoto, Colin Blundell, Nico Weber, Toni Barzic, Achuith Bhandarkar, Hidehiko Abe, Mitsuru Oshima, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, oshima...@chromium.org, rrsilva+wat...@google.com, tbarzi...@chromium.org
Attention needed from Alex Newcomer, Xiyuan Xia and Yichen Zhou
Xiaoqian Dai voted and added 2 comments![]( "Open in Gerrit")
Votes added by Xiaoqian Dai
| Code-Review | +1 |
2 comments
Patchset-level comments
James Cook . resolved
Alex NewcomerLGTM. Thanks for CC-ing everybody. We'll miss you.
Yichen Zhou+1!
+1!!
Xiaoqian Dai
+1... ðŸ˜
Attention is currently required from:
- Alex Newcomer
- Xiyuan Xia
- Yichen Zhou
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Toni Barzic (Gerrit)
Sep 23, 2025, 6:31:33 PM (2 days ago) Sep 23
to Xiyuan Xia, Xiaoqian Dai, James Cook, Yury Khmel, Alex Newcomer, Yichen Zhou, Greg Thompson, Chad Duffin, Kyle Horimoto, Colin Blundell, Nico Weber, Achuith Bhandarkar, Hidehiko Abe, Mitsuru Oshima, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, oshima...@chromium.org, rrsilva+wat...@google.com, tbarzi...@chromium.org
Attention needed from Alex Newcomer, Xiyuan Xia and Yichen Zhou
Toni Barzic voted and added 1 comment![]( "Open in Gerrit")
Votes added by Toni Barzic
| Code-Review | +1 |
1 comment
Patchset-level comments
James Cook . resolved
Alex NewcomerLGTM. Thanks for CC-ing everybody. We'll miss you.
Yichen Zhou+1!
Xiaoqian Dai+1!!
+1... ðŸ˜
Toni Barzic
+1 :(
Related details
Attention is currently required from:
- Alex Newcomer
- Xiyuan Xia
- Yichen Zhou
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hidehiko Abe (Gerrit)
Sep 23, 2025, 8:11:07 PM (2 days ago) Sep 23
to Xiyuan Xia, Toni Barzic, Xiaoqian Dai, James Cook, Yury Khmel, Alex Newcomer, Yichen Zhou, Greg Thompson, Chad Duffin, Kyle Horimoto, Colin Blundell, Nico Weber, Achuith Bhandarkar, Mitsuru Oshima, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, oshima...@chromium.org, rrsilva+wat...@google.com, tbarzi...@chromium.org
Attention needed from Alex Newcomer, Xiyuan Xia and Yichen Zhou
Hidehiko Abe voted and added 1 comment![]( "Open in Gerrit")
Votes added by Hidehiko Abe
| Code-Review | +1 |
1 comment
File ash/session/OWNERS
James Cook . unresolved
hidehiko, we should probably find a second owner for this directory. Can you think of anyone? (Not for this CL)
Hidehiko Abe
ok, I'll ask around, and add someone later.
Related details
Attention is currently required from:
- Alex Newcomer
- Xiyuan Xia
- Yichen Zhou
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nico Weber (Gerrit)
Sep 23, 2025, 8:22:03 PM (2 days ago) Sep 23
to Xiyuan Xia, Nico Weber, Hidehiko Abe, Toni Barzic, Xiaoqian Dai, James Cook, Yury Khmel, Alex Newcomer, Yichen Zhou, Greg Thompson, Chad Duffin, Kyle Horimoto, Colin Blundell, Achuith Bhandarkar, Mitsuru Oshima, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, oshima...@chromium.org, rrsilva+wat...@google.com, tbarzi...@chromium.org
Attention needed from Alex Newcomer, Xiyuan Xia and Yichen Zhou
Nico Weber voted and added 1 comment![]( "Open in Gerrit")
Votes added by Nico Weber
| Code-Review | +1 |
1 comment
Patchset-level comments
Nico Weber . resolved
safe travels!
Related details
Attention is currently required from:
- Alex Newcomer
- Xiyuan Xia
- Yichen Zhou
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Greg Thompson (Gerrit)
Sep 24, 2025, 5:00:12 AM (yesterday) Sep 24
to Xiyuan Xia, Nico Weber, Hidehiko Abe, Toni Barzic, Xiaoqian Dai, James Cook, Yury Khmel, Alex Newcomer, Yichen Zhou, Chad Duffin, Kyle Horimoto, Colin Blundell, Achuith Bhandarkar, Mitsuru Oshima, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, oshima...@chromium.org, rrsilva+wat...@google.com, tbarzi...@chromium.org
Attention needed from Alex Newcomer, Xiyuan Xia and Yichen Zhou
Greg Thompson added 1 comment![]( "Open in Gerrit")
File chrome/browser/upgrade_detector/OWNERS
James Cook . unresolved
Greg Thompsongrt, we should probably add another owner here. Can you think of anyone? (Not for this CL.)
It would be nice to have someone from Chrome OS. @xiy...@chromium.org: Is there anyone you care to nominate?
Xiyuan Xia (Gerrit)
11:24 AM (9 hours ago) 11:24 AM
to Nico Weber, Hidehiko Abe, Toni Barzic, Xiaoqian Dai, James Cook, Yury Khmel, Alex Newcomer, Yichen Zhou, Greg Thompson, Chad Duffin, Kyle Horimoto, Colin Blundell, Achuith Bhandarkar, Mitsuru Oshima, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, oshima...@chromium.org, rrsilva+wat...@google.com, tbarzi...@chromium.org
Attention needed from Alex Newcomer, Greg Thompson, James Cook and Yichen Zhou
Xiyuan Xia added 1 comment![]( "Open in Gerrit")
File chrome/browser/upgrade_detector/OWNERS
James Cook . unresolved
Greg Thompsongrt, we should probably add another owner here. Can you think of anyone? (Not for this CL.)
It would be nice to have someone from Chrome OS. @xiy...@chromium.org: Is there anyone you care to nominate?
Xiyuan Xia
I would nominate hidehiko@. Hidehiko is knowledgable about ChromeOS and has reviewed and touched the files here in the past.
hidehiko@, would you be okay with it?
Related details
Attention is currently required from:
- Alex Newcomer
- Greg Thompson
- James Cook
- Yichen Zhou
Hidehiko Abe (Gerrit)
11:52 AM (8 hours ago) 11:52 AM
to Xiyuan Xia, Nico Weber, Toni Barzic, Xiaoqian Dai, James Cook, Yury Khmel, Alex Newcomer, Yichen Zhou, Greg Thompson, Chad Duffin, Kyle Horimoto, Colin Blundell, Achuith Bhandarkar, Mitsuru Oshima, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, oshima...@chromium.org, rrsilva+wat...@google.com, tbarzi...@chromium.org
Attention needed from Alex Newcomer, Greg Thompson, James Cook, Xiyuan Xia and Yichen Zhou
Hidehiko Abe added 1 comment![]( "Open in Gerrit")
File chrome/browser/upgrade_detector/OWNERS
James Cook . unresolved
Greg Thompsongrt, we should probably add another owner here. Can you think of anyone? (Not for this CL.)
Xiyuan XiaIt would be nice to have someone from Chrome OS. @xiy...@chromium.org: Is there anyone you care to nominate?
I would nominate hidehiko@. Hidehiko is knowledgable about ChromeOS and has reviewed and touched the files here in the past.
hidehiko@, would you be okay with it?
Attention is currently required from:
- Alex Newcomer
- Greg Thompson
- James Cook
- Xiyuan Xia
- Yichen Zhou
Xiyuan Xia (Gerrit)
12:01 PM (8 hours ago) 12:01 PM
to Nico Weber, Hidehiko Abe, Toni Barzic, Xiaoqian Dai, James Cook, Yury Khmel, Alex Newcomer, Yichen Zhou, Greg Thompson, Chad Duffin, Kyle Horimoto, Colin Blundell, Achuith Bhandarkar, Mitsuru Oshima, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, oshima...@chromium.org, rrsilva+wat...@google.com, tbarzi...@chromium.org
Attention needed from Alex Newcomer, Greg Thompson, James Cook and Yichen Zhou
Xiyuan Xia added 3 comments![]( "Open in Gerrit")
File ash/session/OWNERS
Hidehiko Abehidehiko, we should probably find a second owner for this directory. Can you think of anyone? (Not for this CL)
ok, I'll ask around, and add someone later.
Xiyuan Xia
Marked as resolved.
File chrome/browser/upgrade_detector/OWNERS
Greg Thompsongrt, we should probably add another owner here. Can you think of anyone? (Not for this CL.)
Xiyuan XiaIt would be nice to have someone from Chrome OS. @xiy...@chromium.org: Is there anyone you care to nominate?
Hidehiko AbeI would nominate hidehiko@. Hidehiko is knowledgable about ChromeOS and has reviewed and touched the files here in the past.
hidehiko@, would you be okay with it?
Sure.
James Cook . unresolved
oshima, can you think of another owner we could add here? (Not for this CL.)
Attention is currently required from:
- Alex Newcomer
- Greg Thompson
- James Cook
- Yichen Zhou
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Xiaoqian Dai (Gerrit)
12:16 PM (8 hours ago) 12:16 PM
to Xiyuan Xia, Nico Weber, Hidehiko Abe, Toni Barzic, Xiaoqian Dai, James Cook, Yury Khmel, Alex Newcomer, Yichen Zhou, Greg Thompson, Chad Duffin, Kyle Horimoto, Colin Blundell, Achuith Bhandarkar, Mitsuru Oshima, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, oshima...@chromium.org, rrsilva+wat...@google.com, tbarzi...@chromium.org
Attention needed from Alex Newcomer, Greg Thompson, James Cook, Xiyuan Xia and Yichen Zhou
Xiaoqian Dai voted and added 1 comment![]( "Open in Gerrit")
Votes added by Xiaoqian Dai
| Code-Review | +1 |
1 comment
File ui/wm/OWNERS
James Cook . resolved
Xiyuan Xiaoshima, can you think of another owner we could add here? (Not for this CL.)
xdai@, would you be okay to listed here?
Attention is currently required from:
- Alex Newcomer
- Greg Thompson
- James Cook
- Xiyuan Xia
- Yichen Zhou
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Xiyuan Xia (Gerrit)
1:00 PM (7 hours ago) 1:00 PM
to Nico Weber, Hidehiko Abe, Toni Barzic, Xiaoqian Dai, James Cook, Yury Khmel, Alex Newcomer, Yichen Zhou, Greg Thompson, Chad Duffin, Kyle Horimoto, Colin Blundell, Achuith Bhandarkar, Mitsuru Oshima, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, oshima...@chromium.org, rrsilva+wat...@google.com, tbarzi...@chromium.org
Attention needed from Alex Newcomer, Greg Thompson, James Cook and Yichen Zhou
Xiyuan Xia voted and added 1 comment![]( "Open in Gerrit")
Votes added by Xiyuan Xia
| Commit-Queue | +2 |
1 comment
Patchset-level comments
File-level comment, Patchset 4 (Latest):
Xiyuan Xia . resolved
Thanks guys. May the force be with you all!
Related details
Attention is currently required from:
- Alex Newcomer
- Greg Thompson
- James Cook
- Yichen Zhou
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
1:06 PM (7 hours ago) 1:06 PM
to Xiyuan Xia, Nico Weber, Hidehiko Abe, Toni Barzic, Xiaoqian Dai, James Cook, Yury Khmel, Alex Newcomer, Yichen Zhou, Greg Thompson, Chad Duffin, Kyle Horimoto, Colin Blundell, Achuith Bhandarkar, Mitsuru Oshima, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, oshima...@chromium.org, rrsilva+wat...@google.com, tbarzi...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Remove xiyuan@ from various OWNERS
chrome/browser/ui/ash/OWNERS: xiyuan -> tbarzic
chrome/browser/upgrade_detector/OWNERS: xiyuan -> hidehiko
ui/wm/OWNERS: xiyuan -> xdai
Removing in other cases.
Bug: None
Change-Id: Iccd0f4e988c902d320b656721bb8a7a146ee278e
Reviewed-by: Xiaoqian Dai <xd...@chromium.org>
Commit-Queue: Xiyuan Xia <xiy...@chromium.org>
Reviewed-by: James Cook <jame...@chromium.org>
Reviewed-by: Hidehiko Abe <hide...@chromium.org>
Reviewed-by: Nico Weber <tha...@chromium.org>
Reviewed-by: Toni Barzic <tba...@google.com>
Cr-Commit-Position: refs/heads/main@{#1520698}
Files:
- M ash/app_list/OWNERS
- M ash/app_menu/OWNERS
- M ash/public/cpp/app_list/OWNERS
- M ash/session/OWNERS
- M ash/shelf/OWNERS
- M chrome/browser/app_mode/OWNERS
- M chrome/browser/ash/app_list/OWNERS
- M chrome/browser/ash/login/saml/OWNERS
- M chrome/browser/ash/performance/OWNERS
- M chrome/browser/resources/gaia_auth_host/OWNERS
- M chrome/browser/sessions/OWNERS
- M chrome/browser/signin/OWNERS
- M chrome/browser/ui/ash/OWNERS
- M chrome/browser/upgrade_detector/OWNERS
- M chrome/test/base/ash/interactive/OWNERS
- M chrome/test/base/chromeos/crosier/OWNERS
- M chromeos/OWNERS
- M chromeos/ash/components/login/OWNERS
- M chromeos/ui/OWNERS
- M components/account_id/OWNERS
- M components/session_manager/OWNERS
- M components/user_manager/OWNERS
- D extensions/browser/api/sockets_tcp/OWNERS
- D extensions/browser/api/sockets_tcp_server/OWNERS
- D extensions/browser/api/sockets_udp/OWNERS
- M ui/OWNERS
- M ui/chromeos/OWNERS
- M ui/wm/OWNERS
Change size: M
Delta: 28 files changed, 18 insertions(+), 49 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Xiaoqian Dai, +1 by Toni Barzic, +1 by Nico Weber, +1 by James Cook, +1 by Hidehiko Abe
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages