Re: Remove DeprecationWarning filtering from testserver.py (issue 10983003)

2 views
Skip to first unread message

ma...@chromium.org

unread,
Oct 26, 2012, 10:10:25 PM10/26/12
to mar...@chromium.org, chromium...@chromium.org, pam+...@chromium.org, cbentze...@chromium.org, dari...@chromium.org
Strange, I never got this email.

On 2012/09/24 23:20:41, Marc-Antoine Ruel wrote:
> lgtm

> Le lundi 24 septembre 2012, <mailto:ma...@chromium.org> a écrit :
> > Reviewers: Marc-Antoine Ruel,
> >
> > Description:
> > Remove DeprecationWarning from testserver.py
> >
> > BUG=none
> >
> >
> > Please review this at http://codereview.chromium.org/10983003/
> >
> > SVN Base: svn://svn.chromium.org/chrome/trunk/src
> >
> > Affected files:
> > M net/tools/testserver/testserver.py
> >
> >
> > Index: net/tools/testserver/testserver.py
> > diff --git a/net/tools/testserver/testserver.py
> b/net/tools/testserver/testserver.py
> > index

aeb0575118b6761feb3069ff64c8e5f4838f2974..33997e951ccb4496be3c70904caff391972626f1
> 100755
> > --- a/net/tools/testserver/testserver.py
> > +++ b/net/tools/testserver/testserver.py
> > @@ -38,9 +38,6 @@ import urlparse
> > import warnings
> > import zlib
> >
> > -# Ignore deprecation warnings, they make our output more cluttered.
> > -warnings.filterwarnings("ignore", category=DeprecationWarning)
> > -
> > import echo_message
> > import pyftpdlib.ftpserver
> > import tlslite
> >
> >
> >



http://codereview.chromium.org/10983003/

commi...@chromium.org

unread,
Oct 26, 2012, 10:11:46 PM10/26/12
to ma...@chromium.org, mar...@chromium.org, chromium...@chromium.org, pam+...@chromium.org, cbentze...@chromium.org, dari...@chromium.org
CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ma...@chromium.org/10983003/10001


https://chromiumcodereview.appspot.com/10983003/

commi...@chromium.org

unread,
Oct 26, 2012, 10:11:48 PM10/26/12
to ma...@chromium.org, mar...@chromium.org, chromium...@chromium.org, pam+...@chromium.org, cbentze...@chromium.org, dari...@chromium.org
Presubmit check for 10983003-10001 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
net/tools/testserver



https://chromiumcodereview.appspot.com/10983003/

ma...@chromium.org

unread,
Oct 26, 2012, 10:14:46 PM10/26/12
to mar...@chromium.org, rten...@chromium.org, chromium...@chromium.org, pam+...@chromium.org, cbentze...@chromium.org, dari...@chromium.org
+rtenneti: quick OWNERS approval

http://codereview.chromium.org/10983003/

rten...@chromium.org

unread,
Oct 26, 2012, 10:19:37 PM10/26/12
to ma...@chromium.org, mar...@chromium.org, chromium...@chromium.org, pam+...@chromium.org, cbentze...@chromium.org, dari...@chromium.org
lgtm



https://chromiumcodereview.appspot.com/10983003/

commi...@chromium.org

unread,
Oct 26, 2012, 10:20:55 PM10/26/12
to ma...@chromium.org, mar...@chromium.org, rten...@chromium.org, chromium...@chromium.org, pam+...@chromium.org, cbentze...@chromium.org, dari...@chromium.org

commi...@chromium.org

unread,
Oct 27, 2012, 2:06:30 AM10/27/12
to ma...@chromium.org, mar...@chromium.org, rten...@chromium.org, chromium...@chromium.org, pam+...@chromium.org, cbentze...@chromium.org, dari...@chromium.org
Change committed as 164516

https://chromiumcodereview.appspot.com/10983003/
Reply all
Reply to author
Forward
0 new messages