IDB WPTs: Extend IDBCursor delete() index WPTs to run on workers [chromium/src : main]
0 views
Skip to first unread message
Rahul Singh (Gerrit)
6:17 PM (5 hours ago) 6:17 PM
to Evan Stade, chromium...@chromium.org, edgecapab...@microsoft.com, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Evan Stade
Rahul Singh voted and added 1 comment![]( "Open in Gerrit")
Votes added by Rahul Singh
| Commit-Queue | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Rahul Singh . resolved
Hi estade@! Here's another mechanical WPT change that extends these cases to run on workers. The only thing of note in this one is that I updated window.cursor usage in one of the testcases to self.cursor so it could run on workers too. This is now ready for your review. Thanks!
Related details
Attention is currently required from:
- Evan Stade
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Evan Stade (Gerrit)
6:29 PM (5 hours ago) 6:29 PM
to Rahul Singh, Chromium LUCI CQ, chromium...@chromium.org, edgecapab...@microsoft.com, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Rahul Singh
Evan Stade voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Rahul Singh
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Blink W3C Test Autoroller (Gerrit)
6:35 PM (5 hours ago) 6:35 PM
to Rahul Singh, Evan Stade, Chromium LUCI CQ, chromium...@chromium.org, edgecapab...@microsoft.com, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Rahul Singh
Message from Blink W3C Test Autoroller![]( "Open in Gerrit")
Exportable changes to web-platform-tests were detected in this CL and a pull request in the upstream repo has been made: https://github.com/web-platform-tests/wpt/pull/46970.
When this CL lands, the bot will automatically merge the PR on GitHub if the required GitHub checks pass; otherwise, ecosystem-infra@ team will triage the failures and may contact you.
WPT Export docs:
https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md#Automatic-export-process
Related details
Attention is currently required from:
- Rahul Singh
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Rahul Singh (Gerrit)
8:31 PM (3 hours ago) 8:31 PM
to Blink W3C Test Autoroller, Evan Stade, Chromium LUCI CQ, chromium...@chromium.org, edgecapab...@microsoft.com, blink-revie...@chromium.org, blink-...@chromium.org
Rahul Singh voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
8:41 PM (3 hours ago) 8:41 PM
to Rahul Singh, Blink W3C Test Autoroller, Evan Stade, chromium...@chromium.org, edgecapab...@microsoft.com, blink-revie...@chromium.org, blink-...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
IDB WPTs: Extend IDBCursor delete() index WPTs to run on workers
This set of IndexedDB WPTs currently only run in a window environment.
This change combines them into a single file and extends them to also
run in dedicated, shared, and service worker environments.
Bug: 41455766
Change-Id: I3e785b52c3c4ba1244343f8c63d85f26ca8c54ab
Commit-Queue: Rahul Singh <rah...@microsoft.com>
Reviewed-by: Evan Stade <est...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1322498}
Files:
- A third_party/blink/web_tests/external/wpt/IndexedDB/idbcursor_delete_index.any.js
- D third_party/blink/web_tests/external/wpt/IndexedDB/idbcursor_delete_index.htm
- D third_party/blink/web_tests/external/wpt/IndexedDB/idbcursor_delete_index2.htm
- D third_party/blink/web_tests/external/wpt/IndexedDB/idbcursor_delete_index3.htm
- D third_party/blink/web_tests/external/wpt/IndexedDB/idbcursor_delete_index4.htm
- D third_party/blink/web_tests/external/wpt/IndexedDB/idbcursor_delete_index5.htm
Change size: L
Delta: 6 files changed, 182 insertions(+), 228 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Evan Stade
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Blink W3C Test Autoroller (Gerrit)
9:27 PM (2 hours ago) 9:27 PM
to Chromium LUCI CQ, Rahul Singh, Evan Stade, chromium...@chromium.org, edgecapab...@microsoft.com, blink-revie...@chromium.org, blink-...@chromium.org
Message from Blink W3C Test Autoroller![]( "Open in Gerrit")
The WPT PR for this CL has been merged upstream! https://github.com/web-platform-tests/wpt/pull/46970
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages