[gardener] Revert "WTF: Fix UNSAFE_TODOs in atomic_operations_test.cc" [chromium/src : main]

0 views
Skip to first unread message

Sana Akbani (Gerrit)

unread,
3:09 PM (6 hours ago) 3:09 PM
to Chromium LUCI CQ, Fredrik Söderquist, Kent Tamura, chromium...@chromium.org
Attention needed from Fredrik Söderquist and Kent Tamura

Sana Akbani has uploaded the change for review

Sana Akbani would like Chromium LUCI CQ, Fredrik Söderquist and Kent Tamura to review this change.

Commit message

[gardener] Revert "WTF: Fix UNSAFE_TODOs in atomic_operations_test.cc"

This reverts commit 8df19cb53752633d3f700304db8e0992e6dbd5d2.

Reason for revert: Many AtomicOperationsTest.* are failing on Linux UBSan Tests builds. See first failed build here: https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20UBSan%20Tests/13073/overview

Original change's description:
> WTF: Fix UNSAFE_TODOs in atomic_operations_test.cc
>
> This CL has no behavior changes.
>
> Bug: 451652367
> Change-Id: I15fbfac4ab2c8a82e814c2900ead114be9741d9f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7480968
> Auto-Submit: Kent Tamura <tk...@chromium.org>
> Reviewed-by: Fredrik Söderquist <f...@opera.com>
> Commit-Queue: Fredrik Söderquist <f...@opera.com>
> Cr-Commit-Position: refs/heads/main@{#1569595}
Bug: 451652367
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: I68bbd15a50452caeff5713eb982c81dcba89d85f

Change diff


Change information

Files:
  • M third_party/blink/renderer/platform/wtf/atomic_operations_test.cc
Change size: S
Delta: 1 file changed, 18 insertions(+), 22 deletions(-)
Open in Gerrit

Related details

Attention is currently required from:
  • Fredrik Söderquist
  • Kent Tamura
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I68bbd15a50452caeff5713eb982c81dcba89d85f
Gerrit-Change-Number: 7486713
Gerrit-PatchSet: 1
Gerrit-Owner: Sana Akbani <sanaa...@google.com>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Fredrik Söderquist <f...@opera.com>
Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
Gerrit-Attention: Fredrik Söderquist <f...@opera.com>
Gerrit-Attention: Kent Tamura <tk...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy

Sana Akbani (Gerrit)

unread,
3:09 PM (6 hours ago) 3:09 PM
to Rubber Stamper, AyeAye, Chromium LUCI CQ, Fredrik Söderquist, Kent Tamura, chromium...@chromium.org, blink-...@chromium.org, blink-re...@chromium.org, kinuko...@chromium.org
Attention needed from Fredrik Söderquist and Kent Tamura

Sana Akbani voted Auto-Submit+1

Auto-Submit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Fredrik Söderquist
  • Kent Tamura
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I68bbd15a50452caeff5713eb982c81dcba89d85f
Gerrit-Change-Number: 7486713
Gerrit-PatchSet: 1
Gerrit-Owner: Sana Akbani <sanaa...@google.com>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Fredrik Söderquist <f...@opera.com>
Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Gerrit-Reviewer: Sana Akbani <sanaa...@google.com>
Gerrit-Attention: Fredrik Söderquist <f...@opera.com>
Gerrit-Attention: Kent Tamura <tk...@chromium.org>
Gerrit-Comment-Date: Thu, 15 Jan 2026 20:09:14 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Rubber Stamper (Gerrit)

unread,
3:10 PM (6 hours ago) 3:10 PM
to Sana Akbani, AyeAye, Chromium LUCI CQ, Fredrik Söderquist, Kent Tamura, chromium...@chromium.org, blink-...@chromium.org, blink-re...@chromium.org, kinuko...@chromium.org
Attention needed from Fredrik Söderquist and Kent Tamura

Rubber Stamper voted

Bot-Commit+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Fredrik Söderquist
  • Kent Tamura
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I68bbd15a50452caeff5713eb982c81dcba89d85f
    Gerrit-Change-Number: 7486713
    Gerrit-PatchSet: 1
    Gerrit-Owner: Sana Akbani <sanaa...@google.com>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Fredrik Söderquist <f...@opera.com>
    Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
    Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
    Gerrit-Reviewer: Sana Akbani <sanaa...@google.com>
    Gerrit-Attention: Fredrik Söderquist <f...@opera.com>
    Gerrit-Attention: Kent Tamura <tk...@chromium.org>
    Gerrit-Comment-Date: Thu, 15 Jan 2026 20:10:07 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Sana Akbani (Gerrit)

    unread,
    3:10 PM (6 hours ago) 3:10 PM
    to Rubber Stamper, AyeAye, Chromium LUCI CQ, Fredrik Söderquist, Kent Tamura, chromium...@chromium.org, blink-...@chromium.org, blink-re...@chromium.org, kinuko...@chromium.org
    Attention needed from Fredrik Söderquist and Kent Tamura

    Sana Akbani voted

    Commit-Queue+2
    Owners-Override+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Fredrik Söderquist
    • Kent Tamura
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I68bbd15a50452caeff5713eb982c81dcba89d85f
    Gerrit-Change-Number: 7486713
    Gerrit-PatchSet: 1
    Gerrit-Owner: Sana Akbani <sanaa...@google.com>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Fredrik Söderquist <f...@opera.com>
    Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
    Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
    Gerrit-Reviewer: Sana Akbani <sanaa...@google.com>
    Gerrit-Attention: Fredrik Söderquist <f...@opera.com>
    Gerrit-Attention: Kent Tamura <tk...@chromium.org>
    Gerrit-Comment-Date: Thu, 15 Jan 2026 20:10:39 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    3:12 PM (6 hours ago) 3:12 PM
    to Sana Akbani, Rubber Stamper, AyeAye, Fredrik Söderquist, Kent Tamura, chromium...@chromium.org, blink-...@chromium.org, blink-re...@chromium.org, kinuko...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    [gardener] Revert "WTF: Fix UNSAFE_TODOs in atomic_operations_test.cc"

    This reverts commit 8df19cb53752633d3f700304db8e0992e6dbd5d2.

    Reason for revert: Many AtomicOperationsTest.* are failing on Linux UBSan Tests builds. See first failed build here: https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20UBSan%20Tests/13073/overview

    Original change's description:
    > WTF: Fix UNSAFE_TODOs in atomic_operations_test.cc
    >
    > This CL has no behavior changes.
    >
    > Bug: 451652367
    > Change-Id: I15fbfac4ab2c8a82e814c2900ead114be9741d9f
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7480968
    > Auto-Submit: Kent Tamura <tk...@chromium.org>
    > Reviewed-by: Fredrik Söderquist <f...@opera.com>
    > Commit-Queue: Fredrik Söderquist <f...@opera.com>
    > Cr-Commit-Position: refs/heads/main@{#1569595}
    Bug: 451652367
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Change-Id: I68bbd15a50452caeff5713eb982c81dcba89d85f
    Owners-Override: Sana Akbani <sanaa...@google.com>
    Bot-Commit: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
    Auto-Submit: Sana Akbani <sanaa...@google.com>
    Commit-Queue: Sana Akbani <sanaa...@google.com>
    Cr-Commit-Position: refs/heads/main@{#1569940}
    Files:
    • M third_party/blink/renderer/platform/wtf/atomic_operations_test.cc
    Change size: S
    Delta: 1 file changed, 18 insertions(+), 22 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: Bot-Commit+1 by Rubber Stamper
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I68bbd15a50452caeff5713eb982c81dcba89d85f
    Gerrit-Change-Number: 7486713
    Gerrit-PatchSet: 2
    open
    diffy
    satisfied_requirement

    Kent Tamura (Gerrit)

    unread,
    6:33 PM (2 hours ago) 6:33 PM
    to Sana Akbani, Chromium LUCI CQ, Kent Tamura, Rubber Stamper, AyeAye, Fredrik Söderquist, chromium...@chromium.org, blink-...@chromium.org, blink-re...@chromium.org, kinuko...@chromium.org

    Kent Tamura voted and added 1 comment

    Votes added by Kent Tamura

    Code-Review+1

    1 comment

    Patchset-level comments
    File-level comment, Patchset 2 (Latest):
    Kent Tamura . resolved

    LGTM. Sorry for the trouble!

    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I68bbd15a50452caeff5713eb982c81dcba89d85f
    Gerrit-Change-Number: 7486713
    Gerrit-PatchSet: 2
    Gerrit-Owner: Sana Akbani <sanaa...@google.com>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Fredrik Söderquist <f...@opera.com>
    Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
    Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
    Gerrit-Reviewer: Sana Akbani <sanaa...@google.com>
    Gerrit-Comment-Date: Thu, 15 Jan 2026 23:32:41 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages