Audio: Add UMA metric for WASAPI input initialization retry outcome [chromium/src : main]

0 views
Skip to first unread message

Fredrik Hernqvist (Gerrit)

unread,
8:10 AM (2 hours ago) 8:10 AM
to Henrik Andreasson, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, feature-me...@chromium.org
Attention needed from Henrik Andreasson

Fredrik Hernqvist added 1 comment

File media/audio/win/audio_low_latency_input_win.cc
Line 2092, Patchset 3 (Latest): base::UmaHistogramEnumeration(
Fredrik Hernqvist . unresolved

This histogram will not be logged if the feature is turned off, so it cannot be used to measure the size of the change in an A/B comparison. I suggest a histogram that is logged with equal frequency for both the enabled and disabled groups.

This histogram could be as simple as a boolean "Media.Audio.Capture.Win.InitializeSucceeded", which just logs whether initialization succeeds (similar to Media.Audio.Capture.Win.InitError.SystemPermissionDenied). This is good because that histogram conversely also proves that initialization doesn't regress.

If you are interested in how often retrying succeeds we can keep this histogram as well.

Open in Gerrit

Related details

Attention is currently required from:
  • Henrik Andreasson
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I389b63d5575817900c019f8cb0c74ba43f0c55c0
Gerrit-Change-Number: 8064281
Gerrit-PatchSet: 3
Gerrit-Owner: Henrik Andreasson <hen...@chromium.org>
Gerrit-Reviewer: Fredrik Hernqvist <fhern...@google.com>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-Attention: Henrik Andreasson <hen...@chromium.org>
Gerrit-Comment-Date: Thu, 09 Jul 2026 12:10:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Henrik Andreasson (Gerrit)

unread,
8:23 AM (2 hours ago) 8:23 AM
to Fredrik Hernqvist, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, feature-me...@chromium.org
Attention needed from Fredrik Hernqvist

Henrik Andreasson added 1 comment

File media/audio/win/audio_low_latency_input_win.cc
Line 2092, Patchset 3 (Latest): base::UmaHistogramEnumeration(
Fredrik Hernqvist . resolved

This histogram will not be logged if the feature is turned off, so it cannot be used to measure the size of the change in an A/B comparison. I suggest a histogram that is logged with equal frequency for both the enabled and disabled groups.

This histogram could be as simple as a boolean "Media.Audio.Capture.Win.InitializeSucceeded", which just logs whether initialization succeeds (similar to Media.Audio.Capture.Win.InitError.SystemPermissionDenied). This is good because that histogram conversely also proves that initialization doesn't regress.

If you are interested in how often retrying succeeds we can keep this histogram as well.

Henrik Andreasson

Added a boolean UMA as well to track success with and without the experiment.

Open in Gerrit

Related details

Attention is currently required from:
  • Fredrik Hernqvist
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I389b63d5575817900c019f8cb0c74ba43f0c55c0
    Gerrit-Change-Number: 8064281
    Gerrit-PatchSet: 3
    Gerrit-Owner: Henrik Andreasson <hen...@chromium.org>
    Gerrit-Reviewer: Fredrik Hernqvist <fhern...@google.com>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-Attention: Fredrik Hernqvist <fhern...@google.com>
    Gerrit-Comment-Date: Thu, 09 Jul 2026 12:23:01 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Fredrik Hernqvist <fhern...@google.com>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Fredrik Hernqvist (Gerrit)

    unread,
    8:31 AM (2 hours ago) 8:31 AM
    to Henrik Andreasson, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, feature-me...@chromium.org
    Attention needed from Henrik Andreasson

    Fredrik Hernqvist voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Henrik Andreasson
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I389b63d5575817900c019f8cb0c74ba43f0c55c0
      Gerrit-Change-Number: 8064281
      Gerrit-PatchSet: 5
      Gerrit-Owner: Henrik Andreasson <hen...@chromium.org>
      Gerrit-Reviewer: Fredrik Hernqvist <fhern...@google.com>
      Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
      Gerrit-Attention: Henrik Andreasson <hen...@chromium.org>
      Gerrit-Comment-Date: Thu, 09 Jul 2026 12:31:35 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy
      Reply all
      Reply to author
      Forward
      0 new messages