Add scriptCount to Long Animation Frame timing [chromium/src : main]

0 views
Skip to first unread message

Joone Hur (Gerrit)

unread,
Jul 18, 2026, 4:35:11 AM (3 days ago) Jul 18
to Noam Rosenthal, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, Olga Gerchikov, android-web...@chromium.org, ashleynewson+watch-...@chromium.org, blink-revie...@chromium.org, blink-revi...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, core-timi...@chromium.org, jmedle...@chromium.org, speed-metrics...@chromium.org
Attention needed from Noam Rosenthal

Joone Hur voted and added 1 comment

Votes added by Joone Hur

Commit-Queue+0

1 comment

Patchset-level comments
File-level comment, Patchset 7 (Latest):
Joone Hur . resolved

Hi Noam,
Thanks for the quick review! This is the second CL in the LoAF series, adding the scriptCount member. Like the previous one, it's gated behind the LongAnimationFrameWorker Blink flag.

Open in Gerrit

Related details

Attention is currently required from:
  • Noam Rosenthal
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ia3e03132ab9254c4ed7b3d944f188d7683210e89
Gerrit-Change-Number: 8115510
Gerrit-PatchSet: 7
Gerrit-Owner: Joone Hur <joon...@microsoft.com>
Gerrit-Reviewer: Joone Hur <joon...@microsoft.com>
Gerrit-Reviewer: Noam Rosenthal <nrose...@google.com>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
Gerrit-Attention: Noam Rosenthal <nrose...@google.com>
Gerrit-Comment-Date: Sat, 18 Jul 2026 08:34:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Noam Rosenthal (Gerrit)

unread,
Jul 20, 2026, 4:54:30 AM (yesterday) Jul 20
to Joone Hur, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, Olga Gerchikov, android-web...@chromium.org, ashleynewson+watch-...@chromium.org, blink-revie...@chromium.org, blink-revi...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, core-timi...@chromium.org, jmedle...@chromium.org, speed-metrics...@chromium.org
Attention needed from Joone Hur

Noam Rosenthal voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Joone Hur
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ia3e03132ab9254c4ed7b3d944f188d7683210e89
Gerrit-Change-Number: 8115510
Gerrit-PatchSet: 7
Gerrit-Owner: Joone Hur <joon...@microsoft.com>
Gerrit-Reviewer: Joone Hur <joon...@microsoft.com>
Gerrit-Reviewer: Noam Rosenthal <nrose...@google.com>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
Gerrit-Attention: Joone Hur <joon...@microsoft.com>
Gerrit-Comment-Date: Mon, 20 Jul 2026 08:54:12 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Blink W3C Test Autoroller (Gerrit)

unread,
Jul 20, 2026, 5:02:14 AM (yesterday) Jul 20
to Joone Hur, Noam Rosenthal, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, Olga Gerchikov, android-web...@chromium.org, ashleynewson+watch-...@chromium.org, blink-revie...@chromium.org, blink-revi...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, core-timi...@chromium.org, jmedle...@chromium.org, speed-metrics...@chromium.org
Attention needed from Joone Hur

Message from Blink W3C Test Autoroller

Exportable changes to web-platform-tests were detected in this CL and a pull request in the upstream repo has been made: https://github.com/web-platform-tests/wpt/pull/61404.

When this CL lands, the bot will automatically merge the PR on GitHub if the required GitHub checks pass; otherwise, ecosystem-infra@ team will triage the failures and may contact you.

WPT Export docs:
https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md#Automatic-export-process

Open in Gerrit

Related details

Attention is currently required from:
  • Joone Hur
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ia3e03132ab9254c4ed7b3d944f188d7683210e89
Gerrit-Change-Number: 8115510
Gerrit-PatchSet: 7
Gerrit-Owner: Joone Hur <joon...@microsoft.com>
Gerrit-Reviewer: Joone Hur <joon...@microsoft.com>
Gerrit-Reviewer: Noam Rosenthal <nrose...@google.com>
Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
Gerrit-Attention: Joone Hur <joon...@microsoft.com>
Gerrit-Comment-Date: Mon, 20 Jul 2026 09:02:00 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
open
diffy

Joone Hur (Gerrit)

unread,
Jul 20, 2026, 11:22:06 AM (22 hours ago) Jul 20
to Blink W3C Test Autoroller, Noam Rosenthal, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, Olga Gerchikov, android-web...@chromium.org, ashleynewson+watch-...@chromium.org, blink-revie...@chromium.org, blink-revi...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, core-timi...@chromium.org, jmedle...@chromium.org, speed-metrics...@chromium.org

Joone Hur voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ia3e03132ab9254c4ed7b3d944f188d7683210e89
Gerrit-Change-Number: 8115510
Gerrit-PatchSet: 7
Gerrit-Owner: Joone Hur <joon...@microsoft.com>
Gerrit-Reviewer: Joone Hur <joon...@microsoft.com>
Gerrit-Reviewer: Noam Rosenthal <nrose...@google.com>
Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
Gerrit-Comment-Date: Mon, 20 Jul 2026 15:21:52 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Jul 20, 2026, 12:15:31 PM (21 hours ago) Jul 20
to Joone Hur, Blink W3C Test Autoroller, Noam Rosenthal, android-bu...@system.gserviceaccount.com, Menard, Alexis, chromium...@chromium.org, Olga Gerchikov, android-web...@chromium.org, ashleynewson+watch-...@chromium.org, blink-revie...@chromium.org, blink-revi...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, core-timi...@chromium.org, jmedle...@chromium.org, speed-metrics...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
Add scriptCount to Long Animation Frame timing

Introduce the `scriptCount` member on
`PerformanceLongAnimationFrameTiming`. It reports the number of
top-level JavaScript entry points observed within the entry's interval,
counted regardless of each entry point's individual duration.
Test: external/wpt/long-animation-frame/loaf-script-count.tentative.html
Bug: 534893134
Change-Id: Ia3e03132ab9254c4ed7b3d944f188d7683210e89
Reviewed-by: Noam Rosenthal <nrose...@google.com>
Commit-Queue: Joone Hur <joon...@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1664728}
Files:
  • M android_webview/test/data/web_tests/webexposed/global-interface-listing-expected.txt
  • M third_party/blink/renderer/core/frame/animation_frame_timing_monitor.cc
  • M third_party/blink/renderer/core/frame/animation_frame_timing_monitor.h
  • M third_party/blink/renderer/core/timing/animation_frame_timing_info.h
  • M third_party/blink/renderer/core/timing/performance_long_animation_frame_timing.cc
  • M third_party/blink/renderer/core/timing/performance_long_animation_frame_timing.h
  • M third_party/blink/renderer/core/timing/performance_long_animation_frame_timing.idl
  • A third_party/blink/web_tests/external/wpt/long-animation-frame/loaf-script-count.tentative.html
  • M third_party/blink/web_tests/webexposed/global-interface-listing-dedicated-worker-expected.txt
  • M third_party/blink/web_tests/webexposed/global-interface-listing-expected.txt
Change size: M
Delta: 10 files changed, 143 insertions(+), 3 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Noam Rosenthal
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ia3e03132ab9254c4ed7b3d944f188d7683210e89
Gerrit-Change-Number: 8115510
Gerrit-PatchSet: 8
Gerrit-Owner: Joone Hur <joon...@microsoft.com>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Joone Hur <joon...@microsoft.com>
Gerrit-Reviewer: Noam Rosenthal <nrose...@google.com>
Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
open
diffy
satisfied_requirement

Blink W3C Test Autoroller (Gerrit)

unread,
Jul 20, 2026, 1:12:52 PM (20 hours ago) Jul 20
to Joone Hur, Chromium LUCI CQ, Noam Rosenthal, android-bu...@system.gserviceaccount.com, Menard, Alexis, chromium...@chromium.org, Olga Gerchikov, android-web...@chromium.org, ashleynewson+watch-...@chromium.org, blink-revie...@chromium.org, blink-revi...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, core-timi...@chromium.org, jmedle...@chromium.org, speed-metrics...@chromium.org

Message from Blink W3C Test Autoroller

The WPT PR for this CL has been merged upstream! https://github.com/web-platform-tests/wpt/pull/61404

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ia3e03132ab9254c4ed7b3d944f188d7683210e89
Gerrit-Change-Number: 8115510
Gerrit-PatchSet: 8
Gerrit-Owner: Joone Hur <joon...@microsoft.com>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Joone Hur <joon...@microsoft.com>
Gerrit-Reviewer: Noam Rosenthal <nrose...@google.com>
Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
Gerrit-Comment-Date: Mon, 20 Jul 2026 17:12:42 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages