Obsolete PasswordProtection.DomFeatureExtractionDuration [chromium/src : main]

0 views
Skip to first unread message

Daniel Rubery (Gerrit)

unread,
Aug 8, 2022, 4:28:27 PM8/8/22
to asvitkine...@chromium.org, druber...@chromium.org, vakh+safe_br...@chromium.org, xinghui...@chromium.org, Rohit Bhatia, Chromium Metrics Reviews, chromium...@chromium.org

Attention is currently required from: Rohit Bhatia.

Patch set 1:Auto-Submit +1Commit-Queue +1

View Change

    To view, visit change 3818028. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Icb98129b0021f69e7040f1d928d5ac213af4cdb0
    Gerrit-Change-Number: 3818028
    Gerrit-PatchSet: 1
    Gerrit-Owner: Daniel Rubery <dru...@chromium.org>
    Gerrit-Reviewer: Daniel Rubery <dru...@chromium.org>
    Gerrit-Reviewer: Rohit Bhatia <bhati...@google.com>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-Attention: Rohit Bhatia <bhati...@google.com>
    Gerrit-Comment-Date: Mon, 08 Aug 2022 20:28:14 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    Gerrit-MessageType: comment

    Rohit Bhatia (Gerrit)

    unread,
    Aug 9, 2022, 1:04:07 AM8/9/22
    to Daniel Rubery, asvitkine...@chromium.org, druber...@chromium.org, vakh+safe_br...@chromium.org, xinghui...@chromium.org, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org

    Attention is currently required from: Daniel Rubery.

    Patch set 1:Code-Review +1Commit-Queue +2

    View Change

      To view, visit change 3818028. To unsubscribe, or for help writing mail filters, visit settings.

      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Icb98129b0021f69e7040f1d928d5ac213af4cdb0
      Gerrit-Change-Number: 3818028
      Gerrit-PatchSet: 1
      Gerrit-Owner: Daniel Rubery <dru...@chromium.org>
      Gerrit-Reviewer: Daniel Rubery <dru...@chromium.org>
      Gerrit-Reviewer: Rohit Bhatia <bhati...@google.com>
      Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
      Gerrit-Attention: Daniel Rubery <dru...@chromium.org>
      Gerrit-Comment-Date: Tue, 09 Aug 2022 05:03:52 +0000

      Chromium LUCI CQ (Gerrit)

      unread,
      Aug 9, 2022, 1:08:45 AM8/9/22
      to Daniel Rubery, asvitkine...@chromium.org, druber...@chromium.org, vakh+safe_br...@chromium.org, xinghui...@chromium.org, Rohit Bhatia, Chromium Metrics Reviews, chromium...@chromium.org

      Chromium LUCI CQ submitted this change.

      View Change


      Approvals: Rohit Bhatia: Looks good to me; Commit Daniel Rubery: Send CL to CQ automatically after approval
      Obsolete PasswordProtection.DomFeatureExtractionDuration

      This histogram has been historically stable, and we aren't closely
      tracking the latency due to this feature this far after the launch.

      Fixed: 1349022
      Change-Id: Icb98129b0021f69e7040f1d928d5ac213af4cdb0
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3818028
      Reviewed-by: Rohit Bhatia <bhati...@google.com>
      Auto-Submit: Daniel Rubery <dru...@chromium.org>
      Commit-Queue: Rohit Bhatia <bhati...@google.com>
      Cr-Commit-Position: refs/heads/main@{#1032876}
      ---
      M components/safe_browsing/content/browser/password_protection/password_protection_request_content.cc
      M components/safe_browsing/content/browser/password_protection/password_protection_request_content.h
      M tools/metrics/histograms/metadata/password/histograms.xml
      3 files changed, 18 insertions(+), 19 deletions(-)


      To view, visit change 3818028. To unsubscribe, or for help writing mail filters, visit settings.

      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Icb98129b0021f69e7040f1d928d5ac213af4cdb0
      Gerrit-Change-Number: 3818028
      Gerrit-PatchSet: 2
      Gerrit-Owner: Daniel Rubery <dru...@chromium.org>
      Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
      Gerrit-Reviewer: Daniel Rubery <dru...@chromium.org>
      Gerrit-Reviewer: Rohit Bhatia <bhati...@google.com>
      Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
      Gerrit-MessageType: merged
      Reply all
      Reply to author
      Forward
      0 new messages