WebUI: Also apply CSS checks to static CSS files in build_webui(). [chromium/src : main]
0 views
Skip to first unread message
Demetrios Papadopoulos (Gerrit)
Feb 6, 2026, 12:54:32 PM (24 hours ago) Feb 6
to Rebekah Potter, Enterprise Policy Reviews, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, borealis-re...@google.com, crost...@chromium.org, druber...@chromium.org, bnc+...@chromium.org, omnibox-...@chromium.org, jdonnel...@chromium.org, dewitt...@chromium.org, oshima...@chromium.org, rrsilva+wat...@google.com, tbarzi...@chromium.org
Attention needed from Rebekah Potter
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Rebekah Potter
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Rebekah Potter (Gerrit)
Feb 6, 2026, 4:54:50 PM (20 hours ago) Feb 6
to Demetrios Papadopoulos, Enterprise Policy Reviews, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, borealis-re...@google.com, crost...@chromium.org, druber...@chromium.org, bnc+...@chromium.org, omnibox-...@chromium.org, jdonnel...@chromium.org, dewitt...@chromium.org, oshima...@chromium.org, rrsilva+wat...@google.com, tbarzi...@chromium.org
Attention needed from Demetrios Papadopoulos
Rebekah Potter voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Demetrios Papadopoulos
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Demetrios Papadopoulos (Gerrit)
Feb 6, 2026, 6:08:02 PM (19 hours ago) Feb 6
to Rebekah Potter, Enterprise Policy Reviews, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, borealis-re...@google.com, crost...@chromium.org, druber...@chromium.org, bnc+...@chromium.org, omnibox-...@chromium.org, jdonnel...@chromium.org, dewitt...@chromium.org, oshima...@chromium.org, rrsilva+wat...@google.com, tbarzi...@chromium.org
Demetrios Papadopoulos voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Feb 6, 2026, 6:53:46 PM (18 hours ago) Feb 6
to Demetrios Papadopoulos, Rebekah Potter, Enterprise Policy Reviews, AyeAye, chromium...@chromium.org, borealis-re...@google.com, crost...@chromium.org, druber...@chromium.org, bnc+...@chromium.org, omnibox-...@chromium.org, jdonnel...@chromium.org, dewitt...@chromium.org, oshima...@chromium.org, rrsilva+wat...@google.com, tbarzi...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
WebUI: Also apply CSS checks to static CSS files in build_webui().
Previously such checks would only apply to the build_webui()'s css_files
list which only includes CSS files corresponding to a web component. CSS
files for the top-level scope can be part of build_webui()'s
static_files and should be checked as well.
All newly discovered violations have been fixed in a precursor CL.
Bug: 475587461
Change-Id: I7187e617b4d05060e4550d65587d26fb070dcde7
Commit-Queue: Demetrios Papadopoulos <dpa...@chromium.org>
Reviewed-by: Rebekah Potter <rbpo...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1581162}
Files:
- M ui/webui/resources/tools/build_webui.gni
Change size: S
Delta: 1 file changed, 30 insertions(+), 6 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Rebekah Potter
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Fred Shih (Gerrit)
Feb 6, 2026, 7:06:10 PM (18 hours ago) Feb 6
to Demetrios Papadopoulos, Chromium LUCI CQ, Rebekah Potter, Enterprise Policy Reviews, AyeAye, chromium...@chromium.org, borealis-re...@google.com, crost...@chromium.org, druber...@chromium.org, bnc+...@chromium.org, omnibox-...@chromium.org, jdonnel...@chromium.org, dewitt...@chromium.org, oshima...@chromium.org, rrsilva+wat...@google.com, tbarzi...@chromium.org
Fred Shih has created a revert of this change![]( "Open in Gerrit")
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Demetrios Papadopoulos (Gerrit)
Feb 6, 2026, 8:09:13 PM (17 hours ago) Feb 6
to Rebekah Potter, Chromium LUCI CQ, chromium...@chromium.org, oshima...@chromium.org
Attention needed from Rebekah Potter
Demetrios Papadopoulos voted![]( "Open in Gerrit")
Attention is currently required from:
- Rebekah Potter
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Rebekah Potter (Gerrit)
Feb 6, 2026, 8:28:23 PM (16 hours ago) Feb 6
to Demetrios Papadopoulos, Chromium LUCI CQ, chromium...@chromium.org, oshima...@chromium.org
Attention needed from Demetrios Papadopoulos
Rebekah Potter voted![]( "Open in Gerrit")
Attention is currently required from:
- Demetrios Papadopoulos
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jason Robert Rauch (Gerrit)
4:22 AM (8 hours ago) 4:22 AM
to Demetrios Papadopoulos, Chromium LUCI CQ, Rebekah Potter, Enterprise Policy Reviews, AyeAye, chromium...@chromium.org, borealis-re...@google.com, crost...@chromium.org, druber...@chromium.org, bnc+...@chromium.org, omnibox-...@chromium.org, jdonnel...@chromium.org, dewitt...@chromium.org, oshima...@chromium.org, rrsilva+wat...@google.com, tbarzi...@chromium.org
Jason Robert Rauch added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 10 (Latest):
Jason Robert Rauch . resolved
hellp please acknolage that you know i am on here as these are my funds I know you are owed some but I at least need your ok I kmow beaucse i dont just take thkings
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages