Set addToBackStack to true for prefs launched within PrivacySettings [chromium/src : main]

0 views
Skip to first unread message

Moe Adel (Gerrit)

unread,
Jan 14, 2026, 4:48:10 PM (yesterday) Jan 14
to Jinsuk Kim, chromium...@chromium.org
Attention needed from Jinsuk Kim

Moe Adel voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Jinsuk Kim
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I6a5824e5300fb0eb8e9ae7faacd4e3e0f3b107dd
Gerrit-Change-Number: 7477226
Gerrit-PatchSet: 1
Gerrit-Owner: Moe Adel <ad...@google.com>
Gerrit-Reviewer: Jinsuk Kim <jins...@chromium.org>
Gerrit-Reviewer: Moe Adel <ad...@google.com>
Gerrit-Attention: Jinsuk Kim <jins...@chromium.org>
Gerrit-Comment-Date: Wed, 14 Jan 2026 21:48:01 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Moe Adel (Gerrit)

unread,
Jan 14, 2026, 4:48:40 PM (yesterday) Jan 14
to Hidehiko Abe, Chromium LUCI CQ, Jinsuk Kim, chromium...@chromium.org
Attention needed from Hidehiko Abe and Jinsuk Kim

Moe Adel added 1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Moe Adel . resolved

Hi @hide...@chromium.org, please review as an owner

Open in Gerrit

Related details

Attention is currently required from:
  • Hidehiko Abe
  • Jinsuk Kim
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I6a5824e5300fb0eb8e9ae7faacd4e3e0f3b107dd
Gerrit-Change-Number: 7477226
Gerrit-PatchSet: 1
Gerrit-Owner: Moe Adel <ad...@google.com>
Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>
Gerrit-Reviewer: Jinsuk Kim <jins...@chromium.org>
Gerrit-Reviewer: Moe Adel <ad...@google.com>
Gerrit-Attention: Jinsuk Kim <jins...@chromium.org>
Gerrit-Attention: Hidehiko Abe <hide...@chromium.org>
Gerrit-Comment-Date: Wed, 14 Jan 2026 21:48:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Jinsuk Kim (Gerrit)

unread,
Jan 14, 2026, 5:12:46 PM (yesterday) Jan 14
to Moe Adel, Hidehiko Abe, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Hidehiko Abe and Moe Adel

Jinsuk Kim voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Hidehiko Abe
  • Moe Adel
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I6a5824e5300fb0eb8e9ae7faacd4e3e0f3b107dd
    Gerrit-Change-Number: 7477226
    Gerrit-PatchSet: 2
    Gerrit-Owner: Moe Adel <ad...@google.com>
    Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>
    Gerrit-Reviewer: Jinsuk Kim <jins...@chromium.org>
    Gerrit-Reviewer: Moe Adel <ad...@google.com>
    Gerrit-Attention: Moe Adel <ad...@google.com>
    Gerrit-Attention: Hidehiko Abe <hide...@chromium.org>
    Gerrit-Comment-Date: Wed, 14 Jan 2026 22:12:38 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Hidehiko Abe (Gerrit)

    unread,
    1:07 AM (20 hours ago) 1:07 AM
    to Moe Adel, Jinsuk Kim, Chromium LUCI CQ, chromium...@chromium.org
    Attention needed from Moe Adel

    Hidehiko Abe voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Moe Adel
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I6a5824e5300fb0eb8e9ae7faacd4e3e0f3b107dd
    Gerrit-Change-Number: 7477226
    Gerrit-PatchSet: 2
    Gerrit-Owner: Moe Adel <ad...@google.com>
    Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>
    Gerrit-Reviewer: Jinsuk Kim <jins...@chromium.org>
    Gerrit-Reviewer: Moe Adel <ad...@google.com>
    Gerrit-Attention: Moe Adel <ad...@google.com>
    Gerrit-Comment-Date: Thu, 15 Jan 2026 06:07:21 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Moe Adel (Gerrit)

    unread,
    12:19 PM (8 hours ago) 12:19 PM
    to Hidehiko Abe, Jinsuk Kim, Chromium LUCI CQ, chromium...@chromium.org

    Moe Adel voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I6a5824e5300fb0eb8e9ae7faacd4e3e0f3b107dd
    Gerrit-Change-Number: 7477226
    Gerrit-PatchSet: 2
    Gerrit-Owner: Moe Adel <ad...@google.com>
    Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>
    Gerrit-Reviewer: Jinsuk Kim <jins...@chromium.org>
    Gerrit-Reviewer: Moe Adel <ad...@google.com>
    Gerrit-Comment-Date: Thu, 15 Jan 2026 17:19:09 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Moe Adel (Gerrit)

    unread,
    2:45 PM (6 hours ago) 2:45 PM
    to Wenyu Fu, Hidehiko Abe, Jinsuk Kim, Chromium LUCI CQ, chromium...@chromium.org
    Attention needed from Hidehiko Abe, Jinsuk Kim and Wenyu Fu

    Moe Adel added 1 comment

    Patchset-level comments
    File-level comment, Patchset 3 (Latest):
    Moe Adel . resolved

    adding @wen...@chromium.org for a faster same timezone review

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Hidehiko Abe
    • Jinsuk Kim
    • Wenyu Fu
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I6a5824e5300fb0eb8e9ae7faacd4e3e0f3b107dd
    Gerrit-Change-Number: 7477226
    Gerrit-PatchSet: 3
    Gerrit-Owner: Moe Adel <ad...@google.com>
    Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>
    Gerrit-Reviewer: Jinsuk Kim <jins...@chromium.org>
    Gerrit-Reviewer: Moe Adel <ad...@google.com>
    Gerrit-Reviewer: Wenyu Fu <wen...@chromium.org>
    Gerrit-Attention: Jinsuk Kim <jins...@chromium.org>
    Gerrit-Attention: Wenyu Fu <wen...@chromium.org>
    Gerrit-Attention: Hidehiko Abe <hide...@chromium.org>
    Gerrit-Comment-Date: Thu, 15 Jan 2026 19:45:10 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Wenyu Fu (Gerrit)

    unread,
    4:28 PM (4 hours ago) 4:28 PM
    to Moe Adel, Hidehiko Abe, Jinsuk Kim, Chromium LUCI CQ, chromium...@chromium.org
    Attention needed from Hidehiko Abe, Jinsuk Kim and Moe Adel

    Wenyu Fu voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Hidehiko Abe
    • Jinsuk Kim
    • Moe Adel
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I6a5824e5300fb0eb8e9ae7faacd4e3e0f3b107dd
    Gerrit-Change-Number: 7477226
    Gerrit-PatchSet: 3
    Gerrit-Owner: Moe Adel <ad...@google.com>
    Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>
    Gerrit-Reviewer: Jinsuk Kim <jins...@chromium.org>
    Gerrit-Reviewer: Moe Adel <ad...@google.com>
    Gerrit-Reviewer: Wenyu Fu <wen...@chromium.org>
    Gerrit-Attention: Moe Adel <ad...@google.com>
    Gerrit-Attention: Jinsuk Kim <jins...@chromium.org>
    Gerrit-Attention: Hidehiko Abe <hide...@chromium.org>
    Gerrit-Comment-Date: Thu, 15 Jan 2026 21:28:43 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Jinsuk Kim (Gerrit)

    unread,
    6:29 PM (2 hours ago) 6:29 PM
    to Moe Adel, Wenyu Fu, Hidehiko Abe, Chromium LUCI CQ, chromium...@chromium.org
    Attention needed from Hidehiko Abe and Moe Adel

    Jinsuk Kim voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Hidehiko Abe
    • Moe Adel
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I6a5824e5300fb0eb8e9ae7faacd4e3e0f3b107dd
    Gerrit-Change-Number: 7477226
    Gerrit-PatchSet: 3
    Gerrit-Owner: Moe Adel <ad...@google.com>
    Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>
    Gerrit-Reviewer: Jinsuk Kim <jins...@chromium.org>
    Gerrit-Reviewer: Moe Adel <ad...@google.com>
    Gerrit-Reviewer: Wenyu Fu <wen...@chromium.org>
    Gerrit-Attention: Moe Adel <ad...@google.com>
    Gerrit-Attention: Hidehiko Abe <hide...@chromium.org>
    Gerrit-Comment-Date: Thu, 15 Jan 2026 23:29:50 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages