[PDF Ink Signatures] Change text annotations IPH string again [chromium/src : main]

0 views
Skip to first unread message

Andy Phan (Gerrit)

unread,
7:22 PM (2 hours ago) 7:22 PM
to Lei Zhang, Chromium LUCI CQ, chromium...@chromium.org, srahim...@chromium.org
Attention needed from Lei Zhang

Andy Phan voted Auto-Submit+1

Auto-Submit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Lei Zhang
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I15db0df51942199db55008b01cd0c80beca2e8cd
Gerrit-Change-Number: 8135515
Gerrit-PatchSet: 1
Gerrit-Owner: Andy Phan <andy...@chromium.org>
Gerrit-Reviewer: Andy Phan <andy...@chromium.org>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-Attention: Lei Zhang <the...@chromium.org>
Gerrit-Comment-Date: Wed, 22 Jul 2026 23:22:05 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Lei Zhang (Gerrit)

unread,
8:02 PM (1 hour ago) 8:02 PM
to Andy Phan, Lei Zhang, Chromium LUCI CQ, chromium...@chromium.org, srahim...@chromium.org
Attention needed from Andy Phan

Lei Zhang voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Andy Phan
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I15db0df51942199db55008b01cd0c80beca2e8cd
    Gerrit-Change-Number: 8135515
    Gerrit-PatchSet: 1
    Gerrit-Owner: Andy Phan <andy...@chromium.org>
    Gerrit-Reviewer: Andy Phan <andy...@chromium.org>
    Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
    Gerrit-Attention: Andy Phan <andy...@chromium.org>
    Gerrit-Comment-Date: Thu, 23 Jul 2026 00:02:10 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    8:40 PM (20 minutes ago) 8:40 PM
    to Andy Phan, Lei Zhang, chromium...@chromium.org, srahim...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    [PDF Ink Signatures] Change text annotations IPH string again

    Change the text annotations IPH string one more time after aligning with
    UX.
    Change-Id: I15db0df51942199db55008b01cd0c80beca2e8cd
    Commit-Queue: Andy Phan <andy...@chromium.org>
    Auto-Submit: Andy Phan <andy...@chromium.org>
    Reviewed-by: Lei Zhang <the...@chromium.org>
    Commit-Queue: Lei Zhang <the...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1666748}
    Files:
    • M chrome/app/generated_resources.grd
    • M chrome/app/generated_resources_grd/IDS_PDF_TEXT_ANNOTATIONS_IPH_BODY.png.sha1
    Change size: XS
    Delta: 2 files changed, 2 insertions(+), 2 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Lei Zhang
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I15db0df51942199db55008b01cd0c80beca2e8cd
    Gerrit-Change-Number: 8135515
    Gerrit-PatchSet: 2
    Gerrit-Owner: Andy Phan <andy...@chromium.org>
    Gerrit-Reviewer: Andy Phan <andy...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages