Add --is-open-source-project flag to scan.py [chromium/tools/depot_tools : main]

0 views
Skip to first unread message

Rachael Newitt (Gerrit)

unread,
Jan 12, 2026, 4:13:52 PM (3 days ago) Jan 12
to Jordan Brown, LUCI CQ, chromium...@chromium.org, chops-source-team...@google.com
Attention needed from Jordan Brown

Rachael Newitt voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Jordan Brown
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/tools/depot_tools
Gerrit-Branch: main
Gerrit-Change-Id: I45bfbd6cafc0e2fd5884d8845895225dcc9fd1f3
Gerrit-Change-Number: 7297792
Gerrit-PatchSet: 3
Gerrit-Owner: Jordan Brown <r...@google.com>
Gerrit-Reviewer: Jordan Brown <r...@google.com>
Gerrit-Reviewer: Rachael Newitt <rene...@google.com>
Gerrit-Attention: Jordan Brown <r...@google.com>
Gerrit-Comment-Date: Mon, 12 Jan 2026 21:13:45 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Rachael Newitt (Gerrit)

unread,
Jan 12, 2026, 4:15:18 PM (3 days ago) Jan 12
to Jordan Brown, LUCI CQ, chromium...@chromium.org, chops-source-team...@google.com
Attention needed from Jordan Brown

Rachael Newitt added 1 comment

File metadata/scan.py
Line 71, Patchset 3 (Latest): is_open_source_project=args.is_open_source_project)
Rachael Newitt . unresolved

Did you test this? It should be `config.is_open_source_project` `not args. is_open_source_project`. Maybe a test would be good.

Open in Gerrit

Related details

Attention is currently required from:
  • Jordan Brown
Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/tools/depot_tools
    Gerrit-Branch: main
    Gerrit-Change-Id: I45bfbd6cafc0e2fd5884d8845895225dcc9fd1f3
    Gerrit-Change-Number: 7297792
    Gerrit-PatchSet: 3
    Gerrit-Owner: Jordan Brown <r...@google.com>
    Gerrit-Reviewer: Jordan Brown <r...@google.com>
    Gerrit-Reviewer: Rachael Newitt <rene...@google.com>
    Gerrit-Attention: Jordan Brown <r...@google.com>
    Gerrit-Comment-Date: Mon, 12 Jan 2026 21:15:12 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Jordan Brown (Gerrit)

    unread,
    12:26 AM (20 hours ago) 12:26 AM
    to Rachael Newitt, LUCI CQ, chromium...@chromium.org, chops-source-team...@google.com
    Attention needed from Rachael Newitt

    Jordan Brown voted and added 1 comment

    Votes added by Jordan Brown

    Commit-Queue+1

    1 comment

    File metadata/scan.py
    Line 71, Patchset 3: is_open_source_project=args.is_open_source_project)
    Rachael Newitt . resolved

    Did you test this? It should be `config.is_open_source_project` `not args. is_open_source_project`. Maybe a test would be good.

    Jordan Brown

    Done

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Rachael Newitt
    Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/tools/depot_tools
    Gerrit-Branch: main
    Gerrit-Change-Id: I45bfbd6cafc0e2fd5884d8845895225dcc9fd1f3
    Gerrit-Change-Number: 7297792
    Gerrit-PatchSet: 4
    Gerrit-Owner: Jordan Brown <r...@google.com>
    Gerrit-Reviewer: Jordan Brown <r...@google.com>
    Gerrit-Reviewer: Rachael Newitt <rene...@google.com>
    Gerrit-Attention: Rachael Newitt <rene...@google.com>
    Gerrit-Comment-Date: Thu, 15 Jan 2026 05:26:47 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    Comment-In-Reply-To: Rachael Newitt <rene...@google.com>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Jiewei Qian (Gerrit)

    unread,
    6:31 PM (2 hours ago) 6:31 PM
    to Jordan Brown, Rachael Newitt, LUCI CQ, chromium...@chromium.org, chops-source-team...@google.com
    Attention needed from Jordan Brown and Rachael Newitt

    Jiewei Qian voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Jordan Brown
    • Rachael Newitt
    Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/tools/depot_tools
    Gerrit-Branch: main
    Gerrit-Change-Id: I45bfbd6cafc0e2fd5884d8845895225dcc9fd1f3
    Gerrit-Change-Number: 7297792
    Gerrit-PatchSet: 5
    Gerrit-Owner: Jordan Brown <r...@google.com>
    Gerrit-Reviewer: Jiewei Qian <q...@chromium.org>
    Gerrit-Reviewer: Jordan Brown <r...@google.com>
    Gerrit-Reviewer: Rachael Newitt <rene...@google.com>
    Gerrit-Attention: Rachael Newitt <rene...@google.com>
    Gerrit-Attention: Jordan Brown <r...@google.com>
    Gerrit-Comment-Date: Thu, 15 Jan 2026 23:31:04 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Jordan Brown (Gerrit)

    unread,
    6:36 PM (2 hours ago) 6:36 PM
    to Jiewei Qian, Rachael Newitt, LUCI CQ, chromium...@chromium.org, chops-source-team...@google.com
    Attention needed from Rachael Newitt

    Jordan Brown voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Rachael Newitt
    Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/tools/depot_tools
    Gerrit-Branch: main
    Gerrit-Change-Id: I45bfbd6cafc0e2fd5884d8845895225dcc9fd1f3
    Gerrit-Change-Number: 7297792
    Gerrit-PatchSet: 5
    Gerrit-Owner: Jordan Brown <r...@google.com>
    Gerrit-Reviewer: Jiewei Qian <q...@chromium.org>
    Gerrit-Reviewer: Jordan Brown <r...@google.com>
    Gerrit-Reviewer: Rachael Newitt <rene...@google.com>
    Gerrit-Attention: Rachael Newitt <rene...@google.com>
    Gerrit-Comment-Date: Thu, 15 Jan 2026 23:35:59 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    LUCI CQ (Gerrit)

    unread,
    6:50 PM (2 hours ago) 6:50 PM
    to Jordan Brown, Jiewei Qian, Rachael Newitt, chromium...@chromium.org, chops-source-team...@google.com

    LUCI CQ submitted the change

    Change information

    Commit message:
    Add --is-open-source-project flag to scan.py
    Change-Id: I45bfbd6cafc0e2fd5884d8845895225dcc9fd1f3
    Bug: 461287870
    Commit-Queue: Jordan Brown <r...@google.com>
    Reviewed-by: Jiewei Qian <q...@chromium.org>
    Files:
    • M metadata/scan.py
    • M metadata/tests/validate_test.py
    Change size: S
    Delta: 2 files changed, 39 insertions(+), 2 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Jiewei Qian
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/tools/depot_tools
    Gerrit-Branch: main
    Gerrit-Change-Id: I45bfbd6cafc0e2fd5884d8845895225dcc9fd1f3
    Gerrit-Change-Number: 7297792
    Gerrit-PatchSet: 6
    Gerrit-Owner: Jordan Brown <r...@google.com>
    Gerrit-Reviewer: Jiewei Qian <q...@chromium.org>
    Gerrit-Reviewer: Jordan Brown <r...@google.com>
    Gerrit-Reviewer: Rachael Newitt <rene...@google.com>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages