Gate JXL decoder by feature flag [chromium/src : main]

0 views
Skip to first unread message

Wan-Teh Chang (Gerrit)

unread,
Jan 13, 2026, 11:50:24 AMJan 13
to Helmut Januschka, Wan-Teh Chang, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, cblume+im...@chromium.org, kinuko...@chromium.org, mbarowsky+watc...@chromium.org
Attention needed from Helmut Januschka

Wan-Teh Chang added 2 comments

File third_party/blink/web_tests/VirtualTestSuites
Line 1719, Patchset 3 (Latest): "external/wpt/jpegxl"
Wan-Teh Chang . unresolved

Nit: List this line in sorted order.

Line 1722, Patchset 3 (Latest): "external/wpt/jpegxl"
Wan-Teh Chang . unresolved

The changes to this file seem unrelated to the changes to image_decoder.cc. Should these changes be moved to a separate CL?

If we keep these changes in this CL, please describe these changes in the commit message.

Open in Gerrit

Related details

Attention is currently required from:
  • Helmut Januschka
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I8787f9ed17d0c6267e61a5dff1ae312c0932a259
Gerrit-Change-Number: 7463707
Gerrit-PatchSet: 3
Gerrit-Owner: Helmut Januschka <hel...@januschka.com>
Gerrit-Reviewer: Helmut Januschka <hel...@januschka.com>
Gerrit-Reviewer: Wan-Teh Chang <w...@google.com>
Gerrit-Attention: Helmut Januschka <hel...@januschka.com>
Gerrit-Comment-Date: Tue, 13 Jan 2026 16:50:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Wan-Teh Chang (Gerrit)

unread,
Jan 13, 2026, 11:53:40 AMJan 13
to Helmut Januschka, Wan-Teh Chang, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, cblume+im...@chromium.org, kinuko...@chromium.org, mbarowsky+watc...@chromium.org
Attention needed from Helmut Januschka

Wan-Teh Chang added 1 comment

File third_party/blink/renderer/platform/image-decoders/image_decoder.cc
Line 89, Patchset 3 (Latest): if (image_extension == "jxl") {
Wan-Teh Chang . unresolved

This should also be guarded by `ase::FeatureList::IsEnabled(features::kJXLImageFormat)`, right?

Open in Gerrit

Related details

Attention is currently required from:
  • Helmut Januschka
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I8787f9ed17d0c6267e61a5dff1ae312c0932a259
Gerrit-Change-Number: 7463707
Gerrit-PatchSet: 3
Gerrit-Owner: Helmut Januschka <hel...@januschka.com>
Gerrit-Reviewer: Helmut Januschka <hel...@januschka.com>
Gerrit-Reviewer: Wan-Teh Chang <w...@google.com>
Gerrit-Attention: Helmut Januschka <hel...@januschka.com>
Gerrit-Comment-Date: Tue, 13 Jan 2026 16:53:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Helmut Januschka (Gerrit)

unread,
Jan 13, 2026, 12:24:32 PMJan 13
to Helmut Januschka, Wan-Teh Chang, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, cblume+im...@chromium.org, kinuko...@chromium.org, mbarowsky+watc...@chromium.org
Attention needed from Wan-Teh Chang

Helmut Januschka added 3 comments

File third_party/blink/renderer/platform/image-decoders/image_decoder.cc
Line 89, Patchset 3: if (image_extension == "jxl") {
Wan-Teh Chang . resolved

This should also be guarded by `ase::FeatureList::IsEnabled(features::kJXLImageFormat)`, right?

Helmut Januschka

true! done

File third_party/blink/web_tests/VirtualTestSuites
Line 1719, Patchset 3: "external/wpt/jpegxl"
Wan-Teh Chang . resolved

Nit: List this line in sorted order.

Helmut Januschka

Done

Line 1722, Patchset 3: "external/wpt/jpegxl"
Wan-Teh Chang . resolved

The changes to this file seem unrelated to the changes to image_decoder.cc. Should these changes be moved to a separate CL?

If we keep these changes in this CL, please describe these changes in the commit message.

Helmut Januschka

ok here is a sepearat CL, guess it's best to merge this first -> https://chromium-review.googlesource.com/c/chromium/src/+/7456255

Open in Gerrit

Related details

Attention is currently required from:
  • Wan-Teh Chang
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I8787f9ed17d0c6267e61a5dff1ae312c0932a259
    Gerrit-Change-Number: 7463707
    Gerrit-PatchSet: 4
    Gerrit-Owner: Helmut Januschka <hel...@januschka.com>
    Gerrit-Reviewer: Helmut Januschka <hel...@januschka.com>
    Gerrit-Reviewer: Wan-Teh Chang <w...@google.com>
    Gerrit-Attention: Wan-Teh Chang <w...@google.com>
    Gerrit-Comment-Date: Tue, 13 Jan 2026 17:24:14 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Wan-Teh Chang <w...@google.com>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Wan-Teh Chang (Gerrit)

    unread,
    Jan 13, 2026, 1:22:06 PMJan 13
    to Helmut Januschka, Wan-Teh Chang, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, cblume+im...@chromium.org, kinuko...@chromium.org, mbarowsky+watc...@chromium.org
    Attention needed from Helmut Januschka

    Wan-Teh Chang voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Helmut Januschka
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I8787f9ed17d0c6267e61a5dff1ae312c0932a259
    Gerrit-Change-Number: 7463707
    Gerrit-PatchSet: 4
    Gerrit-Owner: Helmut Januschka <hel...@januschka.com>
    Gerrit-Reviewer: Helmut Januschka <hel...@januschka.com>
    Gerrit-Reviewer: Wan-Teh Chang <w...@google.com>
    Gerrit-Attention: Helmut Januschka <hel...@januschka.com>
    Gerrit-Comment-Date: Tue, 13 Jan 2026 18:21:54 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Wan-Teh Chang (Gerrit)

    unread,
    Jan 13, 2026, 2:12:28 PMJan 13
    to Helmut Januschka, Urvang Joshi, Wan-Teh Chang, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, cblume+im...@chromium.org, kinuko...@chromium.org, mbarowsky+watc...@chromium.org
    Attention needed from Helmut Januschka and Urvang Joshi

    Wan-Teh Chang voted and added 1 comment

    Votes added by Wan-Teh Chang

    Code-Review+1

    1 comment

    Patchset-level comments
    File-level comment, Patchset 5 (Latest):
    Wan-Teh Chang . resolved

    Urvang: PTAL. Thanks!

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Helmut Januschka
    • Urvang Joshi
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I8787f9ed17d0c6267e61a5dff1ae312c0932a259
      Gerrit-Change-Number: 7463707
      Gerrit-PatchSet: 5
      Gerrit-Owner: Helmut Januschka <hel...@januschka.com>
      Gerrit-Reviewer: Helmut Januschka <hel...@januschka.com>
      Gerrit-Reviewer: Urvang Joshi <urv...@chromium.org>
      Gerrit-Reviewer: Wan-Teh Chang <w...@google.com>
      Gerrit-Attention: Helmut Januschka <hel...@januschka.com>
      Gerrit-Attention: Urvang Joshi <urv...@chromium.org>
      Gerrit-Comment-Date: Tue, 13 Jan 2026 19:12:16 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Urvang Joshi (Gerrit)

      unread,
      Jan 13, 2026, 2:19:01 PMJan 13
      to Helmut Januschka, Wan-Teh Chang, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, cblume+im...@chromium.org, kinuko...@chromium.org, mbarowsky+watc...@chromium.org
      Attention needed from Helmut Januschka

      Urvang Joshi voted Code-Review+1

      Code-Review+1
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Helmut Januschka
      Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: I8787f9ed17d0c6267e61a5dff1ae312c0932a259
        Gerrit-Change-Number: 7463707
        Gerrit-PatchSet: 5
        Gerrit-Owner: Helmut Januschka <hel...@januschka.com>
        Gerrit-Reviewer: Helmut Januschka <hel...@januschka.com>
        Gerrit-Reviewer: Urvang Joshi <urv...@chromium.org>
        Gerrit-Reviewer: Wan-Teh Chang <w...@google.com>
        Gerrit-Attention: Helmut Januschka <hel...@januschka.com>
        Gerrit-Comment-Date: Tue, 13 Jan 2026 19:18:49 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        open
        diffy

        Helmut Januschka (Gerrit)

        unread,
        Jan 13, 2026, 2:47:26 PMJan 13
        to Helmut Januschka, Urvang Joshi, Wan-Teh Chang, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, cblume+im...@chromium.org, kinuko...@chromium.org, mbarowsky+watc...@chromium.org

        Helmut Januschka voted Commit-Queue+2

        Commit-Queue+2
        Open in Gerrit

        Related details

        Attention set is empty
        Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: I8787f9ed17d0c6267e61a5dff1ae312c0932a259
        Gerrit-Change-Number: 7463707
        Gerrit-PatchSet: 5
        Gerrit-Owner: Helmut Januschka <hel...@januschka.com>
        Gerrit-Reviewer: Helmut Januschka <hel...@januschka.com>
        Gerrit-Reviewer: Urvang Joshi <urv...@chromium.org>
        Gerrit-Reviewer: Wan-Teh Chang <w...@google.com>
        Gerrit-Comment-Date: Tue, 13 Jan 2026 19:47:05 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        open
        diffy

        Chromium LUCI CQ (Gerrit)

        unread,
        Jan 13, 2026, 2:58:06 PMJan 13
        to Helmut Januschka, Urvang Joshi, Wan-Teh Chang, chromium...@chromium.org, blink-...@chromium.org, cblume+im...@chromium.org, kinuko...@chromium.org, mbarowsky+watc...@chromium.org

        Chromium LUCI CQ submitted the change

        Change information

        Commit message:
        Gate JXL decoder by feature flag

        Ensure JXL sniffing and decoder creation only run when the runtime feature is enabled.
        Bug: 462919304,475431061
        Change-Id: I8787f9ed17d0c6267e61a5dff1ae312c0932a259
        Reviewed-by: Wan-Teh Chang <w...@google.com>
        Reviewed-by: Urvang Joshi <urv...@chromium.org>
        Commit-Queue: Helmut Januschka <hel...@januschka.com>
        Cr-Commit-Position: refs/heads/main@{#1568610}
        Files:
        • M third_party/blink/renderer/platform/image-decoders/image_decoder.cc
        Change size: S
        Delta: 1 file changed, 8 insertions(+), 3 deletions(-)
        Branch: refs/heads/main
        Submit Requirements:
        • requirement satisfiedCode-Review: +1 by Wan-Teh Chang, +1 by Urvang Joshi
        Open in Gerrit
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: merged
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: I8787f9ed17d0c6267e61a5dff1ae312c0932a259
        Gerrit-Change-Number: 7463707
        Gerrit-PatchSet: 6
        Gerrit-Owner: Helmut Januschka <hel...@januschka.com>
        Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
        Gerrit-Reviewer: Helmut Januschka <hel...@januschka.com>
        Gerrit-Reviewer: Urvang Joshi <urv...@chromium.org>
        Gerrit-Reviewer: Wan-Teh Chang <w...@google.com>
        open
        diffy
        satisfied_requirement
        Reply all
        Reply to author
        Forward
        0 new messages