[rust] Set `enable_rust_clippy = true` on `linux-rel` bot. [chromium/src : main]

0 views

Skip to first unread message

Łukasz Anforowicz (Gerrit)

unread,

Feb 27, 2026, 5:59:35 PM (8 hours ago) Feb 27

to Devon Loehr, Chromium LUCI CQ, chromium...@chromium.org

Attention needed from Devon Loehr

Łukasz Anforowicz added 1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Łukasz Anforowicz . resolved

@dloehr, can you PTAL?

Open in Gerrit

Related details

Attention is currently required from:

Devon Loehr

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Devon Loehr (Gerrit)

unread,

Feb 27, 2026, 9:45:27 PM (4 hours ago) Feb 27

to Łukasz Anforowicz, Chromium LUCI CQ, chromium...@chromium.org

Attention needed from Łukasz Anforowicz

Devon Loehr voted and added 1 comment

Votes added by Devon Loehr

Code-Review

1 comment

File docs/rust/clippy.md

Line 5, Patchset 1 (Latest):

To opt into running Clippy, please set `enable_rust_clippy = true` in `args.gn`.
With this `args.gn` setting building a 1st-party Rust library will also
invoke Clippy.

Clippy is disabled by default to avoid adding build overhead to
Chromium engineers primarily working with C, C++, or Java.

Engineers working on 1st-party Rust code in Chromium
should consider setting `enable_rust_clippy = true` in their `args.gn`,
but this is optional.
Without this opt-in potential Clippy issues in one's CLs
won’t be detected until a CQ pass.
Additionally, this opt-in is required
to locally repro, fix, and verify Clippy errors (if any).

Devon Loehr . unresolved

I think we can be stronger here; people _really really should_ be enabling clippy locally if they're doing rust work.

```suggestion
When building locally, Clippy is disabled by default to avoid adding build overhead to Chromium engineers primarily working with C, C++, or Java.

However, Clippy warnings are enforced by the CQ. Therefore, it is strongly recommended that engineers working with Rust code enable Clippy warnings by setting `enable_rust_clippy = true` in their `args.gn`.

Doing so allows you to fix Clippy warnings as they occur, rather than waiting to discover them until after uploading a CL. It also lets you verify that you've fixed all the problems when rebuilding locally.
```