webrtc: Replace IceCandidateInterface with IceCandidate [chromium/src : main]
Tomas Gunnarsson (Gerrit)
Tomas Gunnarsson voted![]( "Open in Gerrit")
| Auto-Submit | +1 |
| Commit-Queue | +1 |
Related details
- Daniel Cheng
- Joe Downing
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
AI Code Reviewer (Gerrit)
AI Code Reviewer added 1 comment![]( "Open in Gerrit")
bool AddIceCandidate(const webrtc::IceCandidate* candidate) override;This comment was generated by [Experimental Blink C++ Code Review Agent](http://go/blink-c++-code-review-agent) \
To opt out permanently, please join [Blink AIAgent Optout](https://ganpati2.corp.google.com/group/peep-genai-blink-agent-optout.prod)
Blink Style Guide: Naming - May leave obvious parameter names out of function declarations. The parameter name `candidate` is redundant given the type `IceCandidate` in both `AddIceCandidate` overloads and can be omitted from the header declaration.
For a quick and terse communication, please consider using one of these options: \
Done | b/<bug_id> | Invalid: reason | Won't fix: reason<br/>
NOTE: AI reviews can give wrong results. \
We apologize in advance for any inconvenience and would love to take your feedback to make this better. \
[file a bug](http://go/blink-c++-code-review-agent-feedback) or [ping us on chat](https://chat.google.com/room/AAQA0zhQHe0?cls=4)
Related details
- Daniel Cheng
- Joe Downing
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joe Downing (Gerrit)
Joe Downing voted and added 1 comment![]( "Open in Gerrit")
Votes added by Joe Downing
| Code-Review | +1 |
1 comment
Related details
- Daniel Cheng
- Tomas Gunnarsson
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Daniel Cheng (Gerrit)
Daniel Cheng voted![]( "Open in Gerrit")
- Tomas Gunnarsson
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tomas Gunnarsson (Gerrit)
Tomas Gunnarsson voted and added 1 comment![]( "Open in Gerrit")
Votes added by Tomas Gunnarsson
| Commit-Queue | +2 |
1 comment
bool AddIceCandidate(const webrtc::IceCandidate* candidate) override;This comment was generated by [Experimental Blink C++ Code Review Agent](http://go/blink-c++-code-review-agent) \
To opt out permanently, please join [Blink AIAgent Optout](https://ganpati2.corp.google.com/group/peep-genai-blink-agent-optout.prod)Blink Style Guide: Naming - May leave obvious parameter names out of function declarations. The parameter name `candidate` is redundant given the type `IceCandidate` in both `AddIceCandidate` overloads and can be omitted from the header declaration.
For a quick and terse communication, please consider using one of these options: \
Done | b/<bug_id> | Invalid: reason | Won't fix: reason<br/>NOTE: AI reviews can give wrong results. \
We apologize in advance for any inconvenience and would love to take your feedback to make this better. \
[file a bug](http://go/blink-c++-code-review-agent-feedback) or [ping us on chat](https://chat.google.com/room/AAQA0zhQHe0?cls=4)
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
webrtc: Replace IceCandidateInterface with IceCandidate
The `webrtc::IceCandidateInterface` type is a deprecated alias for
`webrtc::IceCandidate` and is scheduled for removal from the WebRTC
library.
This patch replaces all instances of the deprecated interface with the
canonical `IceCandidate` type.
- M chrome/services/sharing/nearby/platform/webrtc_test.cc
- M remoting/protocol/webrtc_transport.cc
- M remoting/protocol/webrtc_transport.h
- M third_party/blink/renderer/modules/peerconnection/mock_peer_connection_dependency_factory.cc
- M third_party/blink/renderer/modules/peerconnection/mock_peer_connection_dependency_factory.h
- M third_party/blink/renderer/modules/peerconnection/mock_peer_connection_impl.cc
- M third_party/blink/renderer/modules/peerconnection/mock_peer_connection_impl.h
- M third_party/blink/renderer/modules/peerconnection/peer_connection_dependency_factory.cc
- M third_party/blink/renderer/modules/peerconnection/peer_connection_dependency_factory.h
- M third_party/blink/renderer/modules/peerconnection/rtc_peer_connection_handler.cc
- M third_party/blink/renderer/modules/peerconnection/rtc_peer_connection_handler_test.cc
Code-Review: +1 by Joe Downing, +1 by Daniel Cheng
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |