Fix potential null-dereference in PageContentStore::OnDatabaseError [chromium/src : main]
0 views
Skip to first unread message
Siddhartha S (Gerrit)
Jun 18, 2026, 1:52:46 AM (13 days ago) Jun 18
to Jean-Philippe Gravel, Siddhartha S, Chromium LUCI CQ, chromium...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com
Attention needed from Jean-Philippe Gravel
Siddhartha S voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Jean-Philippe Gravel
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Siddhartha S (Gerrit)
Jun 18, 2026, 1:53:04 AM (13 days ago) Jun 18
to Jean-Philippe Gravel, Siddhartha S, Chromium LUCI CQ, chromium...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com
Attention needed from Jean-Philippe Gravel
Siddhartha S voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Jean-Philippe Gravel
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jun 18, 2026, 2:35:27 AM (13 days ago) Jun 18
to Jean-Philippe Gravel, Siddhartha S, chromium...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Fix potential null-dereference in PageContentStore::OnDatabaseError
The OnDatabaseError callback can potentially be called with a nullptr
stmt parameter. This can happen if one of the `db_.Execute(...)` calls
fails (example [1]). `Database::Execute()` doesn't use a `Statement`
object and therefore cannot pass a `Statement` pointer to the error
callback [2].
The null dereference was in a VLOG which fortunately is not enabled by
default. This CL removed the VLOG entirely because it is redundant with
a DVLOG already done by `Database::OnSqliteError()` [3]. This DVLOG has
the advantage of printing the SQL statement even if Database::Execute is
used.
[1] https://crgo.dev/c/c/page_content_annotations/core/page_content_store.cc;l=88;drc=10801327968664eebe6e1ef2eafb5b271bc61a7b
[2] https://crsrc.org/c/sql/database.cc;l=1716;drc=71d8f4a1071b2e13b9985b249ba1ec8e4bde8ae6
[3] https://crsrc.org/c/sql/database.cc;l=2641-2646;drc=71d8f4a1071b2e13b9985b249ba1ec8e4bde8ae6
Bug: 479068638
Change-Id: I3dd0032b488b9cc7246a36f7312dbf62e3bfba03
Reviewed-by: Siddhartha S <ss...@chromium.org>
Commit-Queue: Siddhartha S <ss...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1648822}
Files:
- M components/page_content_annotations/core/page_content_store.cc
Change size: XS
Delta: 1 file changed, 0 insertions(+), 3 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Siddhartha S
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages