Ash: Move Plugin VM uninstaller notification to MessageCenter [chromium/src : main]

[Georg Neis (Gerrit)]

Attention needed from Di Wu

Georg Neis added 3 comments

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Georg Neis . unresolved

What happens if the user logs out while the notification is shown?

File chrome/browser/ash/plugin_vm/plugin_vm_uninstaller_notification.cc

Line 44, Patchset 1 (Latest): Profile* profile) {

Georg Neis . unresolved

Let's take the user or account id here directly if possible.

Line 58, Patchset 1 (Latest): if (user) {

Georg Neis . unresolved

Can this happen? In production? In tests?

Open in Gerrit

Related details

Attention is currently required from:

• Di Wu

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I47b5ab3a32fd951f27008e3256292eb915a11060

Gerrit-Change-Number: 8090287

Gerrit-PatchSet: 1

Gerrit-Owner: Di Wu <di...@google.com>

Gerrit-Reviewer: Di Wu <di...@google.com>

Gerrit-Reviewer: Georg Neis <ne...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Di Wu <di...@google.com>

Gerrit-Comment-Date: Tue, 14 Jul 2026 08:02:46 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Timothy Loh (Gerrit)]

Attention needed from Di Wu

Timothy Loh added 1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Timothy Loh . unresolved

This is probably all dead code now b/526483959. I've been meaning to clean it all up but haven't quite had the time (it's pretty far from my current actual work now).

Open in Gerrit

Related details

Attention is currently required from:

• Di Wu

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I47b5ab3a32fd951f27008e3256292eb915a11060

Gerrit-Change-Number: 8090287

Gerrit-PatchSet: 1

Gerrit-Owner: Di Wu <di...@google.com>

Gerrit-Reviewer: Di Wu <di...@google.com>

Gerrit-Reviewer: Georg Neis <ne...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Timothy Loh <tim...@chromium.org>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Di Wu <di...@google.com>

Gerrit-Comment-Date: Tue, 14 Jul 2026 08:08:24 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Di Wu (Gerrit)]

Attention needed from Georg Neis and Timothy Loh

Di Wu added 4 comments

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Timothy Loh . unresolved

This is probably all dead code now b/526483959. I've been meaning to clean it all up but haven't quite had the time (it's pretty far from my current actual work now).

Di Wu

Thanks Timothy for the pointer. I will turn this CL into a code cleanup. I'll submit the next patchset for you to review. Thanks!

File-level comment, Patchset 1 (Latest):

Georg Neis . resolved

What happens if the user logs out while the notification is shown?

Di Wu

Looks like this feature is now dead code. I'm turning this CL into cleanup. Thanks!

File chrome/browser/ash/plugin_vm/plugin_vm_uninstaller_notification.cc

Line 44, Patchset 1 (Latest): Profile* profile) {

Georg Neis . resolved

Let's take the user or account id here directly if possible.

Di Wu

Looks like this feature is now dead code. I'm turning this CL into cleanup. Thanks!

Line 58, Patchset 1 (Latest): if (user) {

Georg Neis . resolved

Can this happen? In production? In tests?

Di Wu

Looks like this feature is now dead code. I'm turning this CL into cleanup. Thanks!

Open in Gerrit

Related details

Attention is currently required from:

• Georg Neis
• Timothy Loh

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I47b5ab3a32fd951f27008e3256292eb915a11060

Gerrit-Change-Number: 8090287

Gerrit-PatchSet: 1

Gerrit-Owner: Di Wu <di...@google.com>

Gerrit-Reviewer: Di Wu <di...@google.com>

Gerrit-Reviewer: Georg Neis <ne...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Timothy Loh <tim...@chromium.org>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Timothy Loh <tim...@chromium.org>

Gerrit-Attention: Georg Neis <ne...@chromium.org>

Gerrit-Comment-Date: Tue, 14 Jul 2026 09:02:18 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Timothy Loh <tim...@chromium.org>

Comment-In-Reply-To: Georg Neis <ne...@chromium.org>

[Di Wu (Gerrit)]

Di Wu abandoned this change.

View Change

Abandoned the feature is dead so clean it up instead

Di Wu abandoned this change

Related details

Attention set is empty

Submit Requirements:

• Code-Coverage

• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: abandon