[Bookmarks Bar] Setup new profile and device pref for tri-state visibility [chromium/src : main]

[Mark Schillaci (Gerrit)]

Attention needed from Eleanor Lee and Jack Thiesen

Mark Schillaci added 4 comments

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Mark Schillaci . resolved

Hi Eleanor / Jack,

Please see this CL which adds the tri-state setting for bookmarks bar. There is one specific edge case I don't think we can resolve. I've tagged you on the line of code, please see this method in particular and the bug I opened for it (see TODO).

Happy to chat about this offline!

Thanks,

Mark

File chrome/browser/bookmarks/android/java/src/org/chromium/chrome/browser/bookmarks/bar/BookmarkBarUtils.java

Line 376, Patchset 2 (Latest): // We can't deduce the policy value here. By definition the user is not following

Mark Schillaci . unresolved

@elean...@google.com and @jthi...@chromium.org - Please see this method in particular. I don't see another way to go from ONLY_SHOW_ON_NTP back to a original policy recommendation because the policy only has 2 potential states. This creates one very rare corner-case, but happy to have your thoughts on potential other approaches here. Thanks!

File chrome/browser/bookmarks/android/junit/src/org/chromium/chrome/browser/bookmarks/bar/BookmarkBarUtilsTest.java

Line 239, Patchset 2 (Latest): testShowBookmarkBar_DevicePrefs_isEnabled_Policy_Recommended_OverriddenByUserPrefs() {

Mark Schillaci . unresolved

@elean...@google.com - Please double check this test in particular

Line 435, Patchset 2 (Latest): testBookmarkBarVisibilityState_DevicePrefs_isEnabled_Policy_Recommended_OverriddenByUserPrefs() {

Mark Schillaci . unresolved

@elean...@google.com - ditto for this test and the one below

Open in Gerrit

Related details

Attention is currently required from:

• Eleanor Lee
• Jack Thiesen

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I822df92f6f22bd33132dbf65eba14f57762bb0eb

Gerrit-Change-Number: 8221528

Gerrit-PatchSet: 2

Gerrit-Owner: Mark Schillaci <mschi...@google.com>

Gerrit-Reviewer: Eleanor Lee <elean...@google.com>

Gerrit-Reviewer: Jack Thiesen <jthi...@chromium.org>

Gerrit-Reviewer: Mark Schillaci <mschi...@google.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Neha Sapre <neha...@google.com>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Jack Thiesen <jthi...@chromium.org>

Gerrit-Attention: Eleanor Lee <elean...@google.com>

Gerrit-Comment-Date: Sun, 09 Aug 2026 19:38:32 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No