media/gpu/v4l2: Allow enabling AV1 support on Linux [chromium/src : main]
Robert Mader (Gerrit)
Robert Mader added 1 comment![]( "Open in Gerrit")
Hi, here's another small patch to improve V4L2 support on Linux - hope you find time to have a look :)
Related details
- Fritz Koenig
- Nathan Hebert
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nathan Hebert (Gerrit)
Nathan Hebert voted and added 1 comment![]( "Open in Gerrit")
Votes added by Nathan Hebert
| Code-Review | +1 |
1 comment
Re-use of the flag looks good to me.
Related details
- Fritz Koenig
- Robert Mader
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nathan Hebert (Gerrit)
Nathan Hebert added 1 comment![]( "Open in Gerrit")
#ifdef UNSAFE_BUFFERS_BUILDNote to other reviewers: Every other decoder delegate uses this `#pragma`. It makes sense that changing the build files, would require this change.
Related details
- Fritz Koenig
- Robert Mader
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Fritz Koenig (Gerrit)
Fritz Koenig voted Code-Review+1![]( "Open in Gerrit")
- Robert Mader
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Robert Mader (Gerrit)
Robert Mader added 1 comment![]( "Open in Gerrit")
Thanks! I don't have the permissions to merge, mind one you trigger the CQ+2?
Related details
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nathan Hebert (Gerrit)
Nathan Hebert voted Commit-Queue+2![]( "Open in Gerrit")
- Robert Mader
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nathan Hebert (Gerrit)
Nathan Hebert added 1 comment![]( "Open in Gerrit")
Thanks! I don't have the permissions to merge, mind one you trigger the CQ+2?
Sorry! Yes. Done.
Related details
- Robert Mader
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
media/gpu/v4l2: Allow enabling AV1 support on Linux
The required values in v4l2-controls.h have been upstreamed
for a while, however the baseline Debian dependency has not
been updated to a version including that yet.
Add a simple way to already enable AV1 support by reusing the
`use_av1_hw_decoder` flag, keeping it enabled by default for
VA-API but disabling it for V4L2.
- M media/gpu/BUILD.gn
- M media/gpu/args.gni
- M media/gpu/chromeos/image_processor_test.cc
- M media/gpu/v4l2/BUILD.gn
- M media/gpu/v4l2/test/av1_decoder.cc
- M media/gpu/v4l2/v4l2_utils.cc
- M media/gpu/v4l2/v4l2_video_decoder_backend_stateless.cc
- M media/gpu/v4l2/v4l2_video_decoder_delegate_av1.cc
Code-Review: +1 by Nathan Hebert, +1 by Fritz Koenig
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Robert Mader (Gerrit)
Robert Mader added 1 comment![]( "Open in Gerrit")
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jianfeng Liu (Gerrit)
Jianfeng Liu added 1 comment![]( "Open in Gerrit")
Hello, Debian trixie has been released now and it has linux-libc-dev from kernel v6.12. Is it possible to enable av1 decoder on linux by default for both vaapi and v4l2 now?
Related details
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Fritz Koenig (Gerrit)
Fritz Koenig added 1 comment![]( "Open in Gerrit")
Hello, Debian trixie has been released now and it has linux-libc-dev from kernel v6.12. Is it possible to enable av1 decoder on linux by default for both vaapi and v4l2 now?
Trixie was only released in August 2025. I'm not sure what the uptake is. By going to default those that haven't upgraded yet will fail to compile. I don't know what number of people are building Chromium from source, for v4l2, have av1 hw support, and aren't on trixie. Seems pretty niche.
I'm open to enabling it by default, but would like to have some feedback from Robert as the CL was crafted to avoid doing so.
Related details
- Robert Mader
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Robert Mader (Gerrit)
Robert Mader added 1 comment![]( "Open in Gerrit")
Fritz KoenigHello, Debian trixie has been released now and it has linux-libc-dev from kernel v6.12. Is it possible to enable av1 decoder on linux by default for both vaapi and v4l2 now?
Trixie was only released in August 2025. I'm not sure what the uptake is. By going to default those that haven't upgraded yet will fail to compile. I don't know what number of people are building Chromium from source, for v4l2, have av1 hw support, and aren't on trixie. Seems pretty niche.
I'm open to enabling it by default, but would like to have some feedback from Robert as the CL was crafted to avoid doing so.
I'd love to see it enabled by default, however AFAICS older Debian versions are still used for CI and local builds - and I don't expect that to change any time soon.
If we want to enable `use_av1_hw_decoder` by default on systems like Trixie that have the headers, I suppose we could do so with some kind of `has_header()` check.
Related details
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Fritz Koenig (Gerrit)
Fritz Koenig added 1 comment![]( "Open in Gerrit")
Fritz KoenigHello, Debian trixie has been released now and it has linux-libc-dev from kernel v6.12. Is it possible to enable av1 decoder on linux by default for both vaapi and v4l2 now?
Robert MaderTrixie was only released in August 2025. I'm not sure what the uptake is. By going to default those that haven't upgraded yet will fail to compile. I don't know what number of people are building Chromium from source, for v4l2, have av1 hw support, and aren't on trixie. Seems pretty niche.
I'm open to enabling it by default, but would like to have some feedback from Robert as the CL was crafted to avoid doing so.
I'd love to see it enabled by default, however AFAICS older Debian versions are still used for CI and local builds - and I don't expect that to change any time soon.
If we want to enable `use_av1_hw_decoder` by default on systems like Trixie that have the headers, I suppose we could do so with some kind of `has_header()` check.
Thanks for pointing out that builders are still using older Debian, I had not considered that. I will keep it in mind for the future. Eventually they will get updated, but Debian still has years of support for bookworm.
Related details
- Robert Mader
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jianfeng Liu (Gerrit)
Jianfeng Liu added 1 comment![]( "Open in Gerrit")
Fritz KoenigHello, Debian trixie has been released now and it has linux-libc-dev from kernel v6.12. Is it possible to enable av1 decoder on linux by default for both vaapi and v4l2 now?
Robert MaderTrixie was only released in August 2025. I'm not sure what the uptake is. By going to default those that haven't upgraded yet will fail to compile. I don't know what number of people are building Chromium from source, for v4l2, have av1 hw support, and aren't on trixie. Seems pretty niche.
I'm open to enabling it by default, but would like to have some feedback from Robert as the CL was crafted to avoid doing so.
Fritz KoenigI'd love to see it enabled by default, however AFAICS older Debian versions are still used for CI and local builds - and I don't expect that to change any time soon.
If we want to enable `use_av1_hw_decoder` by default on systems like Trixie that have the headers, I suppose we could do so with some kind of `has_header()` check.
Thanks for pointing out that builders are still using older Debian, I had not considered that. I will keep it in mind for the future. Eventually they will get updated, but Debian still has years of support for bookworm.
Get it. I have manually enabled av1 decoder at debian: https://salsa.debian.org/chromium-team/chromium/-/merge_requests/29
Related details
- Robert Mader
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |