Fixes to layout of Toolbar Height Sidepanel in Vertical Tabs [chromium/src : main]

0 views
Skip to first unread message

Eshwar Stalin (Gerrit)

unread,
Dec 14, 2025, 3:53:55 AM (2 days ago) Dec 14
to Dana Fried, Vince Lugli, Peter Meyer, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Dana Fried and Vince Lugli

Eshwar Stalin voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Dana Fried
  • Vince Lugli
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I6937681ff438b985116c7b3823867dbdd22f6da6
Gerrit-Change-Number: 7253417
Gerrit-PatchSet: 3
Gerrit-Owner: Eshwar Stalin <est...@chromium.org>
Gerrit-Reviewer: Dana Fried <dfr...@chromium.org>
Gerrit-Reviewer: Eshwar Stalin <est...@chromium.org>
Gerrit-Reviewer: Vince Lugli <lu...@chromium.org>
Gerrit-CC: Peter Meyer <wwwad...@gmail.com>
Gerrit-Attention: Vince Lugli <lu...@chromium.org>
Gerrit-Attention: Dana Fried <dfr...@chromium.org>
Gerrit-Comment-Date: Sun, 14 Dec 2025 08:53:17 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Dana Fried (Gerrit)

unread,
Dec 15, 2025, 10:41:58 AM (23 hours ago) Dec 15
to Eshwar Stalin, Vince Lugli, Peter Meyer, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Eshwar Stalin and Vince Lugli

Dana Fried added 2 comments

File chrome/browser/ui/views/frame/layout/browser_view_tabbed_layout_impl.cc
Line 374, Patchset 5 (Latest): params.visual_client_area.y() +
Dana Fried . unresolved

This change (along with the change below) should be made in a different CL.

Line 410, Patchset 5 (Latest): tab_strip_type == TabStripType::kVertical ? 0
Dana Fried . unresolved

See above.

Open in Gerrit

Related details

Attention is currently required from:
  • Eshwar Stalin
  • Vince Lugli
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I6937681ff438b985116c7b3823867dbdd22f6da6
    Gerrit-Change-Number: 7253417
    Gerrit-PatchSet: 5
    Gerrit-Owner: Eshwar Stalin <est...@chromium.org>
    Gerrit-Reviewer: Dana Fried <dfr...@chromium.org>
    Gerrit-Reviewer: Eshwar Stalin <est...@chromium.org>
    Gerrit-Reviewer: Vince Lugli <lu...@chromium.org>
    Gerrit-CC: Peter Meyer <wwwad...@gmail.com>
    Gerrit-Attention: Vince Lugli <lu...@chromium.org>
    Gerrit-Attention: Eshwar Stalin <est...@chromium.org>
    Gerrit-Comment-Date: Mon, 15 Dec 2025 15:41:52 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Eshwar Stalin (Gerrit)

    unread,
    Dec 15, 2025, 11:31:07 AM (22 hours ago) Dec 15
    to Dana Fried, Vince Lugli, Peter Meyer, Chromium LUCI CQ, chromium...@chromium.org
    Attention needed from Dana Fried and Vince Lugli

    Eshwar Stalin added 2 comments

    File chrome/browser/ui/views/frame/layout/browser_view_tabbed_layout_impl.cc
    Line 374, Patchset 5: params.visual_client_area.y() +
    Dana Fried . resolved

    This change (along with the change below) should be made in a different CL.

    Eshwar Stalin

    Moved changes to main region background view to a separate CL.

    Line 410, Patchset 5: tab_strip_type == TabStripType::kVertical ? 0
    Dana Fried . resolved

    See above.

    Eshwar Stalin

    Done

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Dana Fried
    • Vince Lugli
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I6937681ff438b985116c7b3823867dbdd22f6da6
      Gerrit-Change-Number: 7253417
      Gerrit-PatchSet: 8
      Gerrit-Owner: Eshwar Stalin <est...@chromium.org>
      Gerrit-Reviewer: Dana Fried <dfr...@chromium.org>
      Gerrit-Reviewer: Eshwar Stalin <est...@chromium.org>
      Gerrit-Reviewer: Vince Lugli <lu...@chromium.org>
      Gerrit-CC: Peter Meyer <wwwad...@gmail.com>
      Gerrit-Attention: Vince Lugli <lu...@chromium.org>
      Gerrit-Attention: Dana Fried <dfr...@chromium.org>
      Gerrit-Comment-Date: Mon, 15 Dec 2025 16:30:39 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Dana Fried <dfr...@chromium.org>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Dana Fried (Gerrit)

      unread,
      Dec 15, 2025, 2:04:52 PM (19 hours ago) Dec 15
      to Eshwar Stalin, Vince Lugli, Peter Meyer, Chromium LUCI CQ, chromium...@chromium.org
      Attention needed from Eshwar Stalin and Vince Lugli

      Dana Fried voted Code-Review+1

      Code-Review+1
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Eshwar Stalin
      • Vince Lugli
      Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: I6937681ff438b985116c7b3823867dbdd22f6da6
        Gerrit-Change-Number: 7253417
        Gerrit-PatchSet: 9
        Gerrit-Owner: Eshwar Stalin <est...@chromium.org>
        Gerrit-Reviewer: Dana Fried <dfr...@chromium.org>
        Gerrit-Reviewer: Eshwar Stalin <est...@chromium.org>
        Gerrit-Reviewer: Vince Lugli <lu...@chromium.org>
        Gerrit-CC: Peter Meyer <wwwad...@gmail.com>
        Gerrit-Attention: Vince Lugli <lu...@chromium.org>
        Gerrit-Attention: Eshwar Stalin <est...@chromium.org>
        Gerrit-Comment-Date: Mon, 15 Dec 2025 19:04:44 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        open
        diffy

        Eshwar Stalin (Gerrit)

        unread,
        Dec 15, 2025, 2:06:19 PM (19 hours ago) Dec 15
        to Dana Fried, Vince Lugli, Peter Meyer, Chromium LUCI CQ, chromium...@chromium.org
        Attention needed from Vince Lugli

        Eshwar Stalin voted Commit-Queue+2

        Commit-Queue+2
        Open in Gerrit

        Related details

        Attention is currently required from:
        • Vince Lugli
        Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: I6937681ff438b985116c7b3823867dbdd22f6da6
        Gerrit-Change-Number: 7253417
        Gerrit-PatchSet: 9
        Gerrit-Owner: Eshwar Stalin <est...@chromium.org>
        Gerrit-Reviewer: Dana Fried <dfr...@chromium.org>
        Gerrit-Reviewer: Eshwar Stalin <est...@chromium.org>
        Gerrit-Reviewer: Vince Lugli <lu...@chromium.org>
        Gerrit-CC: Peter Meyer <wwwad...@gmail.com>
        Gerrit-Attention: Vince Lugli <lu...@chromium.org>
        Gerrit-Comment-Date: Mon, 15 Dec 2025 19:05:43 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        open
        diffy

        Chromium LUCI CQ (Gerrit)

        unread,
        Dec 15, 2025, 2:49:52 PM (19 hours ago) Dec 15
        to Eshwar Stalin, Dana Fried, Vince Lugli, Peter Meyer, chromium...@chromium.org

        Chromium LUCI CQ submitted the change

        Change information

        Commit message:
        Fixes to layout of Toolbar Height Sidepanel in Vertical Tabs

        Refined the THSP in Vertical Tabs by removed the top padding.
        Fixed: 469081380
        Change-Id: I6937681ff438b985116c7b3823867dbdd22f6da6
        Reviewed-by: Dana Fried <dfr...@chromium.org>
        Commit-Queue: Eshwar Stalin <est...@chromium.org>
        Cr-Commit-Position: refs/heads/main@{#1558897}
        Files:
        • M chrome/browser/ui/views/frame/layout/browser_view_tabbed_layout_impl.cc
        Change size: S
        Delta: 1 file changed, 10 insertions(+), 7 deletions(-)
        Branch: refs/heads/main
        Submit Requirements:
        • requirement satisfiedCode-Review: +1 by Dana Fried
        Open in Gerrit
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: merged
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: I6937681ff438b985116c7b3823867dbdd22f6da6
        Gerrit-Change-Number: 7253417
        Gerrit-PatchSet: 10
        Gerrit-Owner: Eshwar Stalin <est...@chromium.org>
        Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
        Gerrit-Reviewer: Dana Fried <dfr...@chromium.org>
        Gerrit-Reviewer: Eshwar Stalin <est...@chromium.org>
        Gerrit-Reviewer: Vince Lugli <lu...@chromium.org>
        open
        diffy
        satisfied_requirement
        Reply all
        Reply to author
        Forward
        0 new messages