[fuchsia] two tests are flaky on sherlock-qemu [chromium/src : main]

0 views
Skip to first unread message

Zijie He (Gerrit)

unread,
6:10 PM (6 hours ago) 6:10 PM
to Guocheng Wei, Bailey Myers-Morgan, chromium...@chromium.org
Attention needed from Guocheng Wei

Zijie He added 1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Zijie He . resolved

Please take a look, thank you.

Open in Gerrit

Related details

Attention is currently required from:
  • Guocheng Wei
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I9fdfa128780b3129dd6785c80b5b48a6c233f23b
Gerrit-Change-Number: 5673372
Gerrit-PatchSet: 2
Gerrit-Owner: Zijie He <zij...@google.com>
Gerrit-Reviewer: Guocheng Wei <guoch...@chromium.org>
Gerrit-CC: Bailey Myers-Morgan <bmyers...@google.com>
Gerrit-Attention: Guocheng Wei <guoch...@chromium.org>
Gerrit-Comment-Date: Tue, 02 Jul 2024 22:10:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Zijie He (Gerrit)

unread,
6:18 PM (5 hours ago) 6:18 PM
to Guocheng Wei, Bailey Myers-Morgan, chromium...@chromium.org
Attention needed from Guocheng Wei

Zijie He voted Auto-Submit+1

Auto-Submit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Guocheng Wei
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I9fdfa128780b3129dd6785c80b5b48a6c233f23b
Gerrit-Change-Number: 5673372
Gerrit-PatchSet: 2
Gerrit-Owner: Zijie He <zij...@google.com>
Gerrit-Reviewer: Guocheng Wei <guoch...@chromium.org>
Gerrit-Reviewer: Zijie He <zij...@google.com>
Gerrit-CC: Bailey Myers-Morgan <bmyers...@google.com>
Gerrit-Attention: Guocheng Wei <guoch...@chromium.org>
Gerrit-Comment-Date: Tue, 02 Jul 2024 22:18:11 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Zijie He (Gerrit)

unread,
6:19 PM (5 hours ago) 6:19 PM
to Brian Sheedy, Guocheng Wei, Bailey Myers-Morgan, chromium...@chromium.org
Attention needed from Brian Sheedy and Guocheng Wei

Zijie He voted Auto-Submit+1

Auto-Submit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Brian Sheedy
  • Guocheng Wei
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I9fdfa128780b3129dd6785c80b5b48a6c233f23b
Gerrit-Change-Number: 5673372
Gerrit-PatchSet: 3
Gerrit-Owner: Zijie He <zij...@google.com>
Gerrit-Reviewer: Brian Sheedy <bsh...@chromium.org>
Gerrit-Reviewer: Guocheng Wei <guoch...@chromium.org>
Gerrit-Reviewer: Zijie He <zij...@google.com>
Gerrit-CC: Bailey Myers-Morgan <bmyers...@google.com>
Gerrit-Attention: Brian Sheedy <bsh...@chromium.org>
Gerrit-Attention: Guocheng Wei <guoch...@chromium.org>
Gerrit-Comment-Date: Tue, 02 Jul 2024 22:19:29 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Brian Sheedy (Gerrit)

unread,
6:24 PM (5 hours ago) 6:24 PM
to Zijie He, Guocheng Wei, Bailey Myers-Morgan, chromium...@chromium.org
Attention needed from Guocheng Wei and Zijie He

Brian Sheedy voted and added 1 comment

Votes added by Brian Sheedy

Code-Review+1
Commit-Queue+2

1 comment

File content/test/gpu/gpu_tests/trace_integration_test.py
Line 474, Patchset 3 (Latest): timeout=60)
Brian Sheedy . resolved

This may be indicative that we need to move the trace tests to use a heartbeat mechanism, but for now, a 60 second timeout seems okay. I would be hesitant to increase it beyond that, though.

Open in Gerrit

Related details

Attention is currently required from:
  • Guocheng Wei
  • Zijie He
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I9fdfa128780b3129dd6785c80b5b48a6c233f23b
Gerrit-Change-Number: 5673372
Gerrit-PatchSet: 3
Gerrit-Owner: Zijie He <zij...@google.com>
Gerrit-Reviewer: Brian Sheedy <bsh...@chromium.org>
Gerrit-Reviewer: Guocheng Wei <guoch...@chromium.org>
Gerrit-Reviewer: Zijie He <zij...@google.com>
Gerrit-CC: Bailey Myers-Morgan <bmyers...@google.com>
Gerrit-Attention: Zijie He <zij...@google.com>
Gerrit-Attention: Guocheng Wei <guoch...@chromium.org>
Gerrit-Comment-Date: Tue, 02 Jul 2024 22:23:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
8:30 PM (3 hours ago) 8:30 PM
to Zijie He, Brian Sheedy, Guocheng Wei, Bailey Myers-Morgan, chromium...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
[fuchsia] two tests are flaky on sherlock-qemu

TraceTest_Canvas2DBlitText is slow and may need over 30 seconds.
tex-video-using-tex-unit-non-zero is flaky.
Cq-Include-Trybots: luci.chrome.try:fuchsia-fyi-sherlock-qemu
Change-Id: I9fdfa128780b3129dd6785c80b5b48a6c233f23b
Commit-Queue: Brian Sheedy <bsh...@chromium.org>
Auto-Submit: Zijie He <zij...@google.com>
Reviewed-by: Brian Sheedy <bsh...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1322495}
Files:
  • M content/test/gpu/gpu_tests/test_expectations/webgl_conformance_expectations.txt
  • M content/test/gpu/gpu_tests/trace_integration_test.py
Change size: XS
Delta: 2 files changed, 2 insertions(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Brian Sheedy
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I9fdfa128780b3129dd6785c80b5b48a6c233f23b
Gerrit-Change-Number: 5673372
Gerrit-PatchSet: 4
Gerrit-Owner: Zijie He <zij...@google.com>
Gerrit-Reviewer: Brian Sheedy <bsh...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
open
diffy
satisfied_requirement

Zijie He (Gerrit)

unread,
8:56 PM (3 hours ago) 8:56 PM
to Chromium LUCI CQ, Brian Sheedy, Guocheng Wei, Bailey Myers-Morgan, chromium...@chromium.org

Zijie He added 1 comment

File content/test/gpu/gpu_tests/trace_integration_test.py
Brian Sheedy . resolved

This may be indicative that we need to move the trace tests to use a heartbeat mechanism, but for now, a 60 second timeout seems okay. I would be hesitant to increase it beyond that, though.

Zijie He

Oh, you are fast. 30-second is at the boundary and likely it's the reason it's flaky rather than failing consistently.

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I9fdfa128780b3129dd6785c80b5b48a6c233f23b
Gerrit-Change-Number: 5673372
Gerrit-PatchSet: 4
Gerrit-Owner: Zijie He <zij...@google.com>
Gerrit-Reviewer: Brian Sheedy <bsh...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Guocheng Wei <guoch...@chromium.org>
Gerrit-Reviewer: Zijie He <zij...@google.com>
Gerrit-CC: Bailey Myers-Morgan <bmyers...@google.com>
Gerrit-Comment-Date: Wed, 03 Jul 2024 00:55:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Brian Sheedy <bsh...@chromium.org>
satisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages