[bedrock] Eliminate BrowserList::get() from KioskBrowserLogsCollector [chromium/src : main]
0 views
Skip to first unread message
Tom Lukaszewicz (Gerrit)
Sep 4, 2025, 9:08:33 PM (3 days ago) Sep 4
to Hidehiko Abe, chromium...@chromium.org, chromeos-kio...@google.com, oshima...@chromium.org
Attention needed from Hidehiko Abe
Tom Lukaszewicz voted and added 1 comment![]( "Open in Gerrit")
Votes added by Tom Lukaszewicz
| Commit-Queue | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Hidehiko Abe
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hidehiko Abe (Gerrit)
Sep 4, 2025, 9:41:50 PM (3 days ago) Sep 4
to Tom Lukaszewicz, Chromium LUCI CQ, chromium...@chromium.org, chromeos-kio...@google.com, oshima...@chromium.org
Attention needed from Tom Lukaszewicz
Hidehiko Abe voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Tom Lukaszewicz
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tom Lukaszewicz (Gerrit)
Sep 4, 2025, 10:19:53 PM (3 days ago) Sep 4
to Hidehiko Abe, Chromium LUCI CQ, chromium...@chromium.org, chromeos-kio...@google.com, oshima...@chromium.org
Tom Lukaszewicz voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Sep 4, 2025, 10:26:35 PM (3 days ago) Sep 4
to Tom Lukaszewicz, Hidehiko Abe, chromium...@chromium.org, chromeos-kio...@google.com, oshima...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[bedrock] Eliminate BrowserList::get() from KioskBrowserLogsCollector
Updates KioskBrowserLogsCollector to use safe BrowserWindowInterface
iteration ForEachCurrentBrowserWindowInterfaceOrderedByActivation(),
migrating away from the deprecated BrowserList::get() API.
Bug: 431672609
Change-Id: Ia67c8bd083542a20e68c9a3596925120affd3fbe
Commit-Queue: Tom Lukaszewicz <tl...@chromium.org>
Reviewed-by: Hidehiko Abe <hide...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1511281}
Files:
- M chrome/browser/chromeos/app_mode/kiosk_browser_logs_collector.cc
- M chrome/browser/chromeos/app_mode/kiosk_browser_logs_collector.h
Change size: S
Delta: 2 files changed, 16 insertions(+), 9 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Hidehiko Abe
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages