Piotr Wrótniak (Gerrit)

unread,

Jun 12, 2025, 9:16:21 AM6/12/25

to Norge Vizcay, Chromium LUCI CQ, chromium...@chromium.org, browser-comp...@chromium.org, rouslan+au...@chromium.org

Attention needed from Norge Vizcay

Piotr Wrótniak voted

Auto-Submit	+1
Commit-Queue	+1

Open in Gerrit

Related details

Attention is currently required from:

Norge Vizcay

Submit Requirements:

Code-Coverage
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Norge Vizcay (Gerrit)

unread,

Jun 13, 2025, 3:54:56 AM6/13/25

to Piotr Wrótniak, Chromium LUCI CQ, chromium...@chromium.org, browser-comp...@chromium.org, rouslan+au...@chromium.org

Attention needed from Piotr Wrótniak

Norge Vizcay voted and added 2 comments

Votes added by Norge Vizcay

Code-Review	+1
Commit-Queue	+2

2 comments

Patchset-level comments

File-level comment, Patchset 6 (Latest):

Norge Vizcay . resolved

Great. Thanks!

File components/autofill/core/browser/autofill_field.cc

Line 549, Patchset 2:

    believe_server =
        believe_server && (heuristic_type_local != LOYALTY_MEMBERSHIP_ID);

Norge Vizcay . resolved

Will this override all server predictions? Or just those where the server type is unknown? I am not entirely sure we want to override **all** server predictions.

Piotr Wrótniak

I'd guess that we're confident with regexps like `Loyalty card` enough (and so similarly 5 fields above override all server predictions) but sure - changed.

Norge Vizcay

I am, but this would interfere with email server predictions on "email or loyalty card", which we want to avoid. I expect that most loyalty card-only fields have an UNKNOWN server prediction.

Open in Gerrit

Related details

Attention is currently required from:

Piotr Wrótniak

Submit Requirements:

Code-Coverage
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Jun 13, 2025, 4:01:05 AM6/13/25

to Piotr Wrótniak, Norge Vizcay, chromium...@chromium.org, browser-comp...@chromium.org, rouslan+au...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:

Favor heuristics over UNKNOWN_TYPE server prediction for loyalty cards.

Screenshots with fix:
- https://screenshot.googleplex.com/4FNr3fC3hFHstKB
- https://screenshot.googleplex.com/873482m7VjsqeRA

Bug: 424378427

Change-Id: I81684b31656a424b48e355f0ae647ea5f365c6e6

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6641216

Reviewed-by: Norge Vizcay <viz...@google.com>

Auto-Submit: Piotr Wrótniak <piotrw...@google.com>

Commit-Queue: Norge Vizcay <viz...@google.com>

Cr-Commit-Position: refs/heads/main@{#1473410}

Files:

M components/autofill/core/browser/autofill_field.cc
M components/autofill/core/browser/autofill_field_unittest.cc

Change size: S

Delta: 2 files changed, 24 insertions(+), 0 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Norge Vizcay

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

Favor heuristics over UNKNOWN_TYPE server prediction for loyalty cards. [chromium/src : main]

Piotr Wrótniak (Gerrit)

Piotr Wrótniak voted

Related details

Norge Vizcay (Gerrit)

Norge Vizcay voted and added 2 comments

Votes added by Norge Vizcay

2 comments

Related details

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change

Change information