[spc][config] Add Field Trial Testing Config for SPC UX Refresh [chromium/src : main]

0 views
Skip to first unread message

Darwin Yang (Gerrit)

unread,
Jan 9, 2026, 11:06:23 AM (yesterday) Jan 9
to Slobodan Pejic, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org
Attention needed from Slobodan Pejic

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:
  • Slobodan Pejic
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I26b31ac1b515b5cb322b5e8d39826cc4096d669d
Gerrit-Change-Number: 7423578
Gerrit-PatchSet: 1
Gerrit-Owner: Darwin Yang <darwi...@chromium.org>
Gerrit-Reviewer: Darwin Yang <darwi...@chromium.org>
Gerrit-Reviewer: Slobodan Pejic <slob...@chromium.org>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-Attention: Slobodan Pejic <slob...@chromium.org>
Gerrit-Comment-Date: Fri, 09 Jan 2026 16:06:07 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Darwin Yang (Gerrit)

unread,
Jan 9, 2026, 11:23:25 AM (yesterday) Jan 9
to Slobodan Pejic, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org
Attention needed from Darwin Yang and Slobodan Pejic

Darwin Yang voted and added 1 comment

Votes added by Darwin Yang

Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Darwin Yang . unresolved

Note that some WPT tests are now passing due to the new changes so I'm currently updating the test expectations.

Open in Gerrit

Related details

Attention is currently required from:
  • Darwin Yang
  • Slobodan Pejic
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I26b31ac1b515b5cb322b5e8d39826cc4096d669d
    Gerrit-Change-Number: 7423578
    Gerrit-PatchSet: 1
    Gerrit-Owner: Darwin Yang <darwi...@chromium.org>
    Gerrit-Reviewer: Darwin Yang <darwi...@chromium.org>
    Gerrit-Reviewer: Slobodan Pejic <slob...@chromium.org>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-Attention: Darwin Yang <darwi...@chromium.org>
    Gerrit-Attention: Slobodan Pejic <slob...@chromium.org>
    Gerrit-Comment-Date: Fri, 09 Jan 2026 16:23:12 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Slobodan Pejic (Gerrit)

    unread,
    Jan 9, 2026, 2:09:27 PM (yesterday) Jan 9
    to Darwin Yang, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org
    Attention needed from Darwin Yang

    Slobodan Pejic voted and added 1 comment

    Votes added by Slobodan Pejic

    Code-Review+1

    1 comment

    Patchset-level comments
    Darwin Yang . unresolved

    Note that some WPT tests are now passing due to the new changes so I'm currently updating the test expectations.

    Slobodan Pejic

    LGTM % tests passing.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Darwin Yang
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement is not satisfiedNo-Unresolved-Comments
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I26b31ac1b515b5cb322b5e8d39826cc4096d669d
      Gerrit-Change-Number: 7423578
      Gerrit-PatchSet: 1
      Gerrit-Owner: Darwin Yang <darwi...@chromium.org>
      Gerrit-Reviewer: Darwin Yang <darwi...@chromium.org>
      Gerrit-Reviewer: Slobodan Pejic <slob...@chromium.org>
      Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
      Gerrit-Attention: Darwin Yang <darwi...@chromium.org>
      Gerrit-Comment-Date: Fri, 09 Jan 2026 19:09:20 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      Comment-In-Reply-To: Darwin Yang <darwi...@chromium.org>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Darwin Yang (Gerrit)

      unread,
      Jan 9, 2026, 10:39:32 PM (18 hours ago) Jan 9
      to AyeAye, Slobodan Pejic, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, sloboda...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, asvitkine...@chromium.org
      Attention needed from Slobodan Pejic

      Darwin Yang added 2 comments

      Patchset-level comments
      File-level comment, Patchset 1:
      Darwin Yang . resolved

      Note that some WPT tests are now passing due to the new changes so I'm currently updating the test expectations.

      Slobodan Pejic

      LGTM % tests passing.

      Darwin Yang

      Done

      File chrome/browser/ui/views/payments/secure_payment_confirmation_dialog_view_browsertest.cc
      Line 698, Patchset 5 (Latest):IN_PROC_BROWSER_TEST_F(SecurePaymentConfirmationDialogViewUxRefreshTest,
      Darwin Yang . resolved

      Note that only a basic model/view expectation test is done here to make sure secondary values are added to the view. Additional tests will be added in a follow-up.

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Slobodan Pejic
      Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement satisfiedCode-Owners
        • requirement is not satisfiedCode-Review
        • requirement is not satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: I26b31ac1b515b5cb322b5e8d39826cc4096d669d
        Gerrit-Change-Number: 7423578
        Gerrit-PatchSet: 5
        Gerrit-Owner: Darwin Yang <darwi...@chromium.org>
        Gerrit-Reviewer: Darwin Yang <darwi...@chromium.org>
        Gerrit-Reviewer: Slobodan Pejic <slob...@chromium.org>
        Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
        Gerrit-Attention: Slobodan Pejic <slob...@chromium.org>
        Gerrit-Comment-Date: Sat, 10 Jan 2026 03:39:22 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: No
        Comment-In-Reply-To: Darwin Yang <darwi...@chromium.org>
        Comment-In-Reply-To: Slobodan Pejic <slob...@chromium.org>
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy
        Reply all
        Reply to author
        Forward
        0 new messages