Alex Kallam (Gerrit)

unread,

Jan 9, 2026, 11:53:59 AM (2 days ago) Jan 9

to chrome-third-pa...@google.com, Chromium LUCI CQ, chromium...@chromium.org, chrome-rust-exper...@google.com

Attention needed from chrome-third-pa...@google.com

Alex Kallam added 1 comment

Patchset-level comments

File-level comment, Patchset 3 (Latest):

Alex Kallam . resolved

PTAL, thanks!

Open in Gerrit

Related details

Attention is currently required from:

chrome-third-pa...@google.com

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

gwsq (Gerrit)

unread,

Jan 9, 2026, 11:56:44 AM (2 days ago) Jan 9

to Alex Kallam, chrome-third-pa...@google.com, Daniel Rubery, Chromium LUCI CQ, chromium...@chromium.org, chrome-rust-exper...@google.com

Attention needed from Daniel Rubery

Message from gwsq

From googleclient/chrome/chromium_gwsq/third_party/rust/config.gwsq:
third-party-rust: dru...@chromium.org

It looks like you’re modifying `//third_party/rust`. An appropriate reviewer has been automatically added to this CL.

`//third_party/rust` reviewer(s): dru...@chromium.org

Reviewer source(s):
dru...@chromium.org is from context(googleclient/chrome/chromium_gwsq/third_party/rust/config.gwsq)

Open in Gerrit

Related details

Attention is currently required from:

Daniel Rubery

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Daniel Rubery (Gerrit)

unread,

Jan 9, 2026, 1:37:03 PM (2 days ago) Jan 9

to Alex Kallam, chrome-third-pa...@google.com, Chromium LUCI CQ, chromium...@chromium.org, chrome-rust-exper...@google.com

Attention needed from Alex Kallam

Daniel Rubery voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Alex Kallam

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Jan 10, 2026, 11:28:02 PM (18 hours ago) Jan 10

to Alex Kallam, Daniel Cheng, Daniel Rubery, chrome-third-pa...@google.com, chromium...@chromium.org, chrome-rust-exper...@google.com

Chromium LUCI CQ submitted the change

Change information

Commit message:

Roll syn: 2.0.111 => 2.0.114 in //third_party/rust.

This CL has been created semi-automatically.  The expected review
process and other details can be found at
//tools/crates/create_update_cl.md

Updated crates:

* syn: 2.0.111 => 2.0.114; https://docs.rs/crate/syn/2.0.114

Bug: None

Cq-Include-Trybots: chromium/try:android-rust-arm32-rel

Cq-Include-Trybots: chromium/try:android-rust-arm64-dbg

Cq-Include-Trybots: chromium/try:android-rust-arm64-rel

Cq-Include-Trybots: chromium/try:linux-rust-x64-dbg

Cq-Include-Trybots: chromium/try:linux-rust-x64-rel

Cq-Include-Trybots: chromium/try:win-rust-x64-dbg

Cq-Include-Trybots: chromium/try:win-rust-x64-rel

Disable-Rts: True

Change-Id: Idb0293b7e7d215e0e66e63160871860ce0a8640c

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7417142

Reviewed-by: Daniel Rubery <dru...@chromium.org>

Commit-Queue: Daniel Cheng <dch...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1567482}

Files:

M third_party/rust/chromium_crates_io/Cargo.lock
M third_party/rust/chromium_crates_io/vendor/syn-v2/.cargo_vcs_info.json
M third_party/rust/chromium_crates_io/vendor/syn-v2/Cargo.lock
M third_party/rust/chromium_crates_io/vendor/syn-v2/Cargo.toml
M third_party/rust/chromium_crates_io/vendor/syn-v2/Cargo.toml.orig
M third_party/rust/chromium_crates_io/vendor/syn-v2/src/attr.rs
M third_party/rust/chromium_crates_io/vendor/syn-v2/src/bigint.rs
M third_party/rust/chromium_crates_io/vendor/syn-v2/src/buffer.rs
M third_party/rust/chromium_crates_io/vendor/syn-v2/src/classify.rs
M third_party/rust/chromium_crates_io/vendor/syn-v2/src/custom_punctuation.rs
M third_party/rust/chromium_crates_io/vendor/syn-v2/src/data.rs
M third_party/rust/chromium_crates_io/vendor/syn-v2/src/derive.rs
M third_party/rust/chromium_crates_io/vendor/syn-v2/src/discouraged.rs
M third_party/rust/chromium_crates_io/vendor/syn-v2/src/drops.rs
M third_party/rust/chromium_crates_io/vendor/syn-v2/src/error.rs
M third_party/rust/chromium_crates_io/vendor/syn-v2/src/export.rs
M third_party/rust/chromium_crates_io/vendor/syn-v2/src/expr.rs
M third_party/rust/chromium_crates_io/vendor/syn-v2/src/ext.rs
M third_party/rust/chromium_crates_io/vendor/syn-v2/src/file.rs
M third_party/rust/chromium_crates_io/vendor/syn-v2/src/gen/debug.rs
M third_party/rust/chromium_crates_io/vendor/syn-v2/src/gen/eq.rs
M third_party/rust/chromium_crates_io/vendor/syn-v2/src/gen/fold.rs
M third_party/rust/chromium_crates_io/vendor/syn-v2/src/gen/hash.rs
M third_party/rust/chromium_crates_io/vendor/syn-v2/src/gen/visit_mut.rs
M third_party/rust/chromium_crates_io/vendor/syn-v2/src/generics.rs
M third_party/rust/chromium_crates_io/vendor/syn-v2/src/ident.rs
M third_party/rust/chromium_crates_io/vendor/syn-v2/src/item.rs
M third_party/rust/chromium_crates_io/vendor/syn-v2/src/lib.rs
M third_party/rust/chromium_crates_io/vendor/syn-v2/src/lifetime.rs
M third_party/rust/chromium_crates_io/vendor/syn-v2/src/lit.rs
M third_party/rust/chromium_crates_io/vendor/syn-v2/src/lookahead.rs
M third_party/rust/chromium_crates_io/vendor/syn-v2/src/macros.rs
M third_party/rust/chromium_crates_io/vendor/syn-v2/src/meta.rs
M third_party/rust/chromium_crates_io/vendor/syn-v2/src/parse.rs
M third_party/rust/chromium_crates_io/vendor/syn-v2/src/parse_quote.rs
M third_party/rust/chromium_crates_io/vendor/syn-v2/src/pat.rs
M third_party/rust/chromium_crates_io/vendor/syn-v2/src/path.rs
M third_party/rust/chromium_crates_io/vendor/syn-v2/src/precedence.rs
M third_party/rust/chromium_crates_io/vendor/syn-v2/src/punctuated.rs
M third_party/rust/chromium_crates_io/vendor/syn-v2/src/restriction.rs
M third_party/rust/chromium_crates_io/vendor/syn-v2/src/spanned.rs
M third_party/rust/chromium_crates_io/vendor/syn-v2/src/stmt.rs
M third_party/rust/chromium_crates_io/vendor/syn-v2/src/thread.rs
M third_party/rust/chromium_crates_io/vendor/syn-v2/src/token.rs
M third_party/rust/chromium_crates_io/vendor/syn-v2/src/tt.rs
M third_party/rust/chromium_crates_io/vendor/syn-v2/src/ty.rs
M third_party/rust/chromium_crates_io/vendor/syn-v2/src/verbatim.rs
M third_party/rust/chromium_crates_io/vendor/syn-v2/tests/common/eq.rs
M third_party/rust/chromium_crates_io/vendor/syn-v2/tests/debug/gen.rs
M third_party/rust/chromium_crates_io/vendor/syn-v2/tests/test_generics.rs
M third_party/rust/chromium_crates_io/vendor/syn-v2/tests/test_parse_buffer.rs
M third_party/rust/chromium_crates_io/vendor/syn-v2/tests/test_precedence.rs
M third_party/rust/syn/v2/BUILD.gn
M third_party/rust/syn/v2/README.chromium

Change size: XL

Delta: 54 files changed, 794 insertions(+), 407 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Daniel Rubery

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

Roll syn: 2.0.111 => 2.0.114 in //third_party/rust. [chromium/src : main]

Alex Kallam (Gerrit)

Alex Kallam added 1 comment

Related details

gwsq (Gerrit)

Message from gwsq

Related details

Daniel Rubery (Gerrit)

Daniel Rubery voted Code-Review+1

Related details

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change

Change information