fix AshWindowTreeHostPlatform raw_ptr [chromium/src : main]

0 views
Skip to first unread message

Hiroki Oshima (Gerrit)

unread,
Jul 16, 2026, 2:14:51 PM (3 days ago) Jul 16
to Chromium LUCI CQ, Mitsuru Oshima, chromium...@chromium.org
Attention needed from Mitsuru Oshima

Hiroki Oshima added 2 comments

File ash/host/ash_window_tree_host_platform.h
Line 82, Patchset 3: const raw_ref<AshWindowTreeHostDelegate> delegate_; // Not owned.
Mitsuru Oshima . resolved

please use raw_ptr

Hiroki Oshima

Done

Line 93, Patchset 2: raw_ptr<ui::InputController, DanglingUntriaged> input_controller_ = nullptr;
Hiroki Oshima . resolved

Directly assigned in unittest. Might need to add a for test class that inherit OzonePlatform.

Mitsuru Oshima

Just use ui::OzonePlatform::GetInstance()->GetInputController() instead

Hiroki Oshima

Done

Open in Gerrit

Related details

Attention is currently required from:
  • Mitsuru Oshima
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I7eb33b9e620dc3fed7f191e95638ffd2700e4441
Gerrit-Change-Number: 7928493
Gerrit-PatchSet: 6
Gerrit-Owner: Hiroki Oshima <hiroki...@gmail.com>
Gerrit-Reviewer: Mitsuru Oshima <osh...@chromium.org>
Gerrit-Attention: Mitsuru Oshima <osh...@chromium.org>
Gerrit-Comment-Date: Thu, 16 Jul 2026 18:14:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hiroki Oshima <hiroki...@gmail.com>
Comment-In-Reply-To: Mitsuru Oshima <osh...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy

Mitsuru Oshima (Gerrit)

unread,
Jul 17, 2026, 3:00:51 AM (2 days ago) Jul 17
to Hiroki Oshima, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Hiroki Oshima

Mitsuru Oshima voted and added 1 comment

Votes added by Mitsuru Oshima

Commit-Queue+1

1 comment

File ash/host/ash_window_tree_host_platform.h
Line 99, Patchset 7 (Latest): : public aura::ScopedEnableUnadjustedMouseEvents {
Mitsuru Oshima . unresolved

keep this in .cc file

Open in Gerrit

Related details

Attention is currently required from:
  • Hiroki Oshima
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I7eb33b9e620dc3fed7f191e95638ffd2700e4441
    Gerrit-Change-Number: 7928493
    Gerrit-PatchSet: 7
    Gerrit-Owner: Hiroki Oshima <hiroki...@gmail.com>
    Gerrit-Reviewer: Mitsuru Oshima <osh...@chromium.org>
    Gerrit-Attention: Hiroki Oshima <hiroki...@gmail.com>
    Gerrit-Comment-Date: Fri, 17 Jul 2026 07:00:35 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Mitsuru Oshima (Gerrit)

    unread,
    Jul 17, 2026, 2:21:54 PM (2 days ago) Jul 17
    to Hiroki Oshima, Chromium LUCI CQ, chromium...@chromium.org
    Attention needed from Hiroki Oshima

    Mitsuru Oshima added 1 comment

    Patchset-level comments
    File-level comment, Patchset 7 (Latest):
    Mitsuru Oshima . resolved

    please look into test failure

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Hiroki Oshima
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I7eb33b9e620dc3fed7f191e95638ffd2700e4441
    Gerrit-Change-Number: 7928493
    Gerrit-PatchSet: 7
    Gerrit-Owner: Hiroki Oshima <hiroki...@gmail.com>
    Gerrit-Reviewer: Mitsuru Oshima <osh...@chromium.org>
    Gerrit-Attention: Hiroki Oshima <hiroki...@gmail.com>
    Gerrit-Comment-Date: Fri, 17 Jul 2026 18:21:40 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Hiroki Oshima (Gerrit)

    unread,
    Jul 18, 2026, 12:34:28 AM (yesterday) Jul 18
    to Mitsuru Oshima, Chromium LUCI CQ, chromium...@chromium.org
    Attention needed from Mitsuru Oshima

    Hiroki Oshima added 1 comment

    File ash/host/ash_window_tree_host_platform.h
    Line 99, Patchset 7: : public aura::ScopedEnableUnadjustedMouseEvents {
    Mitsuru Oshima . resolved

    keep this in .cc file

    Hiroki Oshima

    Done

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Mitsuru Oshima
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I7eb33b9e620dc3fed7f191e95638ffd2700e4441
      Gerrit-Change-Number: 7928493
      Gerrit-PatchSet: 8
      Gerrit-Owner: Hiroki Oshima <hiroki...@gmail.com>
      Gerrit-Reviewer: Mitsuru Oshima <osh...@chromium.org>
      Gerrit-Attention: Mitsuru Oshima <osh...@chromium.org>
      Gerrit-Comment-Date: Sat, 18 Jul 2026 04:34:14 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Mitsuru Oshima <osh...@chromium.org>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Mitsuru Oshima (Gerrit)

      unread,
      Jul 18, 2026, 6:01:32 AM (yesterday) Jul 18
      to Hiroki Oshima, Chromium LUCI CQ, chromium...@chromium.org
      Attention needed from Hiroki Oshima

      Mitsuru Oshima voted Commit-Queue+1

      Commit-Queue+1
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Hiroki Oshima
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I7eb33b9e620dc3fed7f191e95638ffd2700e4441
      Gerrit-Change-Number: 7928493
      Gerrit-PatchSet: 8
      Gerrit-Owner: Hiroki Oshima <hiroki...@gmail.com>
      Gerrit-Reviewer: Mitsuru Oshima <osh...@chromium.org>
      Gerrit-Attention: Hiroki Oshima <hiroki...@gmail.com>
      Gerrit-Comment-Date: Sat, 18 Jul 2026 10:01:18 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Hiroki Oshima (Gerrit)

      unread,
      Jul 18, 2026, 2:42:56 PM (17 hours ago) Jul 18
      to Mitsuru Oshima, Chromium LUCI CQ, chromium...@chromium.org
      Attention needed from Mitsuru Oshima

      Hiroki Oshima added 1 comment

      Patchset-level comments
      File-level comment, Patchset 8 (Latest):
      Hiroki Oshima . resolved

      Fix Test.

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Mitsuru Oshima
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I7eb33b9e620dc3fed7f191e95638ffd2700e4441
      Gerrit-Change-Number: 7928493
      Gerrit-PatchSet: 8
      Gerrit-Owner: Hiroki Oshima <hiroki...@gmail.com>
      Gerrit-Reviewer: Mitsuru Oshima <osh...@chromium.org>
      Gerrit-Attention: Mitsuru Oshima <osh...@chromium.org>
      Gerrit-Comment-Date: Sat, 18 Jul 2026 18:42:42 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Hiroki Oshima (Gerrit)

      unread,
      Jul 18, 2026, 2:44:32 PM (17 hours ago) Jul 18
      to Mitsuru Oshima, Chromium LUCI CQ, chromium...@chromium.org
      Attention needed from Mitsuru Oshima

      Hiroki Oshima added 1 comment

      Patchset-level comments
      Hiroki Oshima . resolved

      Fix Test.

      Hiroki Oshima

      Check images.

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Mitsuru Oshima
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I7eb33b9e620dc3fed7f191e95638ffd2700e4441
      Gerrit-Change-Number: 7928493
      Gerrit-PatchSet: 8
      Gerrit-Owner: Hiroki Oshima <hiroki...@gmail.com>
      Gerrit-Reviewer: Mitsuru Oshima <osh...@chromium.org>
      Gerrit-Attention: Mitsuru Oshima <osh...@chromium.org>
      Gerrit-Comment-Date: Sat, 18 Jul 2026 18:44:18 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Hiroki Oshima <hiroki...@gmail.com>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy
      Reply all
      Reply to author
      Forward
      0 new messages