Reland: [Journeys] Add a couple coordinator tests [chromium/src : main]

0 views
Skip to first unread message

Patrick Noland (Gerrit)

unread,
Jun 30, 2022, 3:02:11 PMJun 30
to chrome-intell...@chromium.org, Gang Wu, Chromium LUCI CQ, chromium...@chromium.org

Attention is currently required from: Gang Wu.

View Change

    To view, visit change 3739039. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I8aa6a689f1116077f50d09b5d211b6121a604e4e
    Gerrit-Change-Number: 3739039
    Gerrit-PatchSet: 1
    Gerrit-Owner: Patrick Noland <pno...@chromium.org>
    Gerrit-Reviewer: Gang Wu <gan...@chromium.org>
    Gerrit-Reviewer: Patrick Noland <pno...@chromium.org>
    Gerrit-Attention: Gang Wu <gan...@chromium.org>
    Gerrit-Comment-Date: Thu, 30 Jun 2022 19:02:03 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: No
    Gerrit-MessageType: comment

    Gang Wu (Gerrit)

    unread,
    Jul 2, 2022, 12:44:46 AMJul 2
    to Patrick Noland, chrome-intell...@chromium.org, Chromium LUCI CQ, chromium...@chromium.org

    Attention is currently required from: Patrick Noland.

    Patch set 1:Code-Review +1

    View Change

      To view, visit change 3739039. To unsubscribe, or for help writing mail filters, visit settings.

      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I8aa6a689f1116077f50d09b5d211b6121a604e4e
      Gerrit-Change-Number: 3739039
      Gerrit-PatchSet: 1
      Gerrit-Owner: Patrick Noland <pno...@chromium.org>
      Gerrit-Reviewer: Gang Wu <gan...@chromium.org>
      Gerrit-Reviewer: Patrick Noland <pno...@chromium.org>
      Gerrit-Attention: Patrick Noland <pno...@chromium.org>
      Gerrit-Comment-Date: Sat, 02 Jul 2022 04:44:37 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      Gerrit-MessageType: comment

      Patrick Noland (Gerrit)

      unread,
      Jul 7, 2022, 1:46:39 PMJul 7
      to chrome-intell...@chromium.org, Gang Wu, Chromium LUCI CQ, chromium...@chromium.org

      Attention is currently required from: Patrick Noland.

      Patch set 1:Commit-Queue +2

      View Change

        To view, visit change 3739039. To unsubscribe, or for help writing mail filters, visit settings.

        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: I8aa6a689f1116077f50d09b5d211b6121a604e4e
        Gerrit-Change-Number: 3739039
        Gerrit-PatchSet: 1
        Gerrit-Owner: Patrick Noland <pno...@chromium.org>
        Gerrit-Reviewer: Gang Wu <gan...@chromium.org>
        Gerrit-Reviewer: Patrick Noland <pno...@chromium.org>
        Gerrit-Attention: Patrick Noland <pno...@chromium.org>
        Gerrit-Comment-Date: Thu, 07 Jul 2022 17:46:30 +0000

        Chromium LUCI CQ (Gerrit)

        unread,
        Jul 7, 2022, 2:16:25 PMJul 7
        to Patrick Noland, chrome-intell...@chromium.org, Gang Wu, chromium...@chromium.org

        Chromium LUCI CQ submitted this change.

        View Change


        Approvals: Gang Wu: Looks good to me Patrick Noland: Commit
        Reland: [Journeys] Add a couple coordinator tests

        This should expand code coverage significantly by covering inflation and
        view binding.

        Reland note: fixed compile by adjusting constructor changed in a CL that
        landed concurrently.

        Bug: 1303171
        Change-Id: I8aa6a689f1116077f50d09b5d211b6121a604e4e
        Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3739039
        Commit-Queue: Patrick Noland <pno...@chromium.org>
        Reviewed-by: Gang Wu <gan...@chromium.org>
        Cr-Commit-Position: refs/heads/main@{#1021770}
        ---
        M chrome/android/junit/src/org/chromium/chrome/browser/history_clusters/HistoryClustersCoordinatorTest.java
        1 file changed, 68 insertions(+), 1 deletion(-)


        To view, visit change 3739039. To unsubscribe, or for help writing mail filters, visit settings.

        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: I8aa6a689f1116077f50d09b5d211b6121a604e4e
        Gerrit-Change-Number: 3739039
        Gerrit-PatchSet: 2
        Gerrit-Owner: Patrick Noland <pno...@chromium.org>
        Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
        Gerrit-Reviewer: Gang Wu <gan...@chromium.org>
        Gerrit-Reviewer: Patrick Noland <pno...@chromium.org>
        Gerrit-MessageType: merged
        Reply all
        Reply to author
        Forward
        0 new messages