[TEST] KeyboardLayoutMap permission [chromium/src : main]

0 views
Skip to first unread message

Anton Bershanskyi (Gerrit)

unread,
7:49 AM (5 hours ago) 7:49 AM
to chromium...@chromium.org

Anton Bershanskyi has uploaded the change for review

Anton Bershanskyi removed chromium...@chromium.org from reviewers of this change.

Commit message

[TEST] KeyboardLayoutMap permission
Change-Id: I3680f9eb963a530a2e229c5fe6ea33893bac299d
Bug: None

Change diff

diff --git a/content/browser/keyboard_lock/keyboard_lock_service_impl.cc b/content/browser/keyboard_lock/keyboard_lock_service_impl.cc
index 31fc6ee..ee3d47a8 100644
--- a/content/browser/keyboard_lock/keyboard_lock_service_impl.cc
+++ b/content/browser/keyboard_lock/keyboard_lock_service_impl.cc
@@ -142,8 +142,7 @@
auto response = GetKeyboardLayoutMapResult::New();
// The keyboard layout map is only accessible from the outermost main frame or
// with the permission policy enabled.
- if (frame_host_impl.GetParentOrOuterDocument() &&
- !frame_host_impl.IsFeatureEnabled(
+ if (!frame_host_impl.IsFeatureEnabled(
network::mojom::PermissionsPolicyFeature::kKeyboardMap)) {
response->status = blink::mojom::GetKeyboardLayoutMapStatus::kDenied;
std::move(callback).Run(std::move(response));

Change information

Files:
  • M content/browser/keyboard_lock/keyboard_lock_service_impl.cc
Change size: XS
Delta: 1 file changed, 1 insertion(+), 2 deletions(-)
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I3680f9eb963a530a2e229c5fe6ea33893bac299d
Gerrit-Change-Number: 5372453
Gerrit-PatchSet: 159
Gerrit-Owner: Anton Bershanskyi <bersh...@gmail.com>
Gerrit-Reviewer: Anton Bershanskyi <bersh...@gmail.com>
satisfied_requirement
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages