[unsafe-buffers] Remove allow_unsafe_buffers from sandbox/ [chromium/src : main]

0 views
Skip to first unread message

Arthur Sonzogni (Gerrit)

unread,
Jul 7, 2026, 5:15:23 AM (yesterday) Jul 7
to Will Harris, chromium...@chromium.org, (Julie)Jeongeun Kim, Kevin Babbitt, Sadrul Chowdhury, Zhe Su, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, abigailbk...@google.com, agriev...@chromium.org, arc-review...@google.com, bartek...@chromium.org, blink-...@chromium.org, caitkp...@chromium.org, dcheng+c...@chromium.org, derinel+wat...@google.com, dtseng...@chromium.org, francisjp...@google.com, gcasto+w...@chromium.org, grt+...@chromium.org, hidehik...@chromium.org, ios-r...@chromium.org, jessemcke...@google.com, josiah...@chromium.org, jshin...@chromium.org, keithle...@chromium.org, kinuko...@chromium.org, kyungjunle...@google.com, lizeb...@chromium.org, lucasrada...@google.com, mattreyno...@chromium.org, nektar...@chromium.org, nona+...@chromium.org, nyquis...@chromium.org, ortuno...@chromium.org, pasko...@chromium.org, pmonett...@chromium.org, roblia...@chromium.org, shuche...@chromium.org, sky+...@chromium.org, titoua...@chromium.org, torne...@chromium.org, tranbaod...@chromium.org, vasilii+watchlis...@chromium.org, webauthn...@chromium.org, yfriedm...@chromium.org, yhanad...@chromium.org, yhanada+...@chromium.org, yuzo+...@chromium.org, wfh+...@chromium.org, mpdento...@chromium.org, rsesek...@chromium.org, mac-r...@chromium.org
Attention needed from Will Harris

Arthur Sonzogni added 1 comment

Patchset-level comments
File-level comment, Patchset 6 (Latest):
Arthur Sonzogni . resolved

Hi Will,
Could you please take a look?

Open in Gerrit

Related details

Attention is currently required from:
  • Will Harris
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ie018f5d447476d25e57901e1317be8f65cf151bd
Gerrit-Change-Number: 8035239
Gerrit-PatchSet: 6
Gerrit-Owner: Arthur Sonzogni <arthurs...@chromium.org>
Gerrit-Reviewer: Arthur Sonzogni <arthurs...@chromium.org>
Gerrit-Reviewer: Will Harris <w...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
Gerrit-CC: Sadrul Chowdhury <sad...@chromium.org>
Gerrit-CC: Zhe Su <su...@chromium.org>
Gerrit-Attention: Will Harris <w...@chromium.org>
Gerrit-Comment-Date: Tue, 07 Jul 2026 09:15:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Arthur Sonzogni (Gerrit)

unread,
Jul 7, 2026, 5:17:39 AM (yesterday) Jul 7
to Will Harris, chromium...@chromium.org, (Julie)Jeongeun Kim, Kevin Babbitt, Sadrul Chowdhury, Zhe Su, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, abigailbk...@google.com, agriev...@chromium.org, arc-review...@google.com, bartek...@chromium.org, blink-...@chromium.org, caitkp...@chromium.org, dcheng+c...@chromium.org, derinel+wat...@google.com, dtseng...@chromium.org, francisjp...@google.com, gcasto+w...@chromium.org, grt+...@chromium.org, hidehik...@chromium.org, ios-r...@chromium.org, jessemcke...@google.com, josiah...@chromium.org, jshin...@chromium.org, keithle...@chromium.org, kinuko...@chromium.org, kyungjunle...@google.com, lizeb...@chromium.org, lucasrada...@google.com, mattreyno...@chromium.org, nektar...@chromium.org, nona+...@chromium.org, nyquis...@chromium.org, ortuno...@chromium.org, pasko...@chromium.org, pmonett...@chromium.org, roblia...@chromium.org, shuche...@chromium.org, sky+...@chromium.org, titoua...@chromium.org, torne...@chromium.org, tranbaod...@chromium.org, vasilii+watchlis...@chromium.org, webauthn...@chromium.org, yfriedm...@chromium.org, yhanad...@chromium.org, yhanada+...@chromium.org, yuzo+...@chromium.org, wfh+...@chromium.org, mpdento...@chromium.org, rsesek...@chromium.org, mac-r...@chromium.org
Attention needed from Will Harris

Arthur Sonzogni added 1 comment

File sandbox/win/src/sandbox_nt_util.cc
Line 326, Patchset 6: UNSAFE_TODO(GetNtExports()->memcpy)(destination, source, bytes);
Arthur Sonzogni . resolved

Let's wrap the full expression.

Arthur Sonzogni

Done, wrapped the full expression.

Gerrit-Comment-Date: Tue, 07 Jul 2026 09:17:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Sonzogni <arthurs...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy

Arthur Sonzogni (Gerrit)

unread,
Jul 7, 2026, 5:17:43 AM (yesterday) Jul 7
to Will Harris, chromium...@chromium.org, (Julie)Jeongeun Kim, Kevin Babbitt, Sadrul Chowdhury, Zhe Su, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, abigailbk...@google.com, agriev...@chromium.org, arc-review...@google.com, bartek...@chromium.org, blink-...@chromium.org, caitkp...@chromium.org, dcheng+c...@chromium.org, derinel+wat...@google.com, dtseng...@chromium.org, francisjp...@google.com, gcasto+w...@chromium.org, grt+...@chromium.org, hidehik...@chromium.org, ios-r...@chromium.org, jessemcke...@google.com, josiah...@chromium.org, jshin...@chromium.org, keithle...@chromium.org, kinuko...@chromium.org, kyungjunle...@google.com, lizeb...@chromium.org, lucasrada...@google.com, mattreyno...@chromium.org, nektar...@chromium.org, nona+...@chromium.org, nyquis...@chromium.org, ortuno...@chromium.org, pasko...@chromium.org, pmonett...@chromium.org, roblia...@chromium.org, shuche...@chromium.org, sky+...@chromium.org, titoua...@chromium.org, torne...@chromium.org, tranbaod...@chromium.org, vasilii+watchlis...@chromium.org, webauthn...@chromium.org, yfriedm...@chromium.org, yhanad...@chromium.org, yhanada+...@chromium.org, yuzo+...@chromium.org, wfh+...@chromium.org, mpdento...@chromium.org, rsesek...@chromium.org, mac-r...@chromium.org
Attention needed from Will Harris

Arthur Sonzogni added 1 comment

File sandbox/win/src/sandbox_nt_util.cc
Line 419, Patchset 6: ansi_string.Length =
static_cast<USHORT>(UNSAFE_TODO(GetNtExports()->strlen)(string));
Arthur Sonzogni . resolved

Let's wrap the full expression

Arthur Sonzogni
Gerrit-Comment-Date: Tue, 07 Jul 2026 09:17:29 +0000
satisfied_requirement
unsatisfied_requirement
open
diffy

Arthur Sonzogni (Gerrit)

unread,
Jul 7, 2026, 5:17:51 AM (yesterday) Jul 7
to Will Harris, chromium...@chromium.org, (Julie)Jeongeun Kim, Kevin Babbitt, Sadrul Chowdhury, Zhe Su, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, abigailbk...@google.com, agriev...@chromium.org, arc-review...@google.com, bartek...@chromium.org, blink-...@chromium.org, caitkp...@chromium.org, dcheng+c...@chromium.org, derinel+wat...@google.com, dtseng...@chromium.org, francisjp...@google.com, gcasto+w...@chromium.org, grt+...@chromium.org, hidehik...@chromium.org, ios-r...@chromium.org, jessemcke...@google.com, josiah...@chromium.org, jshin...@chromium.org, keithle...@chromium.org, kinuko...@chromium.org, kyungjunle...@google.com, lizeb...@chromium.org, lucasrada...@google.com, mattreyno...@chromium.org, nektar...@chromium.org, nona+...@chromium.org, nyquis...@chromium.org, ortuno...@chromium.org, pasko...@chromium.org, pmonett...@chromium.org, roblia...@chromium.org, shuche...@chromium.org, sky+...@chromium.org, titoua...@chromium.org, torne...@chromium.org, tranbaod...@chromium.org, vasilii+watchlis...@chromium.org, webauthn...@chromium.org, yfriedm...@chromium.org, yhanad...@chromium.org, yhanada+...@chromium.org, yuzo+...@chromium.org, wfh+...@chromium.org, mpdento...@chromium.org, rsesek...@chromium.org, mac-r...@chromium.org
Attention needed from Will Harris

Arthur Sonzogni added 1 comment

File sandbox/win/src/sandbox_nt_util.cc
Line 661, Patchset 6: if (UNSAFE_TODO(file_info->FileName[0]) != kPathPrefix[0] ||
Arthur Sonzogni . resolved

Accessing [0] is always safe. Could you please revert all of the UNSAFE_TODO in this patch about [0]?

Arthur Sonzogni

Done, reverted UNSAFE_TODO on index 0.

Open in Gerrit

Related details

Attention is currently required from:
  • Will Harris
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ie018f5d447476d25e57901e1317be8f65cf151bd
    Gerrit-Change-Number: 8035239
    Gerrit-PatchSet: 6
    Gerrit-Owner: Arthur Sonzogni <arthurs...@chromium.org>
    Gerrit-Reviewer: Arthur Sonzogni <arthurs...@chromium.org>
    Gerrit-Reviewer: Will Harris <w...@chromium.org>
    Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
    Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
    Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
    Gerrit-CC: Sadrul Chowdhury <sad...@chromium.org>
    Gerrit-CC: Zhe Su <su...@chromium.org>
    Gerrit-Attention: Will Harris <w...@chromium.org>
    Gerrit-Comment-Date: Tue, 07 Jul 2026 09:17:36 +0000
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Will Harris (Gerrit)

    unread,
    Jul 7, 2026, 2:17:08 PM (22 hours ago) Jul 7
    to Arthur Sonzogni, Will Harris, chromium...@chromium.org, (Julie)Jeongeun Kim, Kevin Babbitt, Sadrul Chowdhury, Zhe Su, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, abigailbk...@google.com, agriev...@chromium.org, arc-review...@google.com, bartek...@chromium.org, blink-...@chromium.org, caitkp...@chromium.org, dcheng+c...@chromium.org, derinel+wat...@google.com, dtseng...@chromium.org, francisjp...@google.com, gcasto+w...@chromium.org, grt+...@chromium.org, hidehik...@chromium.org, ios-r...@chromium.org, jessemcke...@google.com, josiah...@chromium.org, jshin...@chromium.org, keithle...@chromium.org, kinuko...@chromium.org, kyungjunle...@google.com, lizeb...@chromium.org, lucasrada...@google.com, mattreyno...@chromium.org, nektar...@chromium.org, nona+...@chromium.org, nyquis...@chromium.org, ortuno...@chromium.org, pasko...@chromium.org, pmonett...@chromium.org, roblia...@chromium.org, shuche...@chromium.org, sky+...@chromium.org, titoua...@chromium.org, torne...@chromium.org, tranbaod...@chromium.org, vasilii+watchlis...@chromium.org, webauthn...@chromium.org, yfriedm...@chromium.org, yhanad...@chromium.org, yhanada+...@chromium.org, yuzo+...@chromium.org, wfh+...@chromium.org, mpdento...@chromium.org, rsesek...@chromium.org, mac-r...@chromium.org
    Attention needed from Arthur Sonzogni

    Will Harris added 1 comment

    File sandbox/linux/seccomp-bpf-helpers/baseline_policy_unittest.cc
    Line 87, Patchset 10 (Latest): static constexpr std::array<char, kTestTransferSize> kTestString = {'T', 'E',
    Will Harris . unresolved

    this change is not mechanical - can you do the same thing that you did in other files and wrap in `UNSAFE_TODO` - and move this functional change to a separate CL

    thanks

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Arthur Sonzogni
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedNo-Unresolved-Comments
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ie018f5d447476d25e57901e1317be8f65cf151bd
      Gerrit-Change-Number: 8035239
      Gerrit-PatchSet: 10
      Gerrit-Owner: Arthur Sonzogni <arthurs...@chromium.org>
      Gerrit-Reviewer: Arthur Sonzogni <arthurs...@chromium.org>
      Gerrit-Reviewer: Will Harris <w...@chromium.org>
      Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
      Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
      Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
      Gerrit-CC: Sadrul Chowdhury <sad...@chromium.org>
      Gerrit-CC: Zhe Su <su...@chromium.org>
      Gerrit-Attention: Arthur Sonzogni <arthurs...@chromium.org>
      Gerrit-Comment-Date: Tue, 07 Jul 2026 18:16:57 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Arthur Sonzogni (Gerrit)

      unread,
      9:44 AM (3 hours ago) 9:44 AM
      to Will Harris, chromium...@chromium.org, (Julie)Jeongeun Kim, Kevin Babbitt, Sadrul Chowdhury, Zhe Su, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, abigailbk...@google.com, agriev...@chromium.org, arc-review...@google.com, bartek...@chromium.org, blink-...@chromium.org, caitkp...@chromium.org, dcheng+c...@chromium.org, derinel+wat...@google.com, dtseng...@chromium.org, francisjp...@google.com, gcasto+w...@chromium.org, grt+...@chromium.org, hidehik...@chromium.org, ios-r...@chromium.org, jessemcke...@google.com, josiah...@chromium.org, jshin...@chromium.org, keithle...@chromium.org, kinuko...@chromium.org, kyungjunle...@google.com, lizeb...@chromium.org, lucasrada...@google.com, mattreyno...@chromium.org, nektar...@chromium.org, nona+...@chromium.org, nyquis...@chromium.org, ortuno...@chromium.org, pasko...@chromium.org, pmonett...@chromium.org, roblia...@chromium.org, shuche...@chromium.org, sky+...@chromium.org, titoua...@chromium.org, torne...@chromium.org, tranbaod...@chromium.org, vasilii+watchlis...@chromium.org, webauthn...@chromium.org, yfriedm...@chromium.org, yhanad...@chromium.org, yhanada+...@chromium.org, yuzo+...@chromium.org, wfh+...@chromium.org, mpdento...@chromium.org, rsesek...@chromium.org, mac-r...@chromium.org
      Attention needed from Will Harris

      Arthur Sonzogni voted and added 2 comments

      Votes added by Arthur Sonzogni

      Auto-Submit+1
      Commit-Queue+1

      2 comments

      File sandbox/linux/seccomp-bpf-helpers/baseline_policy_unittest.cc
      Line 87, Patchset 10: static constexpr std::array<char, kTestTransferSize> kTestString = {'T', 'E',
      Will Harris . resolved

      this change is not mechanical - can you do the same thing that you did in other files and wrap in `UNSAFE_TODO` - and move this functional change to a separate CL

      thanks

      Arthur Sonzogni

      Done

      File sandbox/win/src/sandbox_nt_util.cc
      Line 165, Patchset 11 (Latest): UNSAFE_TODO(INIT_RTL(_strnicmp));
      UNSAFE_TODO(INIT_RTL(strlen));
      UNSAFE_TODO(INIT_RTL(wcslen));
      UNSAFE_TODO(INIT_RTL(memcpy));
      Arthur Sonzogni . resolved

      Note: I double checked this caused -WUnsafe-buffer-usage errors. This is weird, but I guess LLVM is not yet smart enough to recognize we aren't really calling those function.

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Will Harris
      Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement is not satisfiedCode-Owners
        • requirement is not satisfiedCode-Review
        • requirement is not satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: Ie018f5d447476d25e57901e1317be8f65cf151bd
        Gerrit-Change-Number: 8035239
        Gerrit-PatchSet: 11
        Gerrit-Owner: Arthur Sonzogni <arthurs...@chromium.org>
        Gerrit-Reviewer: Arthur Sonzogni <arthurs...@chromium.org>
        Gerrit-Reviewer: Will Harris <w...@chromium.org>
        Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
        Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
        Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
        Gerrit-CC: Sadrul Chowdhury <sad...@chromium.org>
        Gerrit-CC: Zhe Su <su...@chromium.org>
        Gerrit-Attention: Will Harris <w...@chromium.org>
        Gerrit-Comment-Date: Wed, 08 Jul 2026 13:44:38 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: Yes
        Comment-In-Reply-To: Will Harris <w...@chromium.org>
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy

        Arthur Sonzogni (Gerrit)

        unread,
        9:47 AM (2 hours ago) 9:47 AM
        to Will Harris, chromium...@chromium.org, (Julie)Jeongeun Kim, Kevin Babbitt, Sadrul Chowdhury, Zhe Su, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, abigailbk...@google.com, agriev...@chromium.org, arc-review...@google.com, bartek...@chromium.org, blink-...@chromium.org, caitkp...@chromium.org, dcheng+c...@chromium.org, derinel+wat...@google.com, dtseng...@chromium.org, francisjp...@google.com, gcasto+w...@chromium.org, grt+...@chromium.org, hidehik...@chromium.org, ios-r...@chromium.org, jessemcke...@google.com, josiah...@chromium.org, jshin...@chromium.org, keithle...@chromium.org, kinuko...@chromium.org, kyungjunle...@google.com, lizeb...@chromium.org, lucasrada...@google.com, mattreyno...@chromium.org, nektar...@chromium.org, nona+...@chromium.org, nyquis...@chromium.org, ortuno...@chromium.org, pasko...@chromium.org, pmonett...@chromium.org, roblia...@chromium.org, shuche...@chromium.org, sky+...@chromium.org, titoua...@chromium.org, torne...@chromium.org, tranbaod...@chromium.org, vasilii+watchlis...@chromium.org, webauthn...@chromium.org, yfriedm...@chromium.org, yhanad...@chromium.org, yhanada+...@chromium.org, yuzo+...@chromium.org, wfh+...@chromium.org, mpdento...@chromium.org, rsesek...@chromium.org, mac-r...@chromium.org
        Attention needed from Will Harris

        Arthur Sonzogni added 1 comment

        File sandbox/linux/seccomp-bpf-helpers/baseline_policy_unittest.cc
        Line 87, Patchset 10: static constexpr std::array<char, kTestTransferSize> kTestString = {'T', 'E',
        Will Harris . resolved

        this change is not mechanical - can you do the same thing that you did in other files and wrap in `UNSAFE_TODO` - and move this functional change to a separate CL

        thanks

        Arthur Sonzogni

        Done

        Gerrit-Comment-Date: Wed, 08 Jul 2026 13:47:16 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: No
        Comment-In-Reply-To: Arthur Sonzogni <arthurs...@chromium.org>
        Comment-In-Reply-To: Will Harris <w...@chromium.org>
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy

        Will Harris (Gerrit)

        unread,
        11:16 AM (1 hour ago) 11:16 AM
        to Arthur Sonzogni, Will Harris, chromium...@chromium.org, (Julie)Jeongeun Kim, Kevin Babbitt, Sadrul Chowdhury, Zhe Su, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, abigailbk...@google.com, agriev...@chromium.org, arc-review...@google.com, bartek...@chromium.org, blink-...@chromium.org, caitkp...@chromium.org, dcheng+c...@chromium.org, derinel+wat...@google.com, dtseng...@chromium.org, francisjp...@google.com, gcasto+w...@chromium.org, grt+...@chromium.org, hidehik...@chromium.org, ios-r...@chromium.org, jessemcke...@google.com, josiah...@chromium.org, jshin...@chromium.org, keithle...@chromium.org, kinuko...@chromium.org, kyungjunle...@google.com, lizeb...@chromium.org, lucasrada...@google.com, mattreyno...@chromium.org, nektar...@chromium.org, nona+...@chromium.org, nyquis...@chromium.org, ortuno...@chromium.org, pasko...@chromium.org, pmonett...@chromium.org, roblia...@chromium.org, shuche...@chromium.org, sky+...@chromium.org, titoua...@chromium.org, torne...@chromium.org, tranbaod...@chromium.org, vasilii+watchlis...@chromium.org, webauthn...@chromium.org, yfriedm...@chromium.org, yhanad...@chromium.org, yhanada+...@chromium.org, yuzo+...@chromium.org, wfh+...@chromium.org, mpdento...@chromium.org, rsesek...@chromium.org, mac-r...@chromium.org
        Attention needed from Arthur Sonzogni

        Will Harris voted and added 1 comment

        Votes added by Will Harris

        Code-Review+1
        Commit-Queue+2

        1 comment

        Patchset-level comments
        Open in Gerrit

        Related details

        Attention is currently required from:
        • Arthur Sonzogni
        Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: Ie018f5d447476d25e57901e1317be8f65cf151bd
        Gerrit-Change-Number: 8035239
        Gerrit-PatchSet: 11
        Gerrit-Owner: Arthur Sonzogni <arthurs...@chromium.org>
        Gerrit-Reviewer: Arthur Sonzogni <arthurs...@chromium.org>
        Gerrit-Reviewer: Will Harris <w...@chromium.org>
        Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
        Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
        Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
        Gerrit-CC: Sadrul Chowdhury <sad...@chromium.org>
        Gerrit-CC: Zhe Su <su...@chromium.org>
        Gerrit-Attention: Arthur Sonzogni <arthurs...@chromium.org>
        Gerrit-Comment-Date: Wed, 08 Jul 2026 15:16:17 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        open
        diffy

        Chromium LUCI CQ (Gerrit)

        unread,
        11:20 AM (1 hour ago) 11:20 AM
        to Arthur Sonzogni, Will Harris, Akihiro Ota, chromium...@chromium.org, (Julie)Jeongeun Kim, Kevin Babbitt, Sadrul Chowdhury, Zhe Su, android-bu...@system.gserviceaccount.com, abigailbk...@google.com, agriev...@chromium.org, arc-review...@google.com, bartek...@chromium.org, blink-...@chromium.org, caitkp...@chromium.org, dcheng+c...@chromium.org, derinel+wat...@google.com, dtseng...@chromium.org, francisjp...@google.com, gcasto+w...@chromium.org, grt+...@chromium.org, hidehik...@chromium.org, ios-r...@chromium.org, jessemcke...@google.com, josiah...@chromium.org, jshin...@chromium.org, keithle...@chromium.org, kinuko...@chromium.org, kyungjunle...@google.com, lizeb...@chromium.org, lucasrada...@google.com, mattreyno...@chromium.org, nektar...@chromium.org, nona+...@chromium.org, nyquis...@chromium.org, ortuno...@chromium.org, pasko...@chromium.org, pmonett...@chromium.org, roblia...@chromium.org, shuche...@chromium.org, sky+...@chromium.org, titoua...@chromium.org, torne...@chromium.org, tranbaod...@chromium.org, vasilii+watchlis...@chromium.org, webauthn...@chromium.org, yfriedm...@chromium.org, yhanad...@chromium.org, yhanada+...@chromium.org, yuzo+...@chromium.org, wfh+...@chromium.org, mpdento...@chromium.org, rsesek...@chromium.org, mac-r...@chromium.org

        Chromium LUCI CQ submitted the change

        Change information

        Commit message:
        [unsafe-buffers] Remove allow_unsafe_buffers from sandbox/

        This is a mechanical change transitioning the last few files in sandbox/
        from coarse, file-level pragmas to fine-grained, instruction-level
        UNSAFE_TODO() macros.
        Bug: 351564777, 501112808
        Doc: go/complete_unsafe_todo_migration
        Change-Id: Ie018f5d447476d25e57901e1317be8f65cf151bd
        Auto-Submit: Arthur Sonzogni <arthurs...@chromium.org>
        Reviewed-by: Will Harris <w...@chromium.org>
        Commit-Queue: Will Harris <w...@chromium.org>
        Cr-Commit-Position: refs/heads/main@{#1658776}
        Files:
        • M sandbox/linux/seccomp-bpf-helpers/baseline_policy_unittest.cc
        • M sandbox/mac/BUILD.gn
        • M sandbox/mac/DEPS
        • M sandbox/mac/sandbox_logging.cc
        • M sandbox/mac/seatbelt_exec.cc
        • M sandbox/policy/BUILD.gn
        • M sandbox/policy/win/hook_util/hook_util.cc
        • M sandbox/win/src/lpc_policy_test.cc
        • M sandbox/win/src/sandbox_nt_util.cc
        • M sandbox/win/src/sandbox_nt_util_unittest.cc
        • M sandbox/win/src/sandbox_policy_base.cc
        • M sandbox/win/src/target_process.cc
        Change size: M
        Delta: 12 files changed, 96 insertions(+), 115 deletions(-)
        Branch: refs/heads/main
        Submit Requirements:
        • requirement satisfiedCode-Review: +1 by Will Harris
        Open in Gerrit
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: merged
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: Ie018f5d447476d25e57901e1317be8f65cf151bd
        Gerrit-Change-Number: 8035239
        Gerrit-PatchSet: 12
        Gerrit-Owner: Arthur Sonzogni <arthurs...@chromium.org>
        Gerrit-Reviewer: Arthur Sonzogni <arthurs...@chromium.org>
        Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
        Gerrit-Reviewer: Will Harris <w...@chromium.org>
        Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
        Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
        open
        diffy
        satisfied_requirement
        Reply all
        Reply to author
        Forward
        0 new messages