Fleet Console: add em53-acs and em53-atc to lab name filters in android_devicedb [infra/infra : main]
0 views
Skip to first unread message
Piotr Grabski-Gradziński (Gerrit)
4:22 AM (3 hours ago) 4:22 AM
to Pietro Scuttari, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, fleet-console-...@google.com, infra-rev...@chromium.org
Attention needed from Pietro Scuttari
Piotr Grabski-Gradziński voted Auto-Submit+1![]( "Open in Gerrit")
| Auto-Submit | +1 |
Related details
Attention is currently required from:
- Pietro Scuttari
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Pietro Scuttari (Gerrit)
4:32 AM (3 hours ago) 4:32 AM
to Piotr Grabski-Gradziński, LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, fleet-console-...@google.com, infra-rev...@chromium.org
Attention needed from Piotr Grabski-Gradziński
Pietro Scuttari voted and added 1 comment![]( "Open in Gerrit")
Votes added by Pietro Scuttari
| Code-Review | +1 |
| Commit-Queue | +2 |
1 comment
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Pietro Scuttari . resolved
I think there will be a couple failing tests that need to be updated but otherwise lgtm
Related details
Attention is currently required from:
- Piotr Grabski-Gradziński
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Piotr Grabski-Gradziński (Gerrit)
5:09 AM (2 hours ago) 5:09 AM
to Pietro Scuttari, LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, fleet-console-...@google.com, infra-rev...@chromium.org
Attention needed from Pietro Scuttari
Piotr Grabski-Gradziński voted and added 1 comment![]( "Open in Gerrit")
Votes added by Piotr Grabski-Gradziński
| Auto-Submit | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 2 (Latest):
Piotr Grabski-Gradziński . resolved
True, added tests and it's now passing. I'd be grateful for +1 as I lost it. Thanks!
Related details
Attention is currently required from:
- Pietro Scuttari
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Pietro Scuttari (Gerrit)
5:56 AM (1 hour ago) 5:56 AM
to Piotr Grabski-Gradziński, LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, fleet-console-...@google.com, infra-rev...@chromium.org
Attention needed from Piotr Grabski-Gradziński
Pietro Scuttari voted![]( "Open in Gerrit")
Attention is currently required from:
- Piotr Grabski-Gradziński
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
LUCI CQ (Gerrit)
5:58 AM (1 hour ago) 5:58 AM
to Piotr Grabski-Gradziński, Pietro Scuttari, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, fleet-console-...@google.com, infra-rev...@chromium.org
LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Fleet Console: add em53-acs and em53-atc to lab name filters in android_devicedb
Bug: b/529848499
Change-Id: I8a63c5a6287be3c1a3fe1fefbd8339f3ade3f3da
Reviewed-by: Pietro Scuttari <pietro...@google.com>
Auto-Submit: Piotr Grabski-Gradziński <pio...@google.com>
Commit-Queue: Pietro Scuttari <pietro...@google.com>
Cr-Commit-Position: refs/heads/main@{#81777}
Files:
- M go/src/infra/fleetconsole/internal/infra/database/android_devicedb/devicecleanup_test.go
- M go/src/infra/fleetconsole/internal/infra/database/android_devicedb/filters.go
Change size: S
Delta: 2 files changed, 11 insertions(+), 7 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Pietro Scuttari
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages