Async YUV readback preserves source colorspace [chromium/src : main]
0 views
Skip to first unread message
Michael Ludwig (Gerrit)
Jun 30, 2026, 1:40:12 PM (8 days ago) Jun 30
to chromium...@chromium.org
Michael Ludwig voted and added 1 comment![]( "Open in Gerrit")
Votes added by Michael Ludwig
| Commit-Queue | +1 |
1 comment
File gpu/command_buffer/service/raster_decoder.cc
Line 2685, Patchset 4 (Latest):
&OnReadYUVImagePixelsDone, &yuv_result);Michael Ludwig . unresolved
Should this be wrapped in a `base::BindOnce` to match the Graphite branch?
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Ludwig (Gerrit)
Jul 1, 2026, 10:36:39 AM (7 days ago) Jul 1
to Vasiliy Telezhnikov, Ilya Nikolaevskiy, Chromium LUCI CQ, chromium...@chromium.org, cca...@chromium.org
Attention needed from Ilya Nikolaevskiy and Vasiliy Telezhnikov
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Ilya Nikolaevskiy
- Vasiliy Telezhnikov
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ilya Nikolaevskiy (Gerrit)
Jul 1, 2026, 12:27:21 PM (7 days ago) Jul 1
to Michael Ludwig, Vasiliy Telezhnikov, Chromium LUCI CQ, chromium...@chromium.org, cca...@chromium.org
Attention needed from Michael Ludwig and Vasiliy Telezhnikov
Ilya Nikolaevskiy voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Michael Ludwig
- Vasiliy Telezhnikov
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Ludwig (Gerrit)
Jul 1, 2026, 4:53:57 PM (7 days ago) Jul 1
to Ilya Nikolaevskiy, Vasiliy Telezhnikov, Chromium LUCI CQ, chromium...@chromium.org, cca...@chromium.org
Attention needed from Vasiliy Telezhnikov
Michael Ludwig voted Auto-Submit+1![]( "Open in Gerrit")
Attention is currently required from:
- Vasiliy Telezhnikov
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Vasiliy Telezhnikov (Gerrit)
2:04 PM (7 hours ago) 2:04 PM
to Michael Ludwig, Code Review Nudger, Ilya Nikolaevskiy, Chromium LUCI CQ, chromium...@chromium.org, cca...@chromium.org
Attention needed from Michael Ludwig
Vasiliy Telezhnikov voted and added 2 comments![]( "Open in Gerrit")
Votes added by Vasiliy Telezhnikov
| Code-Review | +1 |
| Commit-Queue | +2 |
2 comments
Patchset-level comments
File gpu/command_buffer/service/raster_decoder.cc
Line 2685, Patchset 4 (Latest):
&OnReadYUVImagePixelsDone, &yuv_result);Michael Ludwig . resolved
Should this be wrapped in a `base::BindOnce` to match the Graphite branch?
Vasiliy Telezhnikov
No, as this calls directly on the GrContext, unlike graphite which has wrapper that handles chrome types.
Related details
Attention is currently required from:
- Michael Ludwig
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
4:05 PM (5 hours ago) 4:05 PM
to Michael Ludwig, Vasiliy Telezhnikov, Code Review Nudger, Ilya Nikolaevskiy, chromium...@chromium.org, cca...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Async YUV readback preserves source colorspace
Uses the source's SkImage's SkColorSpace (which is derived from the
shared image's gfx::ColorSpace already). For multi-planar formats,
it also attempts to find the shared image's SkYUVColorSpace from its
gfx::ColorSpace. For single-plane formats, it defaults to Rec601.
Bug: 509871016
Change-Id: Ic8d6530692f61a6fbbc8fe2b36c98a20cffff8d3
Reviewed-by: Ilya Nikolaevskiy <il...@chromium.org>
Reviewed-by: Vasiliy Telezhnikov <vas...@chromium.org>
Commit-Queue: Vasiliy Telezhnikov <vas...@chromium.org>
Auto-Submit: Michael Ludwig <michae...@google.com>
Cr-Commit-Position: refs/heads/main@{#1659014}
Files:
- M gpu/command_buffer/service/raster_decoder.cc
Change size: S
Delta: 1 file changed, 18 insertions(+), 7 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Vasiliy Telezhnikov, +1 by Ilya Nikolaevskiy
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages