[Contextual tasks] Close side panel if navigate to contextual tasks URL [chromium/src : main]

0 views
Skip to first unread message

Matthew Jones (Gerrit)

unread,
Dec 15, 2025, 12:39:42 PM (19 hours ago) Dec 15
to Yuheng Huang, Min Qin, Mickey Burks, Chromium LUCI CQ, chromium...@chromium.org, Sophie Chang
Attention needed from Yuheng Huang

Matthew Jones voted and added 4 comments

Votes added by Matthew Jones

Code-Review+1

4 comments

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Matthew Jones . resolved

lgtm % nits

Commit Message
Line 12, Patchset 2 (Latest):Bug:467750003
Matthew Jones . unresolved

I think this patch also addresses 467756141, can you add it to the list if so?

File chrome/browser/contextual_tasks/contextual_tasks_side_panel_coordinator_interactive_uitest.cc
Line 765, Patchset 2 (Latest): EXPECT_EQ(true, coordinator->IsSidePanelOpenForContextualTask());
Matthew Jones . unresolved
nit:
```suggestion
  EXPECT_TRUE(coordinator->IsSidePanelOpenForContextualTask());
```
Line 770, Patchset 2 (Latest): EXPECT_EQ(false, coordinator->IsSidePanelOpenForContextualTask());
Matthew Jones . unresolved
nit:
```suggestion
  EXPECT_FALSE(coordinator->IsSidePanelOpenForContextualTask());
```
Open in Gerrit

Related details

Attention is currently required from:
  • Yuheng Huang
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I61c88064fa7d06c3aed9470e4008a190add419f8
Gerrit-Change-Number: 7257495
Gerrit-PatchSet: 2
Gerrit-Owner: Yuheng Huang <yuh...@chromium.org>
Gerrit-Reviewer: Matthew Jones <mdj...@chromium.org>
Gerrit-Reviewer: Yuheng Huang <yuh...@chromium.org>
Gerrit-CC: Mickey Burks <micke...@chromium.org>
Gerrit-CC: Min Qin <qin...@chromium.org>
Gerrit-CC: Sophie Chang <sophi...@chromium.org>
Gerrit-Attention: Yuheng Huang <yuh...@chromium.org>
Gerrit-Comment-Date: Mon, 15 Dec 2025 17:39:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Yuheng Huang (Gerrit)

unread,
Dec 15, 2025, 2:46:00 PM (17 hours ago) Dec 15
to Matthew Jones, Min Qin, Mickey Burks, Chromium LUCI CQ, chromium...@chromium.org, Sophie Chang
Attention needed from Matthew Jones

Yuheng Huang added 1 comment

Commit Message
Matthew Jones . unresolved

I think this patch also addresses 467756141, can you add it to the list if so?

Yuheng Huang

I think this patch does not fix 467756141 because you can still click on the side panel entry point when a next tab is open unless we disable the entry point in this case. Do we want to do that?

Open in Gerrit

Related details

Attention is currently required from:
  • Matthew Jones
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I61c88064fa7d06c3aed9470e4008a190add419f8
Gerrit-Change-Number: 7257495
Gerrit-PatchSet: 2
Gerrit-Owner: Yuheng Huang <yuh...@chromium.org>
Gerrit-Reviewer: Matthew Jones <mdj...@chromium.org>
Gerrit-Reviewer: Yuheng Huang <yuh...@chromium.org>
Gerrit-CC: Mickey Burks <micke...@chromium.org>
Gerrit-CC: Min Qin <qin...@chromium.org>
Gerrit-CC: Sophie Chang <sophi...@chromium.org>
Gerrit-Attention: Matthew Jones <mdj...@chromium.org>
Gerrit-Comment-Date: Mon, 15 Dec 2025 19:45:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Matthew Jones <mdj...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy

Yuheng Huang (Gerrit)

unread,
Dec 15, 2025, 5:39:31 PM (14 hours ago) Dec 15
to Matthew Jones, Min Qin, Mickey Burks, Chromium LUCI CQ, chromium...@chromium.org, Sophie Chang
Attention needed from Matthew Jones

Yuheng Huang added 3 comments

Commit Message
Line 12, Patchset 2:Bug:467750003
Matthew Jones . resolved

I think this patch also addresses 467756141, can you add it to the list if so?

Yuheng Huang

I think this patch does not fix 467756141 because you can still click on the side panel entry point when a next tab is open unless we disable the entry point in this case. Do we want to do that?

Yuheng Huang

I think that issue could be fixed separately. Marked this as resovled.

File chrome/browser/contextual_tasks/contextual_tasks_side_panel_coordinator_interactive_uitest.cc
Line 765, Patchset 2: EXPECT_EQ(true, coordinator->IsSidePanelOpenForContextualTask());
Matthew Jones . resolved
nit:
```suggestion
  EXPECT_TRUE(coordinator->IsSidePanelOpenForContextualTask());
```
Yuheng Huang

Done

Line 770, Patchset 2: EXPECT_EQ(false, coordinator->IsSidePanelOpenForContextualTask());
Matthew Jones . resolved
nit:
```suggestion
  EXPECT_FALSE(coordinator->IsSidePanelOpenForContextualTask());
```
Yuheng Huang

Done

Open in Gerrit

Related details

Attention is currently required from:
  • Matthew Jones
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I61c88064fa7d06c3aed9470e4008a190add419f8
    Gerrit-Change-Number: 7257495
    Gerrit-PatchSet: 3
    Gerrit-Owner: Yuheng Huang <yuh...@chromium.org>
    Gerrit-Reviewer: Matthew Jones <mdj...@chromium.org>
    Gerrit-Reviewer: Yuheng Huang <yuh...@chromium.org>
    Gerrit-CC: Mickey Burks <micke...@chromium.org>
    Gerrit-CC: Min Qin <qin...@chromium.org>
    Gerrit-CC: Sophie Chang <sophi...@chromium.org>
    Gerrit-Attention: Matthew Jones <mdj...@chromium.org>
    Gerrit-Comment-Date: Mon, 15 Dec 2025 22:39:21 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Yuheng Huang <yuh...@chromium.org>
    Comment-In-Reply-To: Matthew Jones <mdj...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Yuheng Huang (Gerrit)

    unread,
    Dec 15, 2025, 5:40:15 PM (14 hours ago) Dec 15
    to Matthew Jones, Min Qin, Mickey Burks, Chromium LUCI CQ, chromium...@chromium.org, Sophie Chang
    Attention needed from Matthew Jones

    Yuheng Huang voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Matthew Jones
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I61c88064fa7d06c3aed9470e4008a190add419f8
      Gerrit-Change-Number: 7257495
      Gerrit-PatchSet: 3
      Gerrit-Owner: Yuheng Huang <yuh...@chromium.org>
      Gerrit-Reviewer: Matthew Jones <mdj...@chromium.org>
      Gerrit-Reviewer: Yuheng Huang <yuh...@chromium.org>
      Gerrit-CC: Mickey Burks <micke...@chromium.org>
      Gerrit-CC: Min Qin <qin...@chromium.org>
      Gerrit-CC: Sophie Chang <sophi...@chromium.org>
      Gerrit-Attention: Matthew Jones <mdj...@chromium.org>
      Gerrit-Comment-Date: Mon, 15 Dec 2025 22:40:05 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Yuheng Huang (Gerrit)

      unread,
      Dec 15, 2025, 5:40:30 PM (14 hours ago) Dec 15
      to Matthew Jones, Min Qin, Mickey Burks, Chromium LUCI CQ, chromium...@chromium.org, Sophie Chang
      Attention needed from Matthew Jones

      Yuheng Huang voted Commit-Queue+2

      Commit-Queue+2
      Gerrit-Comment-Date: Mon, 15 Dec 2025 22:40:19 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Chromium LUCI CQ (Gerrit)

      unread,
      Dec 15, 2025, 5:44:07 PM (14 hours ago) Dec 15
      to Yuheng Huang, Matthew Jones, Min Qin, Mickey Burks, chromium...@chromium.org, Sophie Chang

      Chromium LUCI CQ submitted the change

      Change information

      Commit message:
      [Contextual tasks] Close side panel if navigate to contextual tasks URL

      Close the side panel when the active tab is navigated to contextual
      tasks URL.
      Bug: 467750003
      Change-Id: I61c88064fa7d06c3aed9470e4008a190add419f8
      Reviewed-by: Matthew Jones <mdj...@chromium.org>
      Reviewed-by: Yuheng Huang <yuh...@chromium.org>
      Commit-Queue: Yuheng Huang <yuh...@chromium.org>
      Cr-Commit-Position: refs/heads/main@{#1559009}
      Files:
      • M chrome/browser/contextual_tasks/contextual_tasks_side_panel_coordinator.cc
      • M chrome/browser/contextual_tasks/contextual_tasks_side_panel_coordinator_interactive_uitest.cc
      • M chrome/browser/contextual_tasks/contextual_tasks_ui_service.cc
      • M chrome/browser/contextual_tasks/contextual_tasks_ui_service.h
      Change size: S
      Delta: 4 files changed, 34 insertions(+), 7 deletions(-)
      Branch: refs/heads/main
      Submit Requirements:
      • requirement satisfiedCode-Review: +1 by Yuheng Huang, +1 by Matthew Jones
      Open in Gerrit
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: merged
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I61c88064fa7d06c3aed9470e4008a190add419f8
      Gerrit-Change-Number: 7257495
      Gerrit-PatchSet: 4
      Gerrit-Owner: Yuheng Huang <yuh...@chromium.org>
      Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
      Gerrit-Reviewer: Matthew Jones <mdj...@chromium.org>
      Gerrit-Reviewer: Yuheng Huang <yuh...@chromium.org>
      open
      diffy
      satisfied_requirement
      Reply all
      Reply to author
      Forward
      0 new messages