Yoshiki IGUCHI (Gerrit)

unread,

Jun 15, 2026, 2:43:47 AM (9 days ago) Jun 15

to Yoshiki IGUCHI, Hidehiko Abe, Chromium LUCI CQ, chromium...@chromium.org, gcasto+w...@chromium.org, rrsilva+wat...@google.com, tbarzi...@chromium.org, vasilii+watchlis...@chromium.org

Attention needed from Hidehiko Abe

Yoshiki IGUCHI added 1 comment

Patchset-level comments

File-level comment, Patchset 8 (Latest):

Yoshiki IGUCHI . resolved

Hidehiko-san, PTAL. Thanks.

Open in Gerrit

Related details

Attention is currently required from:

Hidehiko Abe

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Hidehiko Abe (Gerrit)

unread,

Jun 18, 2026, 2:15:41 AM (6 days ago) Jun 18

to Yoshiki IGUCHI, Chromium LUCI CQ, chromium...@chromium.org, gcasto+w...@chromium.org, rrsilva+wat...@google.com, tbarzi...@chromium.org, vasilii+watchlis...@chromium.org

Attention needed from Yoshiki IGUCHI

Hidehiko Abe voted and added 1 comment

Votes added by Hidehiko Abe

Code-Review

+1

1 comment

File ash/login/resources/login_strings.grd

Line 508, Patchset 8 (Latest):

      <message name="IDS_MARKETING_OPT_IN_ACCESSIBILITY_BUTTON_LABEL" desc="The label of the button which appears at the bottom left of the last OOBE dialog shown to the user on the first login. Clicking the button will show a screen that allows the user to change certain accessibility settings.">

Hidehiko Abe . resolved

I assumed you do not change any contents in this section except moving literally.

Open in Gerrit

Related details

Attention is currently required from:

Yoshiki IGUCHI

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Yoshiki IGUCHI (Gerrit)

unread,

Jun 18, 2026, 3:00:54 AM (6 days ago) Jun 18

to Yoshiki IGUCHI, Hidehiko Abe, Chromium LUCI CQ, chromium...@chromium.org, gcasto+w...@chromium.org, rrsilva+wat...@google.com, tbarzi...@chromium.org, vasilii+watchlis...@chromium.org

Yoshiki IGUCHI voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Jun 18, 2026, 4:11:41 AM (6 days ago) Jun 18

to Yoshiki IGUCHI, Hidehiko Abe, Di Wu, chromium...@chromium.org, gcasto+w...@chromium.org, rrsilva+wat...@google.com, tbarzi...@chromium.org, vasilii+watchlis...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:

ASH Refactoring: Move 47 login-related strings to ash/ (Part 3)

Move 47 login-related strings from chrome/app/chromeos_strings.grdp
to ash/login/resources/login_strings.grd.

Moved strings:
- IDS_DISCOVER_PIN_RESET_DONE_TITLE
- IDS_DISCOVER_PIN_RESET_DONE_TITLE_CHILD
- IDS_DISCOVER_PIN_RESET_SUBTITLE
- IDS_DISCOVER_PIN_RESET_SUBTITLE_CHILD
- IDS_DISCOVER_PIN_RESET_TITLE
- IDS_DISCOVER_PIN_SETUP
- IDS_DISCOVER_PIN_SETUP_DONE
- IDS_DISCOVER_PIN_SETUP_PIN_AS_MAIN_FACTOR_SKIP
- IDS_DISCOVER_PIN_SETUP_PIN_AS_MAIN_FACTOR_SUBTITLE
- IDS_DISCOVER_PIN_SETUP_PIN_AS_MAIN_FACTOR_TITLE
- IDS_DISCOVER_PIN_SETUP_SKIP
- IDS_DISCOVER_PIN_SETUP_SUBTITLE1
- IDS_DISCOVER_PIN_SETUP_SUBTITLE1_CHILD
- IDS_DISCOVER_PIN_SETUP_SUBTITLE3_NO_LOGIN
- IDS_DISCOVER_PIN_SETUP_SUBTITLE3_NO_LOGIN_CHILD
- IDS_DISCOVER_PIN_SETUP_SUBTITLE3_WITH_LOGIN
- IDS_DISCOVER_PIN_SETUP_SUBTITLE3_WITH_LOGIN_CHILD
- IDS_DISCOVER_PIN_SETUP_TITLE1
- IDS_DISCOVER_PIN_SETUP_TITLE1_CHILD
- IDS_DISCOVER_PIN_SETUP_TITLE2
- IDS_DISCOVER_PIN_SETUP_TITLE2_CHILD
- IDS_DISCOVER_PIN_SETUP_TITLE3
- IDS_DISCOVER_PIN_SETUP_TITLE3_CHILD
- IDS_LOCAL_DATA_LOSS_WARNING_POWERWASH_BUTTON
- IDS_LOGIN_CRYPTOHOME_RECOVERY_REAUTH_NOTIFICATION_SUBTITLE
- IDS_LOGIN_CRYPTOHOME_RECOVERY_REAUTH_NOTIFICATION_TITLE
- IDS_LOGIN_CRYPTOHOME_RECOVERY_SETUP_ERROR_SUBTITLE
- IDS_LOGIN_CRYPTOHOME_RECOVERY_SETUP_ERROR_TITLE
- IDS_LOGIN_CRYPTOHOME_RECOVERY_SETUP_RETRY_BUTTON
- IDS_LOGIN_CRYPTOHOME_RECOVERY_SETUP_SKIP_BUTTON
- IDS_LOGIN_PASSWORD_CHANGED_CONTINUE_AND_DELETE_BUTTON
- IDS_LOGIN_PASSWORD_CHANGED_DATA_LOSS_WARNING_SUBTITLE
- IDS_LOGIN_PASSWORD_CHANGED_DATA_LOSS_WARNING_TITLE
- IDS_LOGIN_PASSWORD_CHANGED_FORGOT_OLD_PASSWORD_BUTTON
- IDS_LOGIN_PASSWORD_CHANGED_INCORRECT_OLD_PASSWORD
- IDS_LOGIN_PASSWORD_CHANGED_OLD_PASSWORD_HINT
- IDS_LOGIN_PASSWORD_CHANGED_RECOVER_DATA_SUBTITLE
- IDS_LOGIN_PASSWORD_CHANGED_RECOVER_DATA_TITLE
- IDS_MARKETING_OPT_IN_ACCESSIBILITY_BUTTON_LABEL
- IDS_MARKETING_OPT_IN_ACCESSIBILITY_DONE_BUTTON
- IDS_MARKETING_OPT_IN_ACCESSIBILITY_NAV_BUTTON_SETTING_DESCRIPTION
- IDS_MARKETING_OPT_IN_ACCESSIBILITY_NAV_BUTTON_SETTING_TITLE
- IDS_MARKETING_OPT_IN_ACCESSIBILITY_TITLE
- IDS_PASSWORD_SELECTION_GAIA_PASSWORD_LABEL
- IDS_PASSWORD_SELECTION_LOCAL_PASSWORD_LABEL
- IDS_PASSWORD_SELECTION_SUBTITLE
- IDS_PASSWORD_SELECTION_TITLE

Also move 43 string image files from
chrome/app/chromeos_strings_grdp to ash/login/resources/login_strings_grd.

Bug: 487122295

Test: CQ passes

Skip-Translation-Screenshots-Check: True

Change-Id: Ib14af13d956c85a646078752302404bd276f20ae

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7928612

Reviewed-by: Hidehiko Abe <hide...@chromium.org>

Commit-Queue: Yoshiki IGUCHI <yos...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1648854}

Files:

M ash/login/resources/login_strings.grd
R ash/login/resources/login_strings_grd/IDS_DISCOVER_PIN_RESET_DONE_TITLE.png.sha1
R ash/login/resources/login_strings_grd/IDS_DISCOVER_PIN_RESET_DONE_TITLE_CHILD.png.sha1
R ash/login/resources/login_strings_grd/IDS_DISCOVER_PIN_RESET_SUBTITLE.png.sha1
R ash/login/resources/login_strings_grd/IDS_DISCOVER_PIN_RESET_SUBTITLE_CHILD.png.sha1
R ash/login/resources/login_strings_grd/IDS_DISCOVER_PIN_RESET_TITLE.png.sha1
R ash/login/resources/login_strings_grd/IDS_DISCOVER_PIN_SETUP.png.sha1
R ash/login/resources/login_strings_grd/IDS_DISCOVER_PIN_SETUP_DONE.png.sha1
R ash/login/resources/login_strings_grd/IDS_DISCOVER_PIN_SETUP_PIN_AS_MAIN_FACTOR_SKIP.png.sha1
R ash/login/resources/login_strings_grd/IDS_DISCOVER_PIN_SETUP_PIN_AS_MAIN_FACTOR_SUBTITLE.png.sha1
R ash/login/resources/login_strings_grd/IDS_DISCOVER_PIN_SETUP_PIN_AS_MAIN_FACTOR_TITLE.png.sha1
R ash/login/resources/login_strings_grd/IDS_DISCOVER_PIN_SETUP_SKIP.png.sha1
R ash/login/resources/login_strings_grd/IDS_DISCOVER_PIN_SETUP_SUBTITLE1.png.sha1
R ash/login/resources/login_strings_grd/IDS_DISCOVER_PIN_SETUP_SUBTITLE1_CHILD.png.sha1
R ash/login/resources/login_strings_grd/IDS_DISCOVER_PIN_SETUP_SUBTITLE3_NO_LOGIN_CHILD.png.sha1
R ash/login/resources/login_strings_grd/IDS_DISCOVER_PIN_SETUP_SUBTITLE3_WITH_LOGIN_CHILD.png.sha1
R ash/login/resources/login_strings_grd/IDS_DISCOVER_PIN_SETUP_TITLE1.png.sha1
R ash/login/resources/login_strings_grd/IDS_DISCOVER_PIN_SETUP_TITLE1_CHILD.png.sha1
R ash/login/resources/login_strings_grd/IDS_DISCOVER_PIN_SETUP_TITLE2.png.sha1
R ash/login/resources/login_strings_grd/IDS_DISCOVER_PIN_SETUP_TITLE2_CHILD.png.sha1
R ash/login/resources/login_strings_grd/IDS_DISCOVER_PIN_SETUP_TITLE3.png.sha1
R ash/login/resources/login_strings_grd/IDS_DISCOVER_PIN_SETUP_TITLE3_CHILD.png.sha1
R ash/login/resources/login_strings_grd/IDS_LOCAL_DATA_LOSS_WARNING_POWERWASH_BUTTON.png.sha1
R ash/login/resources/login_strings_grd/IDS_LOGIN_CRYPTOHOME_RECOVERY_REAUTH_NOTIFICATION_SUBTITLE.png.sha1
R ash/login/resources/login_strings_grd/IDS_LOGIN_CRYPTOHOME_RECOVERY_REAUTH_NOTIFICATION_TITLE.png.sha1
R ash/login/resources/login_strings_grd/IDS_LOGIN_CRYPTOHOME_RECOVERY_SETUP_ERROR_SUBTITLE.png.sha1
R ash/login/resources/login_strings_grd/IDS_LOGIN_CRYPTOHOME_RECOVERY_SETUP_ERROR_TITLE.png.sha1
R ash/login/resources/login_strings_grd/IDS_LOGIN_CRYPTOHOME_RECOVERY_SETUP_RETRY_BUTTON.png.sha1
R ash/login/resources/login_strings_grd/IDS_LOGIN_CRYPTOHOME_RECOVERY_SETUP_SKIP_BUTTON.png.sha1
R ash/login/resources/login_strings_grd/IDS_LOGIN_PASSWORD_CHANGED_CONTINUE_AND_DELETE_BUTTON.png.sha1
R ash/login/resources/login_strings_grd/IDS_LOGIN_PASSWORD_CHANGED_DATA_LOSS_WARNING_SUBTITLE.png.sha1
R ash/login/resources/login_strings_grd/IDS_LOGIN_PASSWORD_CHANGED_DATA_LOSS_WARNING_TITLE.png.sha1
R ash/login/resources/login_strings_grd/IDS_LOGIN_PASSWORD_CHANGED_FORGOT_OLD_PASSWORD_BUTTON.png.sha1
R ash/login/resources/login_strings_grd/IDS_LOGIN_PASSWORD_CHANGED_RECOVER_DATA_SUBTITLE.png.sha1
R ash/login/resources/login_strings_grd/IDS_LOGIN_PASSWORD_CHANGED_RECOVER_DATA_TITLE.png.sha1
R ash/login/resources/login_strings_grd/IDS_MARKETING_OPT_IN_ACCESSIBILITY_BUTTON_LABEL.png.sha1
R ash/login/resources/login_strings_grd/IDS_MARKETING_OPT_IN_ACCESSIBILITY_DONE_BUTTON.png.sha1
R ash/login/resources/login_strings_grd/IDS_MARKETING_OPT_IN_ACCESSIBILITY_NAV_BUTTON_SETTING_DESCRIPTION.png.sha1
R ash/login/resources/login_strings_grd/IDS_MARKETING_OPT_IN_ACCESSIBILITY_NAV_BUTTON_SETTING_TITLE.png.sha1
R ash/login/resources/login_strings_grd/IDS_MARKETING_OPT_IN_ACCESSIBILITY_TITLE.png.sha1
R ash/login/resources/login_strings_grd/IDS_PASSWORD_SELECTION_GAIA_PASSWORD_LABEL.png.sha1
R ash/login/resources/login_strings_grd/IDS_PASSWORD_SELECTION_LOCAL_PASSWORD_LABEL.png.sha1
R ash/login/resources/login_strings_grd/IDS_PASSWORD_SELECTION_SUBTITLE.png.sha1
R ash/login/resources/login_strings_grd/IDS_PASSWORD_SELECTION_TITLE.png.sha1
M chrome/app/chromeos_strings.grdp
M chrome/browser/ash/login/screens/pin_setup_screen_browsertest.cc
M chrome/browser/ui/webui/ash/lock_screen_reauth/BUILD.gn
M chrome/browser/ui/webui/ash/lock_screen_reauth/lock_screen_start_reauth_ui.cc
M chrome/browser/ui/webui/ash/login/cryptohome_recovery_screen_handler.cc
M chrome/browser/ui/webui/ash/login/cryptohome_recovery_setup_screen_handler.cc
M chrome/browser/ui/webui/ash/login/enter_old_password_screen_handler.cc
M chrome/browser/ui/webui/ash/login/osauth/BUILD.gn
M chrome/browser/ui/webui/ash/login/osauth/local_data_loss_warning_screen_handler.cc
M chrome/browser/ui/webui/ash/login/password_selection_screen_handler.cc
M chrome/browser/ui/webui/ash/login/pin_setup_screen_handler.cc

Change size: L

Delta: 55 files changed, 153 insertions(+), 146 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Hidehiko Abe

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

ASH Refactoring: Move 47 login-related strings to ash/ (Part 3) [chromium/src : main]

Yoshiki IGUCHI (Gerrit)

Yoshiki IGUCHI added 1 comment

Related details

Hidehiko Abe (Gerrit)

Hidehiko Abe voted and added 1 comment

Votes added by Hidehiko Abe

1 comment

Related details

Yoshiki IGUCHI (Gerrit)

Yoshiki IGUCHI voted Commit-Queue+2

Related details

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change

Change information