[FedCM] More Auth naming removals [chromium/src : main]
Nicolás Peña (Gerrit)
Nicolás Peña voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
- Yi Gu
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yi Gu (Gerrit)
Yi Gu added 7 comments![]( "Open in Gerrit")
BuildFederatedAuthRequestIssue(function name needs to be updated
auto federated_auth_request_details =needs rename too
using RequestCallbackHelper = content::FederatedRequestTokenCallbackHelper;Why do some of these `using` outside of the content::webid namespace?
std::unique_ptr<RequestCallbackHelper> auth_helper_;request_helper_?
optional FederatedRequestIssueDetails federatedRequestIssueDetailsWill leave this change review to the owner. IIRC there's some frontend code'file that needs to be updated as well. Not sure if the autoroller can handle the rename smoothly or we need to support both the old and the new for some time.
FederatedRequestIssueDetails? federated_auth_request_details;ditto
Related details
- Nicolás Peña
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nicolás Peña (Gerrit)
Nicolás Peña voted and added 7 comments![]( "Open in Gerrit")
Votes added by Nicolás Peña
| Commit-Queue | +1 |
7 comments
+alexrudenko for devtools_instrumentation.cc and Audits.pdl
+rakina for test_render_frame_host.cc
+icp reviewer for inspector_issue.mojom
function name needs to be updated
Done
auto federated_auth_request_details =Nicolás Peñaneeds rename too
Done
.SetFederatedAuthRequestIssueReason(Nicolás Peñathis one too?
Done
using RequestCallbackHelper = content::FederatedRequestTokenCallbackHelper;Why do some of these `using` outside of the content::webid namespace?
They were like this before. I don't know if it makes any difference? I can move them to the inner namespace, but unrelated to this CL so not right now.
std::unique_ptr<RequestCallbackHelper> auth_helper_;Nicolás Peñarequest_helper_?
Yea this file needs a lot of renames, defer to the other CL (already sent for review)
FederatedRequestIssueDetails? federated_auth_request_details;Nicolás Peñaditto
Done
Related details
- Alex Rudenko
- Chromium IPC Reviews
- Rakina Zata Amni
- Yi Gu
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alex Rudenko (Gerrit)
Alex Rudenko added 1 comment![]( "Open in Gerrit")
optional FederatedRequestIssueDetails federatedRequestIssueDetailsWill leave this change review to the owner. IIRC there's some frontend code'file that needs to be updated as well. Not sure if the autoroller can handle the rename smoothly or we need to support both the old and the new for some time.
I think it might cause build issue that would need to be solved by the gardener when the change rolls into DevTools.
Related details
- Chromium IPC Reviews
- Nicolás Peña
gwsq (Gerrit)
Message from gwsq![]( "Open in Gerrit")
From googleclient/chrome/chromium_gwsq/ipc/config.gwsq:
IPC: ke...@chromium.org
📎 It looks like you’re making a possibly security-sensitive change! 📎 IPC security review isn’t a rubberstamp, so your friendly security reviewer will need a fair amount of context to review your CL effectively. Please review your CL description and code comments to make sure they provide context for someone unfamiliar with your project/area. Pay special attention to where data comes from and which processes it flows between (and their privilege levels). Feel free to point your security reviewer at design docs, bugs, or other links if you can’t reasonably make a self-contained CL description. (Also see https://cbea.ms/git-commit/).
IPC reviewer(s): ke...@chromium.org
Reviewer source(s):
ke...@chromium.org is from context(googleclient/chrome/chromium_gwsq/ipc/config.gwsq)
Related details
- Ken Buchanan
- Nicolás Peña
- Rakina Zata Amni
- Yi Gu
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ken Buchanan (Gerrit)
Ken Buchanan voted and added 1 comment![]( "Open in Gerrit")
Votes added by Ken Buchanan
| Code-Review | +1 |
1 comment
- Nicolás Peña
- Rakina Zata Amni
- Yi Gu
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nicolás Peña (Gerrit)
Nicolás Peña voted and added 1 comment![]( "Open in Gerrit")
Votes added by Nicolás Peña
| Commit-Queue | +1 |
1 comment
optional FederatedRequestIssueDetails federatedRequestIssueDetailsAlex RudenkoWill leave this change review to the owner. IIRC there's some frontend code'file that needs to be updated as well. Not sure if the autoroller can handle the rename smoothly or we need to support both the old and the new for some time.
I think it might cause build issue that would need to be solved by the gardener when the change rolls into DevTools.
Okay, fair enough. In that case I take back the Audits.pdl changes 😊 it's not worth the churn just for a cosmetic improvement IMO. PTAL
Related details
- Alex Rudenko
- Ken Buchanan
- Rakina Zata Amni
- Yi Gu
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nicolás Peña (Gerrit)
Nicolás Peña added 1 comment![]( "Open in Gerrit")
Looks like Ken can give me approvals for test_render_frame_host.cc and Alex can for devtools_instrumentation, so removing rakina from reviewer
Related details
- Alex Rudenko
- Ken Buchanan
- Yi Gu
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alex Rudenko (Gerrit)
Alex Rudenko voted Code-Review+1![]( "Open in Gerrit")
- Ken Buchanan
- Nicolás Peña
- Yi Gu
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ken Buchanan (Gerrit)
Ken Buchanan voted and added 1 comment![]( "Open in Gerrit")
Votes added by Ken Buchanan
| Code-Review | +1 |
1 comment
- Nicolás Peña
- Yi Gu
Nicolás Peña (Gerrit)
Nicolás Peña voted and added 1 comment![]( "Open in Gerrit")
Votes added by Nicolás Peña
| Commit-Queue | +1 |
1 comment
Christian, can you take a look since Yi is out today?
Related details
- Christian Biesinger
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |