[a11y] Prevent incorrect text edit reporting for spin buttons on macOS. [chromium/src : main]

0 views
Skip to first unread message

Carlos Marcelo Barrera Nolasco (Gerrit)

unread,
Mar 20, 2026, 5:08:34 PM (4 days ago) Mar 20
to Chromium LUCI CQ, chromium...@chromium.org, (Julie)Jeongeun Kim, Kevin Babbitt, abigailbk...@google.com, dtseng...@chromium.org, francisjp...@google.com, josiah...@chromium.org, kyungjunle...@google.com, lucasrada...@google.com, mac-r...@chromium.org, nektar...@chromium.org, yuzo+...@chromium.org
Attention needed from Carlos Marcelo Barrera Nolasco

Message from Carlos Marcelo Barrera Nolasco

Set Ready For Review

Open in Gerrit

Related details

Attention is currently required from:
  • Carlos Marcelo Barrera Nolasco
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ie505aacbf63ae3fe0b12515c2914a0a4433b54cb
Gerrit-Change-Number: 7689054
Gerrit-PatchSet: 1
Gerrit-Owner: Carlos Marcelo Barrera Nolasco <carlos...@google.com>
Gerrit-Reviewer: Carlos Marcelo Barrera Nolasco <carlos...@google.com>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
Gerrit-Attention: Carlos Marcelo Barrera Nolasco <carlos...@google.com>
Gerrit-Comment-Date: Fri, 20 Mar 2026 21:08:25 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Joanmarie Diggs (Gerrit)

unread,
Mar 21, 2026, 2:09:41 AM (3 days ago) Mar 21
to Carlos Marcelo Barrera Nolasco, David Tseng, Abigail Klein, Chromium LUCI CQ, chromium...@chromium.org, (Julie)Jeongeun Kim, Kevin Babbitt, abigailbk...@google.com, dtseng...@chromium.org, francisjp...@google.com, josiah...@chromium.org, kyungjunle...@google.com, lucasrada...@google.com, mac-r...@chromium.org, nektar...@chromium.org, yuzo+...@chromium.org
Attention needed from Abigail Klein, Carlos Marcelo Barrera Nolasco and David Tseng

Joanmarie Diggs added 1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Joanmarie Diggs . unresolved

I'm afraid I cannot view the bug or the videos due to access restriction.

Having said that, did you also test to be sure that legitimate text edits and selection changes continue to be reported, such as arrowing left/right, selecting/unselecting text via keyboard navigation, using backspace/delete, typing new values, etc.?

Open in Gerrit

Related details

Attention is currently required from:
  • Abigail Klein
  • Carlos Marcelo Barrera Nolasco
  • David Tseng
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ie505aacbf63ae3fe0b12515c2914a0a4433b54cb
    Gerrit-Change-Number: 7689054
    Gerrit-PatchSet: 1
    Gerrit-Owner: Carlos Marcelo Barrera Nolasco <carlos...@google.com>
    Gerrit-Reviewer: Abigail Klein <abigai...@google.com>
    Gerrit-Reviewer: Carlos Marcelo Barrera Nolasco <carlos...@google.com>
    Gerrit-Reviewer: David Tseng <dts...@chromium.org>
    Gerrit-Reviewer: Joanmarie Diggs <jdi...@igalia.com>
    Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
    Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
    Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
    Gerrit-Attention: Carlos Marcelo Barrera Nolasco <carlos...@google.com>
    Gerrit-Attention: Abigail Klein <abigai...@google.com>
    Gerrit-Attention: David Tseng <dts...@chromium.org>
    Gerrit-Comment-Date: Sat, 21 Mar 2026 06:09:24 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    David Tseng (Gerrit)

    unread,
    Mar 23, 2026, 1:02:36 PM (24 hours ago) Mar 23
    to Carlos Marcelo Barrera Nolasco, Abigail Klein, Joanmarie Diggs, Chromium LUCI CQ, chromium...@chromium.org, (Julie)Jeongeun Kim, Kevin Babbitt, abigailbk...@google.com, dtseng...@chromium.org, francisjp...@google.com, josiah...@chromium.org, kyungjunle...@google.com, lucasrada...@google.com, mac-r...@chromium.org, nektar...@chromium.org, yuzo+...@chromium.org
    Attention needed from Abigail Klein and Carlos Marcelo Barrera Nolasco

    David Tseng added 1 comment

    File ui/accessibility/platform/browser_accessibility_cocoa.mm
    Line 1036, Patchset 1 (Latest): // If the node is an <input type="number"> (identified as a spin button) and
    David Tseng . unresolved
    I haven't dug into the history of when the surrounding code landed, but 
      // TODO(nektar) Remove this once editing intents are implemented,
      // and the actual inserted and deleted text is passed over from Blink.

    is really the right way to do this.

    Many editing intents did land (see
    u/a/mojom/ax_event_intent.mojom
     u/a/ax_enums.mojom
    ).

    We should be able to do a bit better e.g. detect value or selection changes based on typing vs insertions by Blink. I don't think we pass over the inserted, deleted text though, but should at least be able to know if the text was inserted/deleted as opposed to typed.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Abigail Klein
    • Carlos Marcelo Barrera Nolasco
    Gerrit-Comment-Date: Mon, 23 Mar 2026 17:02:29 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Abigail Klein (Gerrit)

    unread,
    11:28 AM (1 hour ago) 11:28 AM
    to Carlos Marcelo Barrera Nolasco, David Tseng, Joanmarie Diggs, Chromium LUCI CQ, chromium...@chromium.org, (Julie)Jeongeun Kim, Kevin Babbitt, abigailbk...@google.com, dtseng...@chromium.org, francisjp...@google.com, josiah...@chromium.org, kyungjunle...@google.com, lucasrada...@google.com, mac-r...@chromium.org, nektar...@chromium.org, yuzo+...@chromium.org
    Attention needed from Carlos Marcelo Barrera Nolasco

    Abigail Klein added 1 comment

    Patchset-level comments
    Abigail Klein . resolved

    Removing myself from reviewer, David has it covered :)

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Carlos Marcelo Barrera Nolasco
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ie505aacbf63ae3fe0b12515c2914a0a4433b54cb
    Gerrit-Change-Number: 7689054
    Gerrit-PatchSet: 1
    Gerrit-Owner: Carlos Marcelo Barrera Nolasco <carlos...@google.com>
    Gerrit-Reviewer: Carlos Marcelo Barrera Nolasco <carlos...@google.com>
    Gerrit-Reviewer: David Tseng <dts...@chromium.org>
    Gerrit-Reviewer: Joanmarie Diggs <jdi...@igalia.com>
    Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
    Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
    Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
    Gerrit-Attention: Carlos Marcelo Barrera Nolasco <carlos...@google.com>
    Gerrit-Comment-Date: Tue, 24 Mar 2026 15:28:36 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages