Set BNPL 2nd line string update to 100% Chrome Stable [chromium/src : main]

0 views
Skip to first unread message

Vinny Persky (Gerrit)

unread,
6:24 PM (2 hours ago) 6:24 PM
to Wilson Low, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, armalhotra+a...@google.com, browser-comp...@chromium.org, osaul+aut...@google.com, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, vinnypersky+...@google.com
Attention needed from Wilson Low

Vinny Persky voted and added 1 comment

Votes added by Vinny Persky

Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 8 (Latest):
Vinny Persky . resolved

Hi Wilson,

PTAL! Thanks

Open in Gerrit

Related details

Attention is currently required from:
  • Wilson Low
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I0502af28a60687f38dfc5267943de02644374815
Gerrit-Change-Number: 7487650
Gerrit-PatchSet: 8
Gerrit-Owner: Vinny Persky <vinny...@google.com>
Gerrit-Reviewer: Vinny Persky <vinny...@google.com>
Gerrit-Reviewer: Wilson Low <wils...@google.com>
Gerrit-Attention: Wilson Low <wils...@google.com>
Gerrit-Comment-Date: Thu, 15 Jan 2026 23:24:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Wilson Low (Gerrit)

unread,
6:33 PM (2 hours ago) 6:33 PM
to Vinny Persky, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, armalhotra+a...@google.com, browser-comp...@chromium.org, osaul+aut...@google.com, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, vinnypersky+...@google.com
Attention needed from Vinny Persky

Wilson Low voted and added 1 comment

Votes added by Wilson Low

Code-Review+1

1 comment

Patchset-level comments
Wilson Low . resolved

LGTM! (assuming CQ passes w/o test failures)

Open in Gerrit

Related details

Attention is currently required from:
  • Vinny Persky
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I0502af28a60687f38dfc5267943de02644374815
    Gerrit-Change-Number: 7487650
    Gerrit-PatchSet: 8
    Gerrit-Owner: Vinny Persky <vinny...@google.com>
    Gerrit-Reviewer: Vinny Persky <vinny...@google.com>
    Gerrit-Reviewer: Wilson Low <wils...@google.com>
    Gerrit-Attention: Vinny Persky <vinny...@google.com>
    Gerrit-Comment-Date: Thu, 15 Jan 2026 23:33:41 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Wilson Low (Gerrit)

    unread,
    6:39 PM (2 hours ago) 6:39 PM
    to Vinny Persky, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, armalhotra+a...@google.com, browser-comp...@chromium.org, osaul+aut...@google.com, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, vinnypersky+...@google.com
    Attention needed from Vinny Persky

    Wilson Low voted and added 1 comment

    Votes added by Wilson Low

    Code-Review+0

    1 comment

    Patchset-level comments
    Wilson Low . unresolved

    LGTM! (assuming CQ passes w/o test failures)

    Wilson Low

    Actually based on preliminary results it looks like unittests `PaymentsSuggestionGeneratorBnplTest.MaybeUpdateDesktopSuggestionsWithBnpl`
    and `PaymentsSuggestionGeneratorBnplTest.MaybeUpdateDesktopSuggestionsWithBnpl_SuggestionListWithBnplInserted` might also need to be updated for Android OS

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Vinny Persky
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedNo-Unresolved-Comments
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I0502af28a60687f38dfc5267943de02644374815
      Gerrit-Change-Number: 7487650
      Gerrit-PatchSet: 8
      Gerrit-Owner: Vinny Persky <vinny...@google.com>
      Gerrit-Reviewer: Vinny Persky <vinny...@google.com>
      Gerrit-Reviewer: Wilson Low <wils...@google.com>
      Gerrit-Attention: Vinny Persky <vinny...@google.com>
      Gerrit-Comment-Date: Thu, 15 Jan 2026 23:38:56 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      Comment-In-Reply-To: Wilson Low <wils...@google.com>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Vinny Persky (Gerrit)

      unread,
      6:52 PM (2 hours ago) 6:52 PM
      to Wilson Low, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, armalhotra+a...@google.com, browser-comp...@chromium.org, osaul+aut...@google.com, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, vinnypersky+...@google.com
      Attention needed from Wilson Low

      Vinny Persky added 1 comment

      Patchset-level comments
      Wilson Low . unresolved

      LGTM! (assuming CQ passes w/o test failures)

      Wilson Low

      Actually based on preliminary results it looks like unittests `PaymentsSuggestionGeneratorBnplTest.MaybeUpdateDesktopSuggestionsWithBnpl`
      and `PaymentsSuggestionGeneratorBnplTest.MaybeUpdateDesktopSuggestionsWithBnpl_SuggestionListWithBnplInserted` might also need to be updated for Android OS

      Vinny Persky

      Yep.. We shouldnt be running desktop tests on android. Let me try to fix this buildflags in this file

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Wilson Low
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedNo-Unresolved-Comments
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I0502af28a60687f38dfc5267943de02644374815
      Gerrit-Change-Number: 7487650
      Gerrit-PatchSet: 10
      Gerrit-Owner: Vinny Persky <vinny...@google.com>
      Gerrit-Reviewer: Vinny Persky <vinny...@google.com>
      Gerrit-Reviewer: Wilson Low <wils...@google.com>
      Gerrit-Attention: Wilson Low <wils...@google.com>
      Gerrit-Comment-Date: Thu, 15 Jan 2026 23:52:16 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Wilson Low <wils...@google.com>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy
      Reply all
      Reply to author
      Forward
      0 new messages