ash: Add //chrome/browser/ash/first_run/BUILD.gn [chromium/src : main]

0 views
Skip to first unread message

Eriko Kurimoto (Gerrit)

unread,
Jul 1, 2024, 9:18:15 AMJul 1
to Kyle Horimoto, Chromium LUCI CQ, chromium...@chromium.org, blundell+...@chromium.org
Attention needed from Kyle Horimoto

Eriko Kurimoto added 1 comment

Patchset-level comments
File-level comment, Patchset 4 (Latest):
Eriko Kurimoto . resolved

PTAL

Open in Gerrit

Related details

Attention is currently required from:
  • Kyle Horimoto
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ie87d955eb185cb054c1dfb869740fd4c9b1c3759
Gerrit-Change-Number: 5669882
Gerrit-PatchSet: 4
Gerrit-Owner: Eriko Kurimoto <elk...@chromium.org>
Gerrit-Reviewer: Eriko Kurimoto <elk...@chromium.org>
Gerrit-Reviewer: Kyle Horimoto <khor...@chromium.org>
Gerrit-Attention: Kyle Horimoto <khor...@chromium.org>
Gerrit-Comment-Date: Mon, 01 Jul 2024 13:17:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Kyle Horimoto (Gerrit)

unread,
Jul 1, 2024, 5:23:57 PMJul 1
to Eriko Kurimoto, Kyle Horimoto, Chromium LUCI CQ, chromium...@chromium.org, blundell+...@chromium.org
Attention needed from Eriko Kurimoto

Kyle Horimoto voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Eriko Kurimoto
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ie87d955eb185cb054c1dfb869740fd4c9b1c3759
Gerrit-Change-Number: 5669882
Gerrit-PatchSet: 4
Gerrit-Owner: Eriko Kurimoto <elk...@chromium.org>
Gerrit-Reviewer: Eriko Kurimoto <elk...@chromium.org>
Gerrit-Reviewer: Kyle Horimoto <khor...@chromium.org>
Gerrit-Attention: Eriko Kurimoto <elk...@chromium.org>
Gerrit-Comment-Date: Mon, 01 Jul 2024 21:23:43 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Jul 2, 2024, 3:01:18 AMJul 2
to Eriko Kurimoto, Kyle Horimoto, chromium...@chromium.org, blundell+...@chromium.org

Chromium LUCI CQ submitted the change with unreviewed changes

Unreviewed changes

4 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.

Change information

Commit message:
ash: Add //chrome/browser/ash/first_run/BUILD.gn
Bug: b:335293802
Change-Id: Ie87d955eb185cb054c1dfb869740fd4c9b1c3759
Reviewed-by: Kyle Horimoto <khor...@chromium.org>
Commit-Queue: Eriko Kurimoto <elk...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1322028}
Files:
  • M chrome/browser/BUILD.gn
  • M chrome/browser/ash/BUILD.gn
  • A chrome/browser/ash/first_run/BUILD.gn
  • M chrome/browser/ash/system_web_apps/apps/help_app/BUILD.gn
Change size: M
Delta: 4 files changed, 47 insertions(+), 3 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Kyle Horimoto
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ie87d955eb185cb054c1dfb869740fd4c9b1c3759
Gerrit-Change-Number: 5669882
Gerrit-PatchSet: 6
Gerrit-Owner: Eriko Kurimoto <elk...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Eriko Kurimoto <elk...@chromium.org>
Gerrit-Reviewer: Kyle Horimoto <khor...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages