[Mac] Fix Services menu appearance in contextual menus [chromium/src : main]

0 views

Skip to first unread message

Avi Drissman (Gerrit)

unread,

Jan 9, 2026, 10:39:56 AM (yesterday) Jan 9

to liang zeng, Yuanjun Zhu, Avi Drissman, Chromium LUCI CQ, chromium...@chromium.org, mac-r...@chromium.org

Attention needed from Yuanjun Zhu and liang zeng

Avi Drissman added 1 comment

File chrome/browser/ui/cocoa/renderer_context_menu/chrome_swizzle_services_menu_updater.mm

Line 37, Patchset 1 (Latest):- (void)plugMenu:(NSMenu*)menu intoMenu:(NSMenu*)parentMenu;

Avi Drissman . unresolved

In macOS 14, Apple rebuilt menus for macOS using Cocoa. In macOS 13 and earlier, there’s only `-plugMenu:intoMenuRef:`, but in macOS 14+ there’s now also `-plugMenu:intoMenu:`. This CL only swizzles the latter.

Do we see this bug in macOS 13 and earlier? If so, we’ll likely also need to swizzle that other method. If not, we should document this.

Open in Gerrit

Related details

Attention is currently required from:

Yuanjun Zhu
liang zeng

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

liang zeng (Gerrit)

unread,

Jan 9, 2026, 9:40:03 PM (19 hours ago) Jan 9

to Yuanjun Zhu, Avi Drissman, Chromium LUCI CQ, chromium...@chromium.org, mac-r...@chromium.org

Attention needed from Avi Drissman and Yuanjun Zhu

liang zeng added 1 comment

File chrome/browser/ui/cocoa/renderer_context_menu/chrome_swizzle_services_menu_updater.mm

Line 37, Patchset 1:- (void)plugMenu:(NSMenu*)menu intoMenu:(NSMenu*)parentMenu;

Avi Drissman . resolved

In macOS 14, Apple rebuilt menus for macOS using Cocoa. In macOS 13 and earlier, there’s only `-plugMenu:intoMenuRef:`, but in macOS 14+ there’s now also `-plugMenu:intoMenu:`. This CL only swizzles the latter.
Do we see this bug in macOS 13 and earlier? If so, we’ll likely also need to swizzle that other method. If not, we should document this.

liang zeng

Thank you @avi, I tested it in macOS 12/13 and didn't find this bug, but I can reproduce it in macOS 14 and later. Updated the changes to skip swizzling `plugMenu:intoMenu` method in old versions and added more comments.