Remove Plugin VM settings pages [chromium/src : main]

0 views
Skip to first unread message

Timothy Loh (Gerrit)

unread,
Jun 22, 2026, 5:55:41 AM (3 days ago) Jun 22
to CrOS Settings Reviews, Chromium LUCI CQ, chromium...@chromium.org, croissant-...@chromium.org, cros-setti...@google.com, crost...@chromium.org, oshima...@chromium.org, rrsilva+wat...@google.com
Attention needed from CrOS Settings Reviews

Timothy Loh voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • CrOS Settings Reviews
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ia862223e3e665a903f6bf10a8c2f175c7717de64
Gerrit-Change-Number: 7976500
Gerrit-PatchSet: 4
Gerrit-Owner: Timothy Loh <tim...@chromium.org>
Gerrit-Reviewer: CrOS Settings Reviews <cros-setti...@google.com>
Gerrit-Reviewer: Timothy Loh <tim...@chromium.org>
Gerrit-Attention: CrOS Settings Reviews <cros-setti...@google.com>
Gerrit-Comment-Date: Mon, 22 Jun 2026 09:55:16 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

gwsq (Gerrit)

unread,
Jun 22, 2026, 5:58:13 AM (3 days ago) Jun 22
to Timothy Loh, CrOS Settings Reviews, Tao Wu, Chromium LUCI CQ, chromium...@chromium.org, croissant-...@chromium.org, cros-setti...@google.com, crost...@chromium.org, oshima...@chromium.org, rrsilva+wat...@google.com
Attention needed from Tao Wu

Message from gwsq

Reviewer source(s):
wutao is from context(chrome/chromeos/assistant/assistive.gwsq)

Open in Gerrit

Related details

Attention is currently required from:
  • Tao Wu
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ia862223e3e665a903f6bf10a8c2f175c7717de64
Gerrit-Change-Number: 7976500
Gerrit-PatchSet: 4
Gerrit-Owner: Timothy Loh <tim...@chromium.org>
Gerrit-Reviewer: Tao Wu <wu...@chromium.org>
Gerrit-Reviewer: Timothy Loh <tim...@chromium.org>
Gerrit-CC: CrOS Settings Reviews <cros-setti...@google.com>
Gerrit-CC: gwsq
Gerrit-Attention: Tao Wu <wu...@chromium.org>
Gerrit-Comment-Date: Mon, 22 Jun 2026 09:57:52 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Timothy Loh (Gerrit)

unread,
Jun 22, 2026, 6:01:09 AM (3 days ago) Jun 22
to maciek swiech, CrOS Settings Reviews, Tao Wu, Chromium LUCI CQ, chromium...@chromium.org, croissant-...@chromium.org, cros-setti...@google.com, crost...@chromium.org, oshima...@chromium.org, rrsilva+wat...@google.com
Attention needed from Tao Wu

Timothy Loh added 1 comment

Patchset-level comments
File-level comment, Patchset 4 (Latest):
Timothy Loh . resolved

(cc-ing maciek fyi)

Open in Gerrit

Related details

Attention is currently required from:
  • Tao Wu
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ia862223e3e665a903f6bf10a8c2f175c7717de64
Gerrit-Change-Number: 7976500
Gerrit-PatchSet: 4
Gerrit-Owner: Timothy Loh <tim...@chromium.org>
Gerrit-Reviewer: Tao Wu <wu...@chromium.org>
Gerrit-Reviewer: Timothy Loh <tim...@chromium.org>
Gerrit-CC: CrOS Settings Reviews <cros-setti...@google.com>
Gerrit-CC: gwsq
Gerrit-CC: maciek swiech <drmas...@google.com>
Gerrit-Attention: Tao Wu <wu...@chromium.org>
Gerrit-Comment-Date: Mon, 22 Jun 2026 10:00:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Tao Wu (Gerrit)

unread,
9:31 PM (2 hours ago) 9:31 PM
to Timothy Loh, Code Review Nudger, maciek swiech, CrOS Settings Reviews, Chromium LUCI CQ, chromium...@chromium.org, croissant-...@chromium.org, cros-setti...@google.com, crost...@chromium.org, oshima...@chromium.org, rrsilva+wat...@google.com
Attention needed from Timothy Loh

Tao Wu voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Timothy Loh
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ia862223e3e665a903f6bf10a8c2f175c7717de64
Gerrit-Change-Number: 7976500
Gerrit-PatchSet: 4
Gerrit-Owner: Timothy Loh <tim...@chromium.org>
Gerrit-Reviewer: Tao Wu <wu...@chromium.org>
Gerrit-Reviewer: Timothy Loh <tim...@chromium.org>
Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>
Gerrit-CC: CrOS Settings Reviews <cros-setti...@google.com>
Gerrit-CC: gwsq
Gerrit-CC: maciek swiech <drmas...@google.com>
Gerrit-Attention: Timothy Loh <tim...@chromium.org>
Gerrit-Comment-Date: Thu, 25 Jun 2026 01:30:50 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Timothy Loh (Gerrit)

unread,
9:55 PM (1 hour ago) 9:55 PM
to Tao Wu, Code Review Nudger, maciek swiech, CrOS Settings Reviews, Chromium LUCI CQ, chromium...@chromium.org, croissant-...@chromium.org, cros-setti...@google.com, crost...@chromium.org, oshima...@chromium.org, rrsilva+wat...@google.com

Timothy Loh voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ia862223e3e665a903f6bf10a8c2f175c7717de64
Gerrit-Change-Number: 7976500
Gerrit-PatchSet: 4
Gerrit-Owner: Timothy Loh <tim...@chromium.org>
Gerrit-Reviewer: Tao Wu <wu...@chromium.org>
Gerrit-Reviewer: Timothy Loh <tim...@chromium.org>
Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>
Gerrit-CC: CrOS Settings Reviews <cros-setti...@google.com>
Gerrit-CC: gwsq
Gerrit-CC: maciek swiech <drmas...@google.com>
Gerrit-Comment-Date: Thu, 25 Jun 2026 01:54:30 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
10:56 PM (21 minutes ago) 10:56 PM
to Timothy Loh, Tao Wu, Code Review Nudger, maciek swiech, CrOS Settings Reviews, chromium...@chromium.org, croissant-...@chromium.org, cros-setti...@google.com, crost...@chromium.org, oshima...@chromium.org, rrsilva+wat...@google.com

Chromium LUCI CQ submitted the change

Change information

Commit message:
Remove Plugin VM settings pages

The Plugin VM feature has reached EOL.
Bug: 526483959
Change-Id: Ia862223e3e665a903f6bf10a8c2f175c7717de64
Reviewed-by: Tao Wu <wu...@chromium.org>
Commit-Queue: Timothy Loh <tim...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1652142}
Files:
  • M chrome/app/os_settings_strings.grdp
  • D chrome/app/os_settings_strings_grdp/IDS_SETTINGS_APPS_PLUGIN_VM_PERMISSION_DIALOG_CAMERA_LABEL.png.sha1
  • D chrome/app/os_settings_strings_grdp/IDS_SETTINGS_APPS_PLUGIN_VM_PERMISSION_DIALOG_MICROPHONE_LABEL.png.sha1
  • D chrome/app/os_settings_strings_grdp/IDS_SETTINGS_APPS_PLUGIN_VM_PERMISSION_DIALOG_RELAUNCH_BUTTON.png.sha1
  • D chrome/app/os_settings_strings_grdp/IDS_SETTINGS_APPS_PLUGIN_VM_SHARED_PATHS_INSTRUCTIONS_LOCATE.png.sha1
  • D chrome/app/os_settings_strings_grdp/IDS_SETTINGS_APPS_PLUGIN_VM_SHARED_PATHS_REMOVE_FAILURE_DIALOG_MESSAGE.png.sha1
  • D chrome/app/os_settings_strings_grdp/IDS_SETTINGS_APPS_PLUGIN_VM_SHARED_USB_DEVICES_DESCRIPTION.png.sha1
  • M chrome/browser/resources/ash/settings/BUILD.gn
  • M chrome/browser/resources/ash/settings/common/load_time_booleans.ts
  • M chrome/browser/resources/ash/settings/guest_os/guest_os_browser_proxy.ts
  • M chrome/browser/resources/ash/settings/guest_os/guest_os_shared_paths.ts
  • M chrome/browser/resources/ash/settings/guest_os/guest_os_shared_usb_devices.ts
  • M chrome/browser/resources/ash/settings/lazy_load.ts
  • M chrome/browser/resources/ash/settings/os_apps_page/app_management_page/app_detail_view.ts
  • M chrome/browser/resources/ash/settings/os_apps_page/app_management_page/app_item.ts
  • D chrome/browser/resources/ash/settings/os_apps_page/app_management_page/plugin_vm_page/plugin_vm_browser_proxy.ts
  • D chrome/browser/resources/ash/settings/os_apps_page/app_management_page/plugin_vm_page/plugin_vm_detail_view.html
  • D chrome/browser/resources/ash/settings/os_apps_page/app_management_page/plugin_vm_page/plugin_vm_detail_view.ts
  • M chrome/browser/resources/ash/settings/os_apps_page/os_apps_page.html
  • M chrome/browser/resources/ash/settings/os_apps_page/os_apps_page.ts
  • M chrome/browser/resources/ash/settings/os_settings.ts
  • M chrome/browser/resources/ash/settings/os_settings_routes.ts
  • M chrome/browser/ui/webui/ash/settings/pages/apps/BUILD.gn
  • M chrome/browser/ui/webui/ash/settings/pages/apps/apps_section.cc
  • M chrome/browser/ui/webui/ash/settings/pages/apps/apps_section.h
  • D chrome/browser/ui/webui/ash/settings/pages/apps/plugin_vm_handler.cc
  • D chrome/browser/ui/webui/ash/settings/pages/apps/plugin_vm_handler.h
  • M chrome/test/data/webui/chromeos/settings/BUILD.gn
  • M chrome/test/data/webui/chromeos/settings/guest_os/guest_os_shared_paths_test.ts
  • M chrome/test/data/webui/chromeos/settings/guest_os/guest_os_shared_usb_devices_test.ts
  • D chrome/test/data/webui/chromeos/settings/os_apps_page/app_management_page/plugin_vm_detail_view_test.ts
  • D chrome/test/data/webui/chromeos/settings/os_apps_page/app_management_page/test_plugin_vm_browser_proxy.ts
  • M chrome/test/data/webui/chromeos/settings/os_settings_browsertest.cc
Change size: L
Delta: 33 files changed, 20 insertions(+), 800 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Tao Wu
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ia862223e3e665a903f6bf10a8c2f175c7717de64
Gerrit-Change-Number: 7976500
Gerrit-PatchSet: 5
Gerrit-Owner: Timothy Loh <tim...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Tao Wu <wu...@chromium.org>
Gerrit-Reviewer: Timothy Loh <tim...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages