Revert "The candidate position can also as a child node of the editing_root" [chromium/src : main]
0 views
Skip to first unread message
Shweta Bindal (Gerrit)
Jan 12, 2026, 5:46:17 AM (2 days ago) Jan 12
to Chromium LUCI CQ, Peng Zhou, Kent Tamura, chromium...@chromium.org
Attention needed from Kent Tamura and Peng Zhou
Shweta Bindal has uploaded the change for review![]( "Open in Gerrit")
Shweta Bindal would like Chromium LUCI CQ, Peng Zhou and Kent Tamura to review this change.
Commit message
Revert "The candidate position can also as a child node of the editing_root"
This reverts commit bc351d7210f9c09cf981aa96f7a10957f89492d1.
Reason for revert: These changes make sense only for user-initiated selections. However, since the |setSelection()| method currently also sets the canonical selection, it is causing numerous issues. Therefore, we should revert this change for now.
Original change's description:
> The candidate position can also as a child node of the editing_root
>
> Consider this test case:
> <div contenteditable id="1">
> <div contenteditable="false" id="2">
> <div contenteditable id="3">|</div>
> </div>
> </div>
> Render process crashes when pressing "cmd+shift+;" to activate
> spell checker. The parameter of `CanonicalPosition` is div#1@offset[0]
> and the `anchor_node` of `next` is div#3. Since div#2 is not editable,
> the result of `RootEditableElementOf(next)` is div#3. However,
> `editing_root` is div#1, `CanonicalPosition` returns an empty position,
> leading to a DCHECK failure.
>
> Bug: 398288325
> Change-Id: Ic59883c3252afaf29b6e572147c74debbedd35a6
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6294503
> Reviewed-by: Kent Tamura <tk...@chromium.org>
> Commit-Queue: Peng Zhou <zhoupe...@bytedance.com>
> Cr-Commit-Position: refs/heads/main@{#1424296}
Bug: 474377386
Bug: 398288325
Change-Id: Icaee6a1261a0447ea98511df74da9648731f3f70
Change diff
Change information
Files:
- M third_party/blink/renderer/core/editing/spellcheck/spell_checker_test.cc
- M third_party/blink/renderer/core/editing/visible_units.cc
- M third_party/blink/renderer/platform/runtime_enabled_features.json5
- M third_party/blink/web_tests/editing/execCommand/delete-non-editable-range-crash.html
Change size: M
Delta: 4 files changed, 36 insertions(+), 62 deletions(-)
Related details
Attention is currently required from:
- Kent Tamura
- Peng Zhou
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Rubber Stamper (Gerrit)
Jan 12, 2026, 5:47:20 AM (2 days ago) Jan 12
to Shweta Bindal, AyeAye, Chromium LUCI CQ, Peng Zhou, Kent Tamura, chromium...@chromium.org, xiaochen...@chromium.org, kinuko...@chromium.org, jmedle...@chromium.org, blink-...@chromium.org
Attention needed from Kent Tamura and Peng Zhou
Message from Rubber Stamper![]( "Open in Gerrit")
The change is not in the configured time window. Rubber Stamper is only allowed to review reverts within 14 day(s). Learn more: go/rubber-stamper-user-guide.
Related details
Attention is currently required from:
- Kent Tamura
- Peng Zhou
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Shweta Bindal (Gerrit)
Jan 12, 2026, 5:53:29 AM (2 days ago) Jan 12
to AyeAye, Chromium LUCI CQ, Peng Zhou, Kent Tamura, chromium...@chromium.org, xiaochen...@chromium.org, kinuko...@chromium.org, jmedle...@chromium.org, blink-...@chromium.org
Attention needed from Kent Tamura and Peng Zhou
Shweta Bindal added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Shweta Bindal . resolved
Hi @zhoupe...@bytedance.com Can you please have a look, since it is creating a lot of new P1s
Related details
Attention is currently required from:
- Kent Tamura
- Peng Zhou
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Peng Zhou (Gerrit)
Jan 12, 2026, 7:13:48 AM (2 days ago) Jan 12
to Shweta Bindal, AyeAye, Chromium LUCI CQ, Kent Tamura, chromium...@chromium.org, xiaochen...@chromium.org, kinuko...@chromium.org, jmedle...@chromium.org, blink-...@chromium.org
Attention needed from Kent Tamura and Shweta Bindal
Peng Zhou voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Kent Tamura
- Shweta Bindal
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Peng Zhou (Gerrit)
Jan 12, 2026, 1:59:22 PM (2 days ago) Jan 12
to Shweta Bindal, AyeAye, Chromium LUCI CQ, Kent Tamura, chromium...@chromium.org, xiaochen...@chromium.org, kinuko...@chromium.org, jmedle...@chromium.org, blink-...@chromium.org
Attention needed from Kent Tamura and Shweta Bindal
Peng Zhou voted and added 1 comment![]( "Open in Gerrit")
Votes added by Peng Zhou
| Code-Review | +0 |
1 comment
Patchset-level comments
Shweta Bindal . resolved
Hi @zhoupe...@bytedance.com Can you please have a look, since it is creating a lot of new P1s
Peng Zhou
Do we strictly need to merge this into M145? If not, I plan to attempt a fix for [the issue 474377386](https://issues.chromium.org/issues/474377386) in M146. Since the current code has been in place for nearly 10 versions, I'm concerned that reverting it now might introduce new regressions. tkent@, do you agree?
Related details
Attention is currently required from:
- Kent Tamura
- Shweta Bindal
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kent Tamura (Gerrit)
Jan 12, 2026, 6:29:08 PM (2 days ago) Jan 12
to Shweta Bindal, Kent Tamura, Peng Zhou, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, xiaochen...@chromium.org, kinuko...@chromium.org, jmedle...@chromium.org, blink-...@chromium.org
Attention needed from Peng Zhou and Shweta Bindal
Kent Tamura voted and added 1 comment![]( "Open in Gerrit")
Votes added by Kent Tamura
| Code-Review | +1 |
1 comment
Patchset-level comments
Shweta Bindal . resolved
Peng ZhouHi @zhoupe...@bytedance.com Can you please have a look, since it is creating a lot of new P1s
Do we strictly need to merge this into M145? If not, I plan to attempt a fix for [the issue 474377386](https://issues.chromium.org/issues/474377386) in M146. Since the current code has been in place for nearly 10 versions, I'm concerned that reverting it now might introduce new regressions. tkent@, do you agree?
Attention is currently required from:
- Peng Zhou
- Shweta Bindal
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Peng Zhou (Gerrit)
Jan 12, 2026, 10:53:14 PM (2 days ago) Jan 12
to Shweta Bindal, Kent Tamura, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, xiaochen...@chromium.org, kinuko...@chromium.org, jmedle...@chromium.org, blink-...@chromium.org
Attention needed from Shweta Bindal
Peng Zhou voted Commit-Queue+2![]( "Open in Gerrit")
Attention is currently required from:
- Shweta Bindal
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Shweta Bindal (Gerrit)
Jan 13, 2026, 10:39:14 PM (5 hours ago) Jan 13
to Peng Zhou, Kent Tamura, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, xiaochen...@chromium.org, kinuko...@chromium.org, jmedle...@chromium.org, blink-...@chromium.org
Attention needed from Kent Tamura, Peng Zhou and Shweta Bindal
Message from Shweta Bindal![]( "Open in Gerrit")
Attention is currently required from:
- Kent Tamura
- Peng Zhou
- Shweta Bindal
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kent Tamura (Gerrit)
Jan 13, 2026, 10:43:11 PM (5 hours ago) Jan 13
to Shweta Bindal, Kent Tamura, Peng Zhou, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, xiaochen...@chromium.org, kinuko...@chromium.org, jmedle...@chromium.org, blink-...@chromium.org
Attention needed from Peng Zhou and Shweta Bindal
Kent Tamura voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Peng Zhou
- Shweta Bindal
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tanu Jain (Gerrit)
12:22 AM (3 hours ago) 12:22 AM
to Shweta Bindal, Kent Tamura, Peng Zhou, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, xiaochen...@chromium.org, kinuko...@chromium.org, jmedle...@chromium.org, blink-...@chromium.org
Attention needed from Peng Zhou and Shweta Bindal
Tanu Jain voted Code-Review+1![]( "Open in Gerrit")
Shweta Bindal (Gerrit)
12:23 AM (3 hours ago) 12:23 AM
to Tanu Jain, Kent Tamura, Peng Zhou, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, xiaochen...@chromium.org, kinuko...@chromium.org, jmedle...@chromium.org, blink-...@chromium.org
Attention needed from Peng Zhou
Shweta Bindal voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Peng Zhou
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
12:34 AM (3 hours ago) 12:34 AM
to Shweta Bindal, Tanu Jain, Kent Tamura, Peng Zhou, AyeAye, chromium...@chromium.org, xiaochen...@chromium.org, kinuko...@chromium.org, jmedle...@chromium.org, blink-...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Reviewed-by: Kent Tamura <tk...@chromium.org>
Reviewed-by: Tanu Jain <tanu...@microsoft.com>
Commit-Queue: Shweta Bindal <shweta...@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1568903}
Files:
- M third_party/blink/renderer/core/editing/spellcheck/spell_checker_test.cc
- M third_party/blink/renderer/core/editing/visible_units.cc
- M third_party/blink/web_tests/editing/execCommand/delete-non-editable-range-crash.html
Change size: M
Delta: 3 files changed, 35 insertions(+), 71 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Tanu Jain, +1 by Kent Tamura
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages