tar: use python3 [chromium/tools/build : main]
Takuto Ikuta (Gerrit)
Attention is currently required from: Jeff Yoon, Kuan Huang.
Patch set 2:Auto-Submit +1Commit-Queue +1
To view, visit change 3818083. To unsubscribe, or for help writing mail filters, visit settings.
Kuan Huang (Gerrit)
Attention is currently required from: Jeff Yoon, Takuto Ikuta.
1 comment:
Patchset:
Does this module have test coverage for resources/tar.py and untar.py? The current code seems only exam the command to tar.py.
To view, visit change 3818083. To unsubscribe, or for help writing mail filters, visit settings.
Takuto Ikuta (Gerrit)
Attention is currently required from: Jeff Yoon, Kuan Huang.
Patch set 3:Auto-Submit +1
1 comment:
Patchset:
Does this module have test coverage for resources/tar.py and untar. […]
Seems not. Do you want me to write test for this?
To view, visit change 3818083. To unsubscribe, or for help writing mail filters, visit settings.
Kuan Huang (Gerrit)
Attention is currently required from: Jeff Yoon, Takuto Ikuta.
1 comment:
Patchset:
Seems not. […]
I know it was not have test coverage originally, just want to make sure the CL covers all the difference moving to python3.
To view, visit change 3818083. To unsubscribe, or for help writing mail filters, visit settings.
Takuto Ikuta (Gerrit)
Attention is currently required from: Jeff Yoon, Kuan Huang.
Patch set 4:-Auto-Submit
1 comment:
Patchset:
I know it was not have test coverage originally, just want to make sure the CL covers all the differ […]
OK, made https://crrev.com/c/3818087 for test.
To view, visit change 3818083. To unsubscribe, or for help writing mail filters, visit settings.
Kuan Huang (Gerrit)
Attention is currently required from: Jeff Yoon, Takuto Ikuta.
Patch set 4:Code-Review +1
Takuto Ikuta (Gerrit)
Attention is currently required from: Jeff Yoon.
Patch set 4:Commit-Queue +2
Takuto Ikuta (Gerrit)
Attention is currently required from: Jeff Yoon.
1 comment:
Patchset:
OK, made https://crrev.com/c/3818087 for test.
Ack
To view, visit change 3818083. To unsubscribe, or for help writing mail filters, visit settings.
LUCI CQ (Gerrit)
LUCI CQ submitted this change.
tar: use python3
Bug: 1351164
Recipe-Nontrivial-Roll: build_limited
Change-Id: I04a2a75aec64ed9d525e0216cc8cf6ecd5440a82
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/build/+/3818083
Reviewed-by: Kuan Huang <kuan...@chromium.org>
Commit-Queue: Takuto Ikuta <tik...@chromium.org>
---
M recipes/recipe_modules/tar/api.py
M recipes/recipe_modules/tar/examples/full.expected/linux.json
M recipes/recipe_modules/tar/examples/full.expected/mac.json
M recipes/recipe_modules/tar/examples/full.expected/win.json
4 files changed, 25 insertions(+), 11 deletions(-)