Move webstore_install_result.{cc/h} to //extensions. [chromium/src : main]

0 views
Skip to first unread message

Miyoung Shin (Gerrit)

unread,
Apr 22, 2026, 4:41:46 AMApr 22
to Devlin Cronin, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, dmurph+wat...@chromium.org, extension...@chromium.org, webap...@microsoft.com
Attention needed from Devlin Cronin

Miyoung Shin voted and added 1 comment

Votes added by Miyoung Shin

Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Miyoung Shin . resolved

Hi, Devlin
These files were previously located under //chrome/common/, but since all of its usages are within //chrome/browser, I've moved them to //extensions/browser.
Please let me know if I missed anything or if there are other considerations I should take into account. Thanks in advance.

Open in Gerrit

Related details

Attention is currently required from:
  • Devlin Cronin
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I75421c21cd53b26dcd368e7c19db9659f3f7bbcf
Gerrit-Change-Number: 7783715
Gerrit-PatchSet: 1
Gerrit-Owner: Miyoung Shin <myid...@igalia.com>
Gerrit-Reviewer: Devlin Cronin <rdevlin...@chromium.org>
Gerrit-Reviewer: Miyoung Shin <myid...@igalia.com>
Gerrit-Attention: Devlin Cronin <rdevlin...@chromium.org>
Gerrit-Comment-Date: Wed, 22 Apr 2026 08:41:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Devlin Cronin (Gerrit)

unread,
Apr 22, 2026, 7:55:46 PMApr 22
to Miyoung Shin, Devlin Cronin, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, dmurph+wat...@chromium.org, extension...@chromium.org, webap...@microsoft.com
Attention needed from Miyoung Shin

Devlin Cronin voted and added 2 comments

Votes added by Devlin Cronin

Code-Review+1

2 comments

Patchset-level comments
Miyoung Shin . resolved

Hi, Devlin
These files were previously located under //chrome/common/, but since all of its usages are within //chrome/browser, I've moved them to //extensions/browser.
Please let me know if I missed anything or if there are other considerations I should take into account. Thanks in advance.

Devlin Cronin

LGTM. Normally, if something were only used in //chrome/browser/extensions, we'd put it there -- but since you're working on pulling up all this related code, this is good : )

Devlin Cronin . resolved

LG; thanks, Miyoung!

Open in Gerrit

Related details

Attention is currently required from:
  • Miyoung Shin
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I75421c21cd53b26dcd368e7c19db9659f3f7bbcf
    Gerrit-Change-Number: 7783715
    Gerrit-PatchSet: 1
    Gerrit-Owner: Miyoung Shin <myid...@igalia.com>
    Gerrit-Reviewer: Devlin Cronin <rdevlin...@chromium.org>
    Gerrit-Reviewer: Miyoung Shin <myid...@igalia.com>
    Gerrit-Attention: Miyoung Shin <myid...@igalia.com>
    Gerrit-Comment-Date: Wed, 22 Apr 2026 23:55:39 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    Comment-In-Reply-To: Miyoung Shin <myid...@igalia.com>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Miyoung Shin (Gerrit)

    unread,
    Apr 23, 2026, 6:23:10 AMApr 23
    to Avi Drissman, Devlin Cronin, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, dmurph+wat...@chromium.org, extension...@chromium.org, webap...@microsoft.com
    Attention needed from Avi Drissman

    Miyoung Shin added 1 comment

    Patchset-level comments
    Miyoung Shin . resolved

    @avi for //chrome except extensions area

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Avi Drissman
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I75421c21cd53b26dcd368e7c19db9659f3f7bbcf
    Gerrit-Change-Number: 7783715
    Gerrit-PatchSet: 1
    Gerrit-Owner: Miyoung Shin <myid...@igalia.com>
    Gerrit-Reviewer: Avi Drissman <a...@chromium.org>
    Gerrit-Reviewer: Devlin Cronin <rdevlin...@chromium.org>
    Gerrit-Reviewer: Miyoung Shin <myid...@igalia.com>
    Gerrit-Attention: Avi Drissman <a...@chromium.org>
    Gerrit-Comment-Date: Thu, 23 Apr 2026 10:23:02 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Avi Drissman (Gerrit)

    unread,
    Apr 23, 2026, 10:36:42 AMApr 23
    to Miyoung Shin, Avi Drissman, Devlin Cronin, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, dmurph+wat...@chromium.org, extension...@chromium.org, webap...@microsoft.com
    Attention needed from Miyoung Shin

    Avi Drissman voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Miyoung Shin
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I75421c21cd53b26dcd368e7c19db9659f3f7bbcf
    Gerrit-Change-Number: 7783715
    Gerrit-PatchSet: 1
    Gerrit-Owner: Miyoung Shin <myid...@igalia.com>
    Gerrit-Reviewer: Avi Drissman <a...@chromium.org>
    Gerrit-Reviewer: Devlin Cronin <rdevlin...@chromium.org>
    Gerrit-Reviewer: Miyoung Shin <myid...@igalia.com>
    Gerrit-Attention: Miyoung Shin <myid...@igalia.com>
    Gerrit-Comment-Date: Thu, 23 Apr 2026 14:36:36 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Miyoung Shin (Gerrit)

    unread,
    Apr 23, 2026, 6:47:39 PMApr 23
    to Avi Drissman, Devlin Cronin, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, dmurph+wat...@chromium.org, extension...@chromium.org, webap...@microsoft.com

    Miyoung Shin voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I75421c21cd53b26dcd368e7c19db9659f3f7bbcf
    Gerrit-Change-Number: 7783715
    Gerrit-PatchSet: 1
    Gerrit-Owner: Miyoung Shin <myid...@igalia.com>
    Gerrit-Reviewer: Avi Drissman <a...@chromium.org>
    Gerrit-Reviewer: Devlin Cronin <rdevlin...@chromium.org>
    Gerrit-Reviewer: Miyoung Shin <myid...@igalia.com>
    Gerrit-Comment-Date: Thu, 23 Apr 2026 22:47:08 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Miyoung Shin (Gerrit)

    unread,
    6:28 AM (6 hours ago) 6:28 AM
    to Avi Drissman, Devlin Cronin, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, dmurph+wat...@chromium.org, extension...@chromium.org, webap...@microsoft.com

    Miyoung Shin voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I75421c21cd53b26dcd368e7c19db9659f3f7bbcf
    Gerrit-Change-Number: 7783715
    Gerrit-PatchSet: 2
    Gerrit-Owner: Miyoung Shin <myid...@igalia.com>
    Gerrit-Reviewer: Avi Drissman <a...@chromium.org>
    Gerrit-Reviewer: Devlin Cronin <rdevlin...@chromium.org>
    Gerrit-Reviewer: Miyoung Shin <myid...@igalia.com>
    Gerrit-Comment-Date: Sun, 10 May 2026 10:27:56 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages