webnn: rename roundingType to outputShapeRounding for pool2d ops [chromium/src : main]

0 views
Skip to first unread message

Dai, Feng (Gerrit)

unread,
Apr 2, 2026, 3:17:02 AMApr 2
to Hu, Ningxin, Reilly Grant, Dwayne Robinson, Fu, Junwei, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, mac-r...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org
Attention needed from Hu, Ningxin and Reilly Grant

Dai, Feng added 1 comment

Patchset-level comments
File-level comment, Patchset 7 (Latest):
Dai, Feng . resolved

Since the failure of *mac14-blink-rel* trybot isn't relevant with these updated pool2d tests of this CL, so I removed *mac14-blink-rel* trybot from Cq-Include-Trybots.

@rei...@chromium.org @ningx...@intel.com PTAL, thanks!

Open in Gerrit

Related details

Attention is currently required from:
  • Hu, Ningxin
  • Reilly Grant
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I815c7f7728071144835c0ada0747bc9de2999669
Gerrit-Change-Number: 7717139
Gerrit-PatchSet: 7
Gerrit-Owner: Dai, Feng <feng...@intel.com>
Gerrit-Reviewer: Dai, Feng <feng...@intel.com>
Gerrit-Reviewer: Hu, Ningxin <ningx...@intel.com>
Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>
Gerrit-CC: Dwayne Robinson <dwa...@microsoft.com>
Gerrit-CC: Fu, Junwei <junw...@intel.com>
Gerrit-Attention: Hu, Ningxin <ningx...@intel.com>
Gerrit-Attention: Reilly Grant <rei...@chromium.org>
Gerrit-Comment-Date: Thu, 02 Apr 2026 07:16:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Hu, Ningxin (Gerrit)

unread,
Apr 2, 2026, 9:46:27 AMApr 2
to Dai, Feng, Reilly Grant, Dwayne Robinson, Fu, Junwei, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, mac-r...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org
Attention needed from Dai, Feng and Reilly Grant

Hu, Ningxin voted and added 1 comment

Votes added by Hu, Ningxin

Code-Review+1

1 comment

Patchset-level comments
Hu, Ningxin . resolved

LGTM

Open in Gerrit

Related details

Attention is currently required from:
  • Dai, Feng
  • Reilly Grant
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I815c7f7728071144835c0ada0747bc9de2999669
Gerrit-Change-Number: 7717139
Gerrit-PatchSet: 7
Gerrit-Owner: Dai, Feng <feng...@intel.com>
Gerrit-Reviewer: Dai, Feng <feng...@intel.com>
Gerrit-Reviewer: Hu, Ningxin <ningx...@intel.com>
Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>
Gerrit-CC: Dwayne Robinson <dwa...@microsoft.com>
Gerrit-CC: Fu, Junwei <junw...@intel.com>
Gerrit-Attention: Reilly Grant <rei...@chromium.org>
Gerrit-Attention: Dai, Feng <feng...@intel.com>
Gerrit-Comment-Date: Thu, 02 Apr 2026 13:46:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Dwayne Robinson (Gerrit)

unread,
Apr 2, 2026, 9:20:58 PMApr 2
to Dai, Feng, Hu, Ningxin, Reilly Grant, Fu, Junwei, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, mac-r...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org
Attention needed from Dai, Feng and Reilly Grant

Dwayne Robinson added 1 comment

Patchset-level comments
Dwayne Robinson . resolved

👍 Thanks Bruce.

Gerrit-Comment-Date: Fri, 03 Apr 2026 01:20:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Reilly Grant (Gerrit)

unread,
Apr 9, 2026, 7:53:31 PMApr 9
to Dai, Feng, Reilly Grant, Hu, Ningxin, Dwayne Robinson, Fu, Junwei, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, mac-r...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org
Attention needed from Dai, Feng

Reilly Grant voted and added 1 comment

Votes added by Reilly Grant

Code-Review+1

1 comment

Patchset-level comments
Reilly Grant . resolved

LGTM

Open in Gerrit

Related details

Attention is currently required from:
  • Dai, Feng
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I815c7f7728071144835c0ada0747bc9de2999669
    Gerrit-Change-Number: 7717139
    Gerrit-PatchSet: 7
    Gerrit-Owner: Dai, Feng <feng...@intel.com>
    Gerrit-Reviewer: Dai, Feng <feng...@intel.com>
    Gerrit-Reviewer: Hu, Ningxin <ningx...@intel.com>
    Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>
    Gerrit-CC: Dwayne Robinson <dwa...@microsoft.com>
    Gerrit-CC: Fu, Junwei <junw...@intel.com>
    Gerrit-Attention: Dai, Feng <feng...@intel.com>
    Gerrit-Comment-Date: Thu, 09 Apr 2026 23:53:20 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Dai, Feng (Gerrit)

    unread,
    Apr 9, 2026, 9:17:08 PMApr 9
    to Reilly Grant, Hu, Ningxin, Dwayne Robinson, Fu, Junwei, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, aj...@chromium.com, mac-r...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org

    Dai, Feng added 1 comment

    Patchset-level comments
    Dai, Feng . resolved

    @aj...@chromium.com Could you please help review `services/webnn/public/mojom/webnn_graph.mojom`? Thanks!

    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I815c7f7728071144835c0ada0747bc9de2999669
    Gerrit-Change-Number: 7717139
    Gerrit-PatchSet: 7
    Gerrit-Owner: Dai, Feng <feng...@intel.com>
    Gerrit-Reviewer: Dai, Feng <feng...@intel.com>
    Gerrit-Reviewer: Hu, Ningxin <ningx...@intel.com>
    Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>
    Gerrit-CC: Dwayne Robinson <dwa...@microsoft.com>
    Gerrit-CC: Fu, Junwei <junw...@intel.com>
    Gerrit-Comment-Date: Fri, 10 Apr 2026 01:16:52 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Dai, Feng (Gerrit)

    unread,
    Apr 12, 2026, 9:26:06 PMApr 12
    to Alex Gough, Reilly Grant, Hu, Ningxin, Dwayne Robinson, Fu, Junwei, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, mac-r...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org
    Attention needed from Alex Gough

    Dai, Feng added 1 comment

    Patchset-level comments
    Dai, Feng . resolved

    @aj...@chromium.org Could you please help review `services/webnn/public/mojom/webnn_graph.mojom` file? Thanks!

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Alex Gough
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I815c7f7728071144835c0ada0747bc9de2999669
    Gerrit-Change-Number: 7717139
    Gerrit-PatchSet: 7
    Gerrit-Owner: Dai, Feng <feng...@intel.com>
    Gerrit-Reviewer: Alex Gough <aj...@chromium.org>
    Gerrit-Reviewer: Dai, Feng <feng...@intel.com>
    Gerrit-Reviewer: Hu, Ningxin <ningx...@intel.com>
    Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>
    Gerrit-CC: Dwayne Robinson <dwa...@microsoft.com>
    Gerrit-CC: Fu, Junwei <junw...@intel.com>
    Gerrit-Attention: Alex Gough <aj...@chromium.org>
    Gerrit-Comment-Date: Mon, 13 Apr 2026 01:25:39 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Alex Gough (Gerrit)

    unread,
    Apr 13, 2026, 9:41:26 AMApr 13
    to Dai, Feng, Alex Gough, Reilly Grant, Hu, Ningxin, Dwayne Robinson, Fu, Junwei, android-bu...@system.gserviceaccount.com, chromiu...@luci-project-accounts.iam.gserviceaccount.com, chromium...@chromium.org, mac-r...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org
    Attention needed from Dai, Feng

    Alex Gough voted and added 1 comment

    Votes added by Alex Gough

    Code-Review+1

    1 comment

    Patchset-level comments
    Alex Gough . resolved

    lgtm mojom rename

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Dai, Feng
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I815c7f7728071144835c0ada0747bc9de2999669
    Gerrit-Change-Number: 7717139
    Gerrit-PatchSet: 7
    Gerrit-Owner: Dai, Feng <feng...@intel.com>
    Gerrit-Reviewer: Alex Gough <aj...@chromium.org>
    Gerrit-Reviewer: Dai, Feng <feng...@intel.com>
    Gerrit-Reviewer: Hu, Ningxin <ningx...@intel.com>
    Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>
    Gerrit-Attention: Dai, Feng <feng...@intel.com>
    Gerrit-Comment-Date: Mon, 13 Apr 2026 13:40:46 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Blink W3C Test Autoroller (Gerrit)

    unread,
    Apr 13, 2026, 9:44:52 AMApr 13
    to Dai, Feng, Alex Gough, Reilly Grant, Hu, Ningxin, Dwayne Robinson, Fu, Junwei, android-bu...@system.gserviceaccount.com, chromiu...@luci-project-accounts.iam.gserviceaccount.com, chromium...@chromium.org, mac-r...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org
    Attention needed from Dai, Feng

    Message from Blink W3C Test Autoroller

    Exportable changes to web-platform-tests were detected in this CL and a pull request in the upstream repo has been made: https://github.com/web-platform-tests/wpt/pull/59145.

    When this CL lands, the bot will automatically merge the PR on GitHub if the required GitHub checks pass; otherwise, ecosystem-infra@ team will triage the failures and may contact you.

    WPT Export docs:
    https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md#Automatic-export-process

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Dai, Feng
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I815c7f7728071144835c0ada0747bc9de2999669
    Gerrit-Change-Number: 7717139
    Gerrit-PatchSet: 7
    Gerrit-Owner: Dai, Feng <feng...@intel.com>
    Gerrit-Reviewer: Alex Gough <aj...@chromium.org>
    Gerrit-Reviewer: Dai, Feng <feng...@intel.com>
    Gerrit-Reviewer: Hu, Ningxin <ningx...@intel.com>
    Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>
    Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
    Gerrit-Comment-Date: Mon, 13 Apr 2026 13:44:43 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: No
    satisfied_requirement
    open
    diffy

    Dai, Feng (Gerrit)

    unread,
    Apr 13, 2026, 9:52:27 AMApr 13
    to Blink W3C Test Autoroller, Alex Gough, Reilly Grant, Hu, Ningxin, Dwayne Robinson, Fu, Junwei, android-bu...@system.gserviceaccount.com, chromiu...@luci-project-accounts.iam.gserviceaccount.com, chromium...@chromium.org, mac-r...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org

    Dai, Feng added 1 comment

    Patchset-level comments
    Dai, Feng . resolved

    Thank you for reviewing! I'm going to submit this CL.

    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I815c7f7728071144835c0ada0747bc9de2999669
    Gerrit-Change-Number: 7717139
    Gerrit-PatchSet: 7
    Gerrit-Owner: Dai, Feng <feng...@intel.com>
    Gerrit-Reviewer: Alex Gough <aj...@chromium.org>
    Gerrit-Reviewer: Dai, Feng <feng...@intel.com>
    Gerrit-Reviewer: Hu, Ningxin <ningx...@intel.com>
    Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>
    Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
    Gerrit-CC: Dwayne Robinson <dwa...@microsoft.com>
    Gerrit-CC: Fu, Junwei <junw...@intel.com>
    Gerrit-Comment-Date: Mon, 13 Apr 2026 13:52:12 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    open
    diffy

    Dai, Feng (Gerrit)

    unread,
    Apr 13, 2026, 9:52:34 AMApr 13
    to Blink W3C Test Autoroller, Alex Gough, Reilly Grant, Hu, Ningxin, Dwayne Robinson, Fu, Junwei, android-bu...@system.gserviceaccount.com, chromiu...@luci-project-accounts.iam.gserviceaccount.com, chromium...@chromium.org, mac-r...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org

    Dai, Feng voted Commit-Queue+2

    Commit-Queue+2
    Gerrit-Comment-Date: Mon, 13 Apr 2026 13:52:18 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Dai, Feng (Gerrit)

    unread,
    Apr 14, 2026, 1:59:59 AMApr 14
    to Blink W3C Test Autoroller, Alex Gough, Reilly Grant, Hu, Ningxin, Dwayne Robinson, Fu, Junwei, android-bu...@system.gserviceaccount.com, chromiu...@luci-project-accounts.iam.gserviceaccount.com, chromium...@chromium.org, ortuno...@chromium.org, titoua...@chromium.org, mac-r...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org
    Attention needed from Alex Gough, Hu, Ningxin and Reilly Grant

    Dai, Feng added 1 comment

    Patchset-level comments
    File-level comment, Patchset 8:
    Dai, Feng . resolved

    Trybot `win11-blink-rel` ran failed, it's not with this CL. Removed `win11-blink-rel` from Cq-Include-Trybots. Now all trybots run passed.

    @rei...@chromium.org @ningx...@intel.com could you please take another look at the new commit of renaming modifications in the rebased `services/webnn/webnn_graph_impl_fuzzer.cc` file, and give your votes again? Thanks!

    @aj...@chromium.org There's no change in the `services/webnn/public/mojom/webnn_graph.mojom` file, could you please give your vote again? Thanks!

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Alex Gough
    • Hu, Ningxin
    • Reilly Grant
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I815c7f7728071144835c0ada0747bc9de2999669
    Gerrit-Change-Number: 7717139
    Gerrit-PatchSet: 9
    Gerrit-Owner: Dai, Feng <feng...@intel.com>
    Gerrit-Reviewer: Alex Gough <aj...@chromium.org>
    Gerrit-Reviewer: Dai, Feng <feng...@intel.com>
    Gerrit-Reviewer: Hu, Ningxin <ningx...@intel.com>
    Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>
    Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
    Gerrit-CC: Dwayne Robinson <dwa...@microsoft.com>
    Gerrit-CC: Fu, Junwei <junw...@intel.com>
    Gerrit-Attention: Hu, Ningxin <ningx...@intel.com>
    Gerrit-Attention: Reilly Grant <rei...@chromium.org>
    Gerrit-Attention: Alex Gough <aj...@chromium.org>
    Gerrit-Comment-Date: Tue, 14 Apr 2026 05:59:45 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Reilly Grant (Gerrit)

    unread,
    Apr 14, 2026, 5:58:21 PMApr 14
    to Dai, Feng, Reilly Grant, Blink W3C Test Autoroller, Alex Gough, Hu, Ningxin, Dwayne Robinson, Fu, Junwei, android-bu...@system.gserviceaccount.com, chromiu...@luci-project-accounts.iam.gserviceaccount.com, chromium...@chromium.org, ortuno...@chromium.org, titoua...@chromium.org, mac-r...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org
    Attention needed from Alex Gough, Dai, Feng and Hu, Ningxin

    Reilly Grant voted and added 1 comment

    Votes added by Reilly Grant

    Code-Review+1

    1 comment

    Patchset-level comments
    Reilly Grant . resolved

    LGTM

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Alex Gough
    • Dai, Feng
    • Hu, Ningxin
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I815c7f7728071144835c0ada0747bc9de2999669
    Gerrit-Change-Number: 7717139
    Gerrit-PatchSet: 9
    Gerrit-Owner: Dai, Feng <feng...@intel.com>
    Gerrit-Reviewer: Alex Gough <aj...@chromium.org>
    Gerrit-Reviewer: Dai, Feng <feng...@intel.com>
    Gerrit-Reviewer: Hu, Ningxin <ningx...@intel.com>
    Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>
    Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
    Gerrit-CC: Dwayne Robinson <dwa...@microsoft.com>
    Gerrit-CC: Fu, Junwei <junw...@intel.com>
    Gerrit-Attention: Hu, Ningxin <ningx...@intel.com>
    Gerrit-Attention: Dai, Feng <feng...@intel.com>
    Gerrit-Attention: Alex Gough <aj...@chromium.org>
    Gerrit-Comment-Date: Tue, 14 Apr 2026 21:58:06 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Dai, Feng (Gerrit)

    unread,
    Apr 19, 2026, 10:47:15 PM (11 days ago) Apr 19
    to Reilly Grant, Blink W3C Test Autoroller, Alex Gough, Hu, Ningxin, Dwayne Robinson, Fu, Junwei, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, ortuno...@chromium.org, titoua...@chromium.org, mac-r...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org
    Attention needed from Alex Gough and Hu, Ningxin

    Dai, Feng added 1 comment

    Patchset-level comments
    Dai, Feng . resolved

    Gentle ping @ningx...@intel.com and @aj...@chromium.org, please take another review, thanks!

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Alex Gough
    • Hu, Ningxin
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I815c7f7728071144835c0ada0747bc9de2999669
    Gerrit-Change-Number: 7717139
    Gerrit-PatchSet: 9
    Gerrit-Owner: Dai, Feng <feng...@intel.com>
    Gerrit-Reviewer: Alex Gough <aj...@chromium.org>
    Gerrit-Reviewer: Dai, Feng <feng...@intel.com>
    Gerrit-Reviewer: Hu, Ningxin <ningx...@intel.com>
    Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>
    Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
    Gerrit-Attention: Hu, Ningxin <ningx...@intel.com>
    Gerrit-Attention: Alex Gough <aj...@chromium.org>
    Gerrit-Comment-Date: Mon, 20 Apr 2026 02:46:45 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Hu, Ningxin (Gerrit)

    unread,
    Apr 19, 2026, 11:42:40 PM (11 days ago) Apr 19
    to Dai, Feng, Reilly Grant, Blink W3C Test Autoroller, Alex Gough, Dwayne Robinson, Fu, Junwei, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, ortuno...@chromium.org, titoua...@chromium.org, mac-r...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org
    Attention needed from Alex Gough and Dai, Feng

    Hu, Ningxin voted and added 1 comment

    Votes added by Hu, Ningxin

    Code-Review+1

    1 comment

    Patchset-level comments
    Hu, Ningxin . resolved

    LGTM

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Alex Gough
    • Dai, Feng
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I815c7f7728071144835c0ada0747bc9de2999669
      Gerrit-Change-Number: 7717139
      Gerrit-PatchSet: 9
      Gerrit-Owner: Dai, Feng <feng...@intel.com>
      Gerrit-Reviewer: Alex Gough <aj...@chromium.org>
      Gerrit-Reviewer: Dai, Feng <feng...@intel.com>
      Gerrit-Reviewer: Hu, Ningxin <ningx...@intel.com>
      Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>
      Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
      Gerrit-CC: Dwayne Robinson <dwa...@microsoft.com>
      Gerrit-CC: Fu, Junwei <junw...@intel.com>
      Gerrit-Attention: Dai, Feng <feng...@intel.com>
      Gerrit-Attention: Alex Gough <aj...@chromium.org>
      Gerrit-Comment-Date: Mon, 20 Apr 2026 03:42:24 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Alex Gough (Gerrit)

      unread,
      Apr 20, 2026, 12:27:57 PM (10 days ago) Apr 20
      to Dai, Feng, Alex Gough, Hu, Ningxin, Reilly Grant, Blink W3C Test Autoroller, Dwayne Robinson, Fu, Junwei, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, ortuno...@chromium.org, titoua...@chromium.org, mac-r...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org
      Attention needed from Dai, Feng

      Alex Gough voted and added 1 comment

      Votes added by Alex Gough

      Code-Review+1

      1 comment

      Patchset-level comments
      Alex Gough . resolved

      lgtm

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Dai, Feng
      Gerrit-Comment-Date: Mon, 20 Apr 2026 16:27:47 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Dai, Feng (Gerrit)

      unread,
      Apr 20, 2026, 9:08:28 PM (10 days ago) Apr 20
      to Alex Gough, Hu, Ningxin, Reilly Grant, Blink W3C Test Autoroller, Dwayne Robinson, Fu, Junwei, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, ortuno...@chromium.org, titoua...@chromium.org, mac-r...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org

      Dai, Feng voted and added 1 comment

      Votes added by Dai, Feng

      Auto-Submit+1
      Commit-Queue+2

      1 comment

      Patchset-level comments
      Dai, Feng . resolved

      Thanks for your reviewing!☕


      I'm going to submit this CL.

      Open in Gerrit

      Related details

      Attention set is empty
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I815c7f7728071144835c0ada0747bc9de2999669
      Gerrit-Change-Number: 7717139
      Gerrit-PatchSet: 9
      Gerrit-Owner: Dai, Feng <feng...@intel.com>
      Gerrit-Reviewer: Alex Gough <aj...@chromium.org>
      Gerrit-Reviewer: Dai, Feng <feng...@intel.com>
      Gerrit-Reviewer: Hu, Ningxin <ningx...@intel.com>
      Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>
      Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
      Gerrit-CC: Dwayne Robinson <dwa...@microsoft.com>
      Gerrit-CC: Fu, Junwei <junw...@intel.com>
      Gerrit-Comment-Date: Tue, 21 Apr 2026 01:08:07 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Dai, Feng (Gerrit)

      unread,
      Apr 21, 2026, 3:23:29 AM (10 days ago) Apr 21
      to Alex Gough, Hu, Ningxin, Reilly Grant, Blink W3C Test Autoroller, Dwayne Robinson, Fu, Junwei, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, ortuno...@chromium.org, titoua...@chromium.org, mac-r...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org

      Dai, Feng voted Commit-Queue+2

      Commit-Queue+2
      Gerrit-Comment-Date: Tue, 21 Apr 2026 07:23:07 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Chromium LUCI CQ (Gerrit)

      unread,
      Apr 21, 2026, 4:16:03 AM (10 days ago) Apr 21
      to Dai, Feng, Alex Gough, Hu, Ningxin, Reilly Grant, Blink W3C Test Autoroller, Dwayne Robinson, Fu, Junwei, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, ortuno...@chromium.org, titoua...@chromium.org, mac-r...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org

      Chromium LUCI CQ submitted the change

      Change information

      Commit message:
      webnn: rename roundingType to outputShapeRounding for pool2d ops

      This CL renames MLPool2dOptions::roundingType to
      MLPool2dOptions::outputShapeRounding in test files and implementations
      according to Spec change [1].

      [1] https://github.com/webmachinelearning/webnn/pull/770
      Bug: 498118207
      Change-Id: I815c7f7728071144835c0ada0747bc9de2999669
      Cq-Include-Trybots: luci.chromium.try:mac14.arm64-blink-rel, mac15.arm64-blink-rel, mac15-blink-rel, linux-blink-rel
      Reviewed-by: Hu, Ningxin <ningx...@intel.com>
      Reviewed-by: Reilly Grant <rei...@chromium.org>
      Reviewed-by: Alex Gough <aj...@chromium.org>
      Auto-Submit: Dai, Feng <feng...@intel.com>
      Commit-Queue: Dai, Feng <feng...@intel.com>
      Cr-Commit-Position: refs/heads/main@{#1618021}
      Files:
      • M services/webnn/public/cpp/graph_validation_utils.cc
      • M services/webnn/public/cpp/graph_validation_utils.h
      • M services/webnn/public/mojom/webnn_graph.mojom
      • M services/webnn/webnn_graph_impl_fuzzer.cc
      • M third_party/blink/renderer/modules/ml/webnn/ml_graph_builder.cc
      • M third_party/blink/renderer/modules/ml/webnn/ml_graph_builder.idl
      • M third_party/blink/renderer/modules/ml/webnn/ml_graph_transform/utils/ml_graph_dump.cc
      • M third_party/blink/web_tests/external/wpt/webnn/conformance_tests/averagePool2d.https.any.js
      • M third_party/blink/web_tests/external/wpt/webnn/conformance_tests/l2Pool2d.https.any.js
      • M third_party/blink/web_tests/external/wpt/webnn/conformance_tests/maxPool2d.https.any.js
      • M third_party/blink/web_tests/external/wpt/webnn/validation_tests/pooling.https.any.js
      • M third_party/blink/web_tests/platform/mac-mac14-arm64/virtual/webnn-service-on-cpu/external/wpt/webnn/conformance_tests/l2Pool2d.https.any_cpu-expected.txt
      • M third_party/blink/web_tests/platform/mac-mac14-arm64/virtual/webnn-service-on-npu/external/wpt/webnn/conformance_tests/l2Pool2d.https.any_npu-expected.txt
      • M third_party/blink/web_tests/platform/mac-mac14-arm64/virtual/webnn-service-with-gpu/external/wpt/webnn/conformance_tests/l2Pool2d.https.any_gpu-expected.txt
      • M third_party/blink/web_tests/platform/mac-mac15-arm64/virtual/webnn-service-on-cpu/external/wpt/webnn/conformance_tests/averagePool2d.https.any_cpu-expected.txt
      • M third_party/blink/web_tests/platform/mac-mac15-arm64/virtual/webnn-service-on-cpu/external/wpt/webnn/conformance_tests/l2Pool2d.https.any_cpu-expected.txt
      • M third_party/blink/web_tests/platform/mac-mac15-arm64/virtual/webnn-service-on-cpu/external/wpt/webnn/conformance_tests/maxPool2d.https.any_cpu-expected.txt
      • M third_party/blink/web_tests/platform/mac-mac15-arm64/virtual/webnn-service-on-npu/external/wpt/webnn/conformance_tests/averagePool2d.https.any_npu-expected.txt
      • M third_party/blink/web_tests/platform/mac-mac15-arm64/virtual/webnn-service-on-npu/external/wpt/webnn/conformance_tests/l2Pool2d.https.any_npu-expected.txt
      • M third_party/blink/web_tests/platform/mac-mac15-arm64/virtual/webnn-service-on-npu/external/wpt/webnn/conformance_tests/maxPool2d.https.any_npu-expected.txt
      • M third_party/blink/web_tests/platform/mac-mac15-arm64/virtual/webnn-service-with-gpu/external/wpt/webnn/conformance_tests/averagePool2d.https.any_gpu-expected.txt
      • M third_party/blink/web_tests/platform/mac-mac15-arm64/virtual/webnn-service-with-gpu/external/wpt/webnn/conformance_tests/l2Pool2d.https.any_gpu-expected.txt
      • M third_party/blink/web_tests/platform/mac-mac15-arm64/virtual/webnn-service-with-gpu/external/wpt/webnn/conformance_tests/maxPool2d.https.any_gpu-expected.txt
      • M third_party/blink/web_tests/platform/mac/virtual/webnn-service-with-gpu/external/wpt/webnn/conformance_tests/averagePool2d.https.any_gpu-expected.txt
      • M third_party/blink/web_tests/platform/mac/virtual/webnn-service-with-gpu/external/wpt/webnn/conformance_tests/maxPool2d.https.any_gpu-expected.txt
      • A third_party/blink/web_tests/platform/win11-arm64/virtual/webnn-service-on-cpu/external/wpt/webnn/conformance_tests/averagePool2d.https.any_cpu-expected.txt
      • A third_party/blink/web_tests/platform/win11-arm64/virtual/webnn-service-on-cpu/external/wpt/webnn/conformance_tests/maxPool2d.https.any_cpu-expected.txt
      • M third_party/blink/web_tests/virtual/webnn-service-on-cpu/external/wpt/webnn/conformance_tests/averagePool2d.https.any_cpu-expected.txt
      • M third_party/blink/web_tests/virtual/webnn-service-on-cpu/external/wpt/webnn/conformance_tests/maxPool2d.https.any_cpu-expected.txt
      • M third_party/blink/web_tests/virtual/webnn-service-on-npu/external/wpt/webnn/conformance_tests/averagePool2d.https.any_npu-expected.txt
      • M third_party/blink/web_tests/virtual/webnn-service-on-npu/external/wpt/webnn/conformance_tests/maxPool2d.https.any_npu-expected.txt
      Change size: L
      Delta: 31 files changed, 248 insertions(+), 190 deletions(-)
      Branch: refs/heads/main
      Submit Requirements:
      • requirement satisfiedCode-Review: +1 by Reilly Grant, +1 by Alex Gough, +1 by Hu, Ningxin
      Open in Gerrit
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: merged
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I815c7f7728071144835c0ada0747bc9de2999669
      Gerrit-Change-Number: 7717139
      Gerrit-PatchSet: 10
      Gerrit-Owner: Dai, Feng <feng...@intel.com>
      Gerrit-Reviewer: Alex Gough <aj...@chromium.org>
      Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
      Gerrit-Reviewer: Dai, Feng <feng...@intel.com>
      Gerrit-Reviewer: Hu, Ningxin <ningx...@intel.com>
      Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>
      Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
      open
      diffy
      satisfied_requirement

      Blink W3C Test Autoroller (Gerrit)

      unread,
      Apr 21, 2026, 5:14:15 AM (10 days ago) Apr 21
      to Chromium LUCI CQ, Dai, Feng, Alex Gough, Hu, Ningxin, Reilly Grant, Dwayne Robinson, Fu, Junwei, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, ortuno...@chromium.org, titoua...@chromium.org, mac-r...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org

      Message from Blink W3C Test Autoroller

      The WPT PR for this CL has been merged upstream! https://github.com/web-platform-tests/wpt/pull/59145

      Open in Gerrit

      Related details

      Attention set is empty
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I815c7f7728071144835c0ada0747bc9de2999669
      Gerrit-Change-Number: 7717139
      Gerrit-PatchSet: 10
      Gerrit-Owner: Dai, Feng <feng...@intel.com>
      Gerrit-Reviewer: Alex Gough <aj...@chromium.org>
      Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
      Gerrit-Reviewer: Dai, Feng <feng...@intel.com>
      Gerrit-Reviewer: Hu, Ningxin <ningx...@intel.com>
      Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>
      Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
      Gerrit-CC: Dwayne Robinson <dwa...@microsoft.com>
      Gerrit-CC: Fu, Junwei <junw...@intel.com>
      Gerrit-Comment-Date: Tue, 21 Apr 2026 09:14:05 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: No
      satisfied_requirement
      open
      diffy

      luci-bisection@appspot.gserviceaccount.com (Gerrit)

      unread,
      Apr 22, 2026, 8:17:27 AM (9 days ago) Apr 22
      to Chromium LUCI CQ, Dai, Feng, Alex Gough, Hu, Ningxin, Reilly Grant, Blink W3C Test Autoroller, Dwayne Robinson, Fu, Junwei, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, ortuno...@chromium.org, titoua...@chromium.org, mac-r...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org

      Related details

      Attention set is empty
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: revert
      satisfied_requirement
      open
      diffy
      Reply all
      Reply to author
      Forward
      0 new messages