[animation-trigger] Fix crash in nested PostStyleUpdateScope updates [chromium/src : main]
0 views
Skip to first unread message
David A (Gerrit)
Mar 23, 2026, 1:35:28 PM (yesterday) Mar 23
to Vladimir Levin, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, Olga Gerchikov, apavlo...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org
Attention needed from Vladimir Levin
David A voted and added 2 comments![]( "Open in Gerrit")
Votes added by David A
| Commit-Queue | +1 |
2 comments
Patchset-level comments
File third_party/blink/renderer/core/css/post_style_update_scope.h
Line 101, Patchset 5:
static void SetPendingUpdateForTesting(Element&, const CSSAnimationUpdate&);David A . resolved
Introducing this as AnimationData is not marked `CORE_EXPORT`, causing PostStyleUpdateScope::CurrentAnimationData::SetPendingUpdate to fail compilation on some platforms (i.e. Windows).
(Maybe, to avoid others running into the issue of local builds being fine while CQ runs fail, we should consider marking `AnimationData` and `PseudoData` `CORE_EXPORT`)
Related details
Attention is currently required from:
- Vladimir Levin
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Vladimir Levin (Gerrit)
Mar 23, 2026, 2:36:22 PM (yesterday) Mar 23
to David A, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, Olga Gerchikov, apavlo...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org
Attention needed from David A
Vladimir Levin voted and added 1 comment![]( "Open in Gerrit")
Votes added by Vladimir Levin
| Code-Review | +1 |
1 comment
File third_party/blink/renderer/core/css/post_style_update_scope.cc
Line 45, Patchset 6 (Latest):
if (current_ != this) {Vladimir Levin . unresolved
nit: can you leave a comment something like "we only apply updates in the outermost scope as reflected by `current_`"
Related details
Attention is currently required from:
- David A
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
David A (Gerrit)
11:18 AM (8 hours ago) 11:18 AM
to Vladimir Levin, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, Olga Gerchikov, apavlo...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org
David A voted and added 1 comment![]( "Open in Gerrit")
Votes added by David A
| Commit-Queue | +2 |
1 comment
File third_party/blink/renderer/core/css/post_style_update_scope.cc
nit: can you leave a comment something like "we only apply updates in the outermost scope as reflected by `current_`"
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
David A (Gerrit)
11:19 AM (8 hours ago) 11:19 AM
to Vladimir Levin, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, Olga Gerchikov, apavlo...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org
David A voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
11:22 AM (7 hours ago) 11:22 AM
to David A, Vladimir Levin, Menard, Alexis, chromium...@chromium.org, Olga Gerchikov, apavlo...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org
Chromium LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
6 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: third_party/blink/renderer/core/css/post_style_update_scope.cc
Insertions: 2, Deletions: 0.
The diff is too large to show. Please review the diff.
```
Change information
Commit message:
[animation-trigger] Fix crash in nested PostStyleUpdateScope updates
This CL enforces a current_ != this guard to
PostStyleUpdateScope::Apply, preventing scopes which did not observe the
current animation update from attempting to execute trigger attachment
updates.
Bug: 492782953, 390314945
Change-Id: Iee17d6609d6c75f90ae155a473620519cd604921
Commit-Queue: David A <awogb...@chromium.org>
Reviewed-by: Vladimir Levin <vmp...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1604142}
Files:
- M third_party/blink/renderer/core/animation/css/css_animations_test.cc
- M third_party/blink/renderer/core/animation/document_animations.h
- M third_party/blink/renderer/core/css/post_style_update_scope.cc
- M third_party/blink/renderer/core/css/post_style_update_scope.h
Change size: M
Delta: 4 files changed, 96 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Vladimir Levin
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages