[tracing] Emit semantically false as null TRACE_STATE [chromium/src : main]

0 views
Skip to first unread message

Etienne Pierre-Doray (Gerrit)

unread,
2:49 PM (4 hours ago) 2:49 PM
to Patrick Monette, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, performance-m...@chromium.org
Attention needed from Patrick Monette

Etienne Pierre-Doray added 1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Etienne Pierre-Doray . resolved

PTAL

Open in Gerrit

Related details

Attention is currently required from:
  • Patrick Monette
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ie10fd3bdaa168485e19d6c3214a606c8a908a8d2
Gerrit-Change-Number: 8071938
Gerrit-PatchSet: 2
Gerrit-Owner: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Reviewer: Patrick Monette <pmon...@chromium.org>
Gerrit-Attention: Patrick Monette <pmon...@chromium.org>
Gerrit-Comment-Date: Thu, 09 Jul 2026 18:49:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Patrick Monette (Gerrit)

unread,
2:54 PM (4 hours ago) 2:54 PM
to Etienne Pierre-Doray, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, performance-m...@chromium.org
Attention needed from Etienne Pierre-Doray

Patrick Monette voted and added 1 comment

Votes added by Patrick Monette

Code-Review+1

1 comment

Patchset-level comments
Patrick Monette . resolved

lgtm

Open in Gerrit

Related details

Attention is currently required from:
  • Etienne Pierre-Doray
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ie10fd3bdaa168485e19d6c3214a606c8a908a8d2
Gerrit-Change-Number: 8071938
Gerrit-PatchSet: 2
Gerrit-Owner: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Reviewer: Patrick Monette <pmon...@chromium.org>
Gerrit-Attention: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Comment-Date: Thu, 09 Jul 2026 18:54:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Etienne Pierre-Doray (Gerrit)

unread,
2:55 PM (4 hours ago) 2:55 PM
to Patrick Monette, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, performance-m...@chromium.org

Etienne Pierre-Doray voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ie10fd3bdaa168485e19d6c3214a606c8a908a8d2
Gerrit-Change-Number: 8071938
Gerrit-PatchSet: 2
Gerrit-Owner: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Comment-Date: Thu, 09 Jul 2026 18:54:58 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
4:34 PM (2 hours ago) 4:34 PM
to Etienne Pierre-Doray, Patrick Monette, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, performance-m...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
[tracing] Emit semantically false as null TRACE_STATE

This will make summary more representative of busy/idle tracks.
Change-Id: Ie10fd3bdaa168485e19d6c3214a606c8a908a8d2
Reviewed-by: Patrick Monette <pmon...@chromium.org>
Commit-Queue: Etienne Pierre-Doray <etie...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1659810}
Files:
  • M components/performance_manager/graph/frame_node_impl.cc
  • M components/performance_manager/graph/page_node_impl.cc
  • M components/performance_manager/graph/properties.cc
  • M components/performance_manager/graph/properties_unittest.cc
Change size: S
Delta: 4 files changed, 8 insertions(+), 3 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Patrick Monette
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ie10fd3bdaa168485e19d6c3214a606c8a908a8d2
Gerrit-Change-Number: 8071938
Gerrit-PatchSet: 3
Gerrit-Owner: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages