SpeculationMeasurement - browser-side preconnects [chromium/src : main]

0 views
Skip to first unread message

Yoav Weiss (@Shopify) (Gerrit)

unread,
Jun 23, 2026, 9:34:57 AM (10 days ago) Jun 23
to Hiroki Nakagawa, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Nate Chapin, loading-re...@chromium.org, alexmo...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, creis...@chromium.org, gavinp...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, navigation...@chromium.org
Attention needed from Hiroki Nakagawa

Yoav Weiss (@Shopify) voted and added 2 comments

Votes added by Yoav Weiss (@Shopify)

Commit-Queue+1

2 comments

Commit Message
Line 12, Patchset 5:navigation params.
Hiroki Nakagawa . resolved

Sorry if I'm missing... but did we already support the case where a link-preconnect is specified on the final response (not 103 responses)?

Yoav Weiss (@Shopify)

Great point! I missed the fact that top-level preconnects happen outside the renderer. I'll add support for that as well.

Yoav Weiss (@Shopify)

Added support for both, and changed the commit message.

File third_party/blink/web_tests/external/wpt/speculation-rules/speculation-measurement/performance-speculations-early-hints-preconnect.tentative.h2.window.js
Line 25, Patchset 5:});
Hiroki Nakagawa . resolved

(Not blocking this CL) Would it be possible to test the case where multiple 103 early hints responses are served?

Yoav Weiss (@Shopify)

Done

Open in Gerrit

Related details

Attention is currently required from:
  • Hiroki Nakagawa
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I205f3a02b72e95ecc721da9a7dea26623d2b70ce
Gerrit-Change-Number: 7976017
Gerrit-PatchSet: 7
Gerrit-Owner: Yoav Weiss (@Shopify) <yoav...@chromium.org>
Gerrit-Reviewer: Hiroki Nakagawa <nhi...@chromium.org>
Gerrit-Reviewer: Yoav Weiss (@Shopify) <yoav...@chromium.org>
Gerrit-CC: Nate Chapin <jap...@chromium.org>
Gerrit-Attention: Hiroki Nakagawa <nhi...@chromium.org>
Gerrit-Comment-Date: Tue, 23 Jun 2026 13:34:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Hiroki Nakagawa <nhi...@chromium.org>
Comment-In-Reply-To: Yoav Weiss (@Shopify) <yoav...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy

Yoav Weiss (@Shopify) (Gerrit)

unread,
Jun 23, 2026, 12:04:57 PM (10 days ago) Jun 23
to Hiroki Nakagawa, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Nate Chapin, loading-re...@chromium.org, alexmo...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, creis...@chromium.org, gavinp...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, navigation...@chromium.org
Attention needed from Hiroki Nakagawa

Yoav Weiss (@Shopify) added 1 comment

Patchset-level comments
File-level comment, Patchset 8 (Latest):
Yoav Weiss (@Shopify) . resolved

nhiroki@ - can you take a second look? I added the navigation non-early-hint preconnects

Open in Gerrit

Related details

Attention is currently required from:
  • Hiroki Nakagawa
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I205f3a02b72e95ecc721da9a7dea26623d2b70ce
Gerrit-Change-Number: 7976017
Gerrit-PatchSet: 8
Gerrit-Owner: Yoav Weiss (@Shopify) <yoav...@chromium.org>
Gerrit-Reviewer: Hiroki Nakagawa <nhi...@chromium.org>
Gerrit-Reviewer: Yoav Weiss (@Shopify) <yoav...@chromium.org>
Gerrit-CC: Nate Chapin <jap...@chromium.org>
Gerrit-Attention: Hiroki Nakagawa <nhi...@chromium.org>
Gerrit-Comment-Date: Tue, 23 Jun 2026 16:04:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Yoav Weiss (@Shopify) (Gerrit)

unread,
Jun 23, 2026, 2:44:45 PM (10 days ago) Jun 23
to Rakina Zata Amni, Hiroki Nakagawa, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Nate Chapin, loading-re...@chromium.org, alexmo...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, creis...@chromium.org, gavinp...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, navigation...@chromium.org
Attention needed from Hiroki Nakagawa and Rakina Zata Amni

Yoav Weiss (@Shopify) voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Hiroki Nakagawa
  • Rakina Zata Amni
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I205f3a02b72e95ecc721da9a7dea26623d2b70ce
Gerrit-Change-Number: 7976017
Gerrit-PatchSet: 8
Gerrit-Owner: Yoav Weiss (@Shopify) <yoav...@chromium.org>
Gerrit-Reviewer: Hiroki Nakagawa <nhi...@chromium.org>
Gerrit-Reviewer: Rakina Zata Amni <rak...@chromium.org>
Gerrit-Reviewer: Yoav Weiss (@Shopify) <yoav...@chromium.org>
Gerrit-CC: Nate Chapin <jap...@chromium.org>
Gerrit-Attention: Hiroki Nakagawa <nhi...@chromium.org>
Gerrit-Attention: Rakina Zata Amni <rak...@chromium.org>
Gerrit-Comment-Date: Tue, 23 Jun 2026 18:44:27 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Rakina Zata Amni (Gerrit)

unread,
Jun 24, 2026, 1:19:36 AM (9 days ago) Jun 24
to Yoav Weiss (@Shopify), Chromium IPC Reviews, Hiroki Nakagawa, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Nate Chapin, loading-re...@chromium.org, alexmo...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, creis...@chromium.org, gavinp...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, navigation...@chromium.org
Attention needed from Chromium IPC Reviews, Hiroki Nakagawa and Yoav Weiss (@Shopify)

Rakina Zata Amni voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Chromium IPC Reviews
  • Hiroki Nakagawa
  • Yoav Weiss (@Shopify)
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I205f3a02b72e95ecc721da9a7dea26623d2b70ce
      Gerrit-Change-Number: 7976017
      Gerrit-PatchSet: 8
      Gerrit-Owner: Yoav Weiss (@Shopify) <yoav...@chromium.org>
      Gerrit-Reviewer: Chromium IPC Reviews <chrome-ip...@google.com>
      Gerrit-Reviewer: Hiroki Nakagawa <nhi...@chromium.org>
      Gerrit-Reviewer: Rakina Zata Amni <rak...@chromium.org>
      Gerrit-Reviewer: Yoav Weiss (@Shopify) <yoav...@chromium.org>
      Gerrit-CC: Nate Chapin <jap...@chromium.org>
      Gerrit-Attention: Hiroki Nakagawa <nhi...@chromium.org>
      Gerrit-Attention: Yoav Weiss (@Shopify) <yoav...@chromium.org>
      Gerrit-Attention: Chromium IPC Reviews <chrome-ip...@google.com>
      Gerrit-Comment-Date: Wed, 24 Jun 2026 05:19:04 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      gwsq (Gerrit)

      unread,
      Jun 24, 2026, 1:21:27 AM (9 days ago) Jun 24
      to Yoav Weiss (@Shopify), Chromium IPC Reviews, Mike West, Rakina Zata Amni, Hiroki Nakagawa, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Nate Chapin, loading-re...@chromium.org, alexmo...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, creis...@chromium.org, gavinp...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, navigation...@chromium.org
      Attention needed from Hiroki Nakagawa, Mike West and Yoav Weiss (@Shopify)

      Message from gwsq

      From googleclient/chrome/chromium_gwsq/ipc/config.gwsq:
      IPC: mk...@chromium.org

      📎 It looks like you’re making a possibly security-sensitive change! 📎 IPC security review isn’t a rubberstamp, so your friendly security reviewer will need a fair amount of context to review your CL effectively. Please review your CL description and code comments to make sure they provide context for someone unfamiliar with your project/area. Pay special attention to where data comes from and which processes it flows between (and their privilege levels). Feel free to point your security reviewer at design docs, bugs, or other links if you can’t reasonably make a self-contained CL description. (Also see https://cbea.ms/git-commit/).

      IPC reviewer(s): mk...@chromium.org


      Reviewer source(s):
      mk...@chromium.org is from context(googleclient/chrome/chromium_gwsq/ipc/config.gwsq)

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Hiroki Nakagawa
      • Mike West
      • Yoav Weiss (@Shopify)
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I205f3a02b72e95ecc721da9a7dea26623d2b70ce
      Gerrit-Change-Number: 7976017
      Gerrit-PatchSet: 8
      Gerrit-Owner: Yoav Weiss (@Shopify) <yoav...@chromium.org>
      Gerrit-Reviewer: Hiroki Nakagawa <nhi...@chromium.org>
      Gerrit-Reviewer: Mike West <mk...@chromium.org>
      Gerrit-Reviewer: Rakina Zata Amni <rak...@chromium.org>
      Gerrit-Reviewer: Yoav Weiss (@Shopify) <yoav...@chromium.org>
      Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
      Gerrit-CC: gwsq
      Gerrit-Attention: Mike West <mk...@chromium.org>
      Gerrit-Attention: Hiroki Nakagawa <nhi...@chromium.org>
      Gerrit-Attention: Yoav Weiss (@Shopify) <yoav...@chromium.org>
      Gerrit-Comment-Date: Wed, 24 Jun 2026 05:21:06 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: No
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Hiroki Nakagawa (Gerrit)

      unread,
      Jun 24, 2026, 2:14:34 AM (9 days ago) Jun 24
      to Yoav Weiss (@Shopify), Chromium IPC Reviews, Mike West, Rakina Zata Amni, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Nate Chapin, loading-re...@chromium.org, alexmo...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, creis...@chromium.org, gavinp...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, navigation...@chromium.org
      Attention needed from Mike West and Yoav Weiss (@Shopify)

      Hiroki Nakagawa voted and added 2 comments

      Votes added by Hiroki Nakagawa

      Code-Review+1

      2 comments

      Patchset-level comments
      Hiroki Nakagawa . resolved

      LGTM, thanks!

      File third_party/blink/web_tests/external/wpt/loading/early-hints/resources/multiple-early-hints-preconnects.html
      Line 10, Patchset 8 (Latest):// The browser only honors the first Early Hints response, so only the first
      // origin's preconnect should be recorded.
      Hiroki Nakagawa . unresolved

      QQ: Is this spec'ed behavior? Or, is this Chromium-specific behavior?

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Mike West
      • Yoav Weiss (@Shopify)
      Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement is not satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement is not satisfiedNo-Unresolved-Comments
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: I205f3a02b72e95ecc721da9a7dea26623d2b70ce
        Gerrit-Change-Number: 7976017
        Gerrit-PatchSet: 8
        Gerrit-Owner: Yoav Weiss (@Shopify) <yoav...@chromium.org>
        Gerrit-Reviewer: Hiroki Nakagawa <nhi...@chromium.org>
        Gerrit-Reviewer: Mike West <mk...@chromium.org>
        Gerrit-Reviewer: Rakina Zata Amni <rak...@chromium.org>
        Gerrit-Reviewer: Yoav Weiss (@Shopify) <yoav...@chromium.org>
        Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
        Gerrit-CC: Nate Chapin <jap...@chromium.org>
        Gerrit-CC: gwsq
        Gerrit-Attention: Mike West <mk...@chromium.org>
        Gerrit-Attention: Yoav Weiss (@Shopify) <yoav...@chromium.org>
        Gerrit-Comment-Date: Wed, 24 Jun 2026 06:14:08 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy

        Mike West (Gerrit)

        unread,
        Jun 24, 2026, 2:33:41 AM (9 days ago) Jun 24
        to Yoav Weiss (@Shopify), Hiroki Nakagawa, Chromium IPC Reviews, Rakina Zata Amni, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Nate Chapin, loading-re...@chromium.org, alexmo...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, creis...@chromium.org, gavinp...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, navigation...@chromium.org
        Attention needed from Yoav Weiss (@Shopify)

        Mike West voted and added 1 comment

        Votes added by Mike West

        Code-Review+1

        1 comment

        Patchset-level comments
        Mike West . resolved

        ipc lgtm.

        Open in Gerrit

        Related details

        Attention is currently required from:
        • Yoav Weiss (@Shopify)
        Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement is not satisfiedNo-Unresolved-Comments
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: I205f3a02b72e95ecc721da9a7dea26623d2b70ce
        Gerrit-Change-Number: 7976017
        Gerrit-PatchSet: 8
        Gerrit-Owner: Yoav Weiss (@Shopify) <yoav...@chromium.org>
        Gerrit-Reviewer: Hiroki Nakagawa <nhi...@chromium.org>
        Gerrit-Reviewer: Mike West <mk...@chromium.org>
        Gerrit-Reviewer: Rakina Zata Amni <rak...@chromium.org>
        Gerrit-Reviewer: Yoav Weiss (@Shopify) <yoav...@chromium.org>
        Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
        Gerrit-CC: Nate Chapin <jap...@chromium.org>
        Gerrit-CC: gwsq
        Gerrit-Attention: Yoav Weiss (@Shopify) <yoav...@chromium.org>
        Gerrit-Comment-Date: Wed, 24 Jun 2026 06:33:16 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy

        Yoav Weiss (@Shopify) (Gerrit)

        unread,
        Jun 24, 2026, 2:48:49 AM (9 days ago) Jun 24
        to Mike West, Hiroki Nakagawa, Chromium IPC Reviews, Rakina Zata Amni, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Nate Chapin, loading-re...@chromium.org, alexmo...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, creis...@chromium.org, gavinp...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, navigation...@chromium.org
        Attention needed from Hiroki Nakagawa

        Yoav Weiss (@Shopify) added 1 comment

        File third_party/blink/web_tests/external/wpt/loading/early-hints/resources/multiple-early-hints-preconnects.html
        Line 10, Patchset 8 (Latest):// The browser only honors the first Early Hints response, so only the first
        // origin's preconnect should be recorded.
        Hiroki Nakagawa . unresolved

        QQ: Is this spec'ed behavior? Or, is this Chromium-specific behavior?

        Yoav Weiss (@Shopify)

        I don't think this is specified, tbh. I can add a comment to that effect.

        Open in Gerrit

        Related details

        Attention is currently required from:
        • Hiroki Nakagawa
        Gerrit-Attention: Hiroki Nakagawa <nhi...@chromium.org>
        Gerrit-Comment-Date: Wed, 24 Jun 2026 06:48:28 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: No
        Comment-In-Reply-To: Hiroki Nakagawa <nhi...@chromium.org>
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy

        Yoav Weiss (@Shopify) (Gerrit)

        unread,
        Jun 24, 2026, 3:01:56 AM (9 days ago) Jun 24
        to Mike West, Hiroki Nakagawa, Chromium IPC Reviews, Rakina Zata Amni, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Nate Chapin, loading-re...@chromium.org, alexmo...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, creis...@chromium.org, gavinp...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, navigation...@chromium.org
        Attention needed from Hiroki Nakagawa

        Yoav Weiss (@Shopify) added 1 comment

        File third_party/blink/web_tests/external/wpt/loading/early-hints/resources/multiple-early-hints-preconnects.html
        Line 10, Patchset 8 (Latest):// The browser only honors the first Early Hints response, so only the first
        // origin's preconnect should be recorded.
        Hiroki Nakagawa . unresolved

        QQ: Is this spec'ed behavior? Or, is this Chromium-specific behavior?

        Yoav Weiss (@Shopify)

        I don't think this is specified, tbh. I can add a comment to that effect.

        Yoav Weiss (@Shopify)

        I was wrong, and this goes against the specified behavior.. So it could just be a Chromium bug

        Gerrit-Comment-Date: Wed, 24 Jun 2026 07:01:32 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: No
        Comment-In-Reply-To: Hiroki Nakagawa <nhi...@chromium.org>
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy

        Yoav Weiss (@Shopify) (Gerrit)

        unread,
        Jun 24, 2026, 3:02:48 AM (9 days ago) Jun 24
        to Mike West, Hiroki Nakagawa, Chromium IPC Reviews, Rakina Zata Amni, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Nate Chapin, loading-re...@chromium.org, alexmo...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, creis...@chromium.org, gavinp...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, navigation...@chromium.org
        Attention needed from Hiroki Nakagawa

        Yoav Weiss (@Shopify) added 1 comment

        File third_party/blink/web_tests/external/wpt/loading/early-hints/resources/multiple-early-hints-preconnects.html
        Line 10, Patchset 8 (Latest):// The browser only honors the first Early Hints response, so only the first
        // origin's preconnect should be recorded.
        Hiroki Nakagawa . unresolved

        QQ: Is this spec'ed behavior? Or, is this Chromium-specific behavior?

        Yoav Weiss (@Shopify)

        I don't think this is specified, tbh. I can add a comment to that effect.

        Yoav Weiss (@Shopify)

        I was wrong, and this goes against the specified behavior.. So it could just be a Chromium bug

        Yoav Weiss (@Shopify)

        I'll add a TODO. Since this is all tentative tests, this is probably fine for now

        Gerrit-Comment-Date: Wed, 24 Jun 2026 07:02:27 +0000
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy

        Yoav Weiss (@Shopify) (Gerrit)

        unread,
        Jun 24, 2026, 3:18:54 AM (9 days ago) Jun 24
        to Mike West, Hiroki Nakagawa, Chromium IPC Reviews, Rakina Zata Amni, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Nate Chapin, loading-re...@chromium.org, alexmo...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, creis...@chromium.org, gavinp...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, navigation...@chromium.org
        Attention needed from Hiroki Nakagawa

        Yoav Weiss (@Shopify) added 1 comment

        File third_party/blink/web_tests/external/wpt/loading/early-hints/resources/multiple-early-hints-preconnects.html
        Line 10, Patchset 8:// The browser only honors the first Early Hints response, so only the first

        // origin's preconnect should be recorded.
        Hiroki Nakagawa . resolved

        QQ: Is this spec'ed behavior? Or, is this Chromium-specific behavior?

        Yoav Weiss (@Shopify)

        I don't think this is specified, tbh. I can add a comment to that effect.

        Yoav Weiss (@Shopify)

        I was wrong, and this goes against the specified behavior.. So it could just be a Chromium bug

        Yoav Weiss (@Shopify)

        I'll add a TODO. Since this is all tentative tests, this is probably fine for now

        Yoav Weiss (@Shopify)

        Added a TODO and opened https://issues.chromium.org/issues/527144295 to further look into this.

        Open in Gerrit

        Related details

        Attention is currently required from:
        • Hiroki Nakagawa
        Submit Requirements:
          • requirement satisfiedCode-Coverage
          • requirement satisfiedCode-Owners
          • requirement satisfiedCode-Review
          • requirement satisfiedReview-Enforcement
          Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
          Gerrit-MessageType: comment
          Gerrit-Project: chromium/src
          Gerrit-Branch: main
          Gerrit-Change-Id: I205f3a02b72e95ecc721da9a7dea26623d2b70ce
          Gerrit-Change-Number: 7976017
          Gerrit-PatchSet: 8
          Gerrit-Owner: Yoav Weiss (@Shopify) <yoav...@chromium.org>
          Gerrit-Reviewer: Hiroki Nakagawa <nhi...@chromium.org>
          Gerrit-Reviewer: Mike West <mk...@chromium.org>
          Gerrit-Reviewer: Rakina Zata Amni <rak...@chromium.org>
          Gerrit-Reviewer: Yoav Weiss (@Shopify) <yoav...@chromium.org>
          Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
          Gerrit-CC: Nate Chapin <jap...@chromium.org>
          Gerrit-CC: gwsq
          Gerrit-Attention: Hiroki Nakagawa <nhi...@chromium.org>
          Gerrit-Comment-Date: Wed, 24 Jun 2026 07:18:35 +0000
          satisfied_requirement
          open
          diffy

          Yoav Weiss (@Shopify) (Gerrit)

          unread,
          Jun 24, 2026, 3:23:18 AM (9 days ago) Jun 24
          to Mike West, Hiroki Nakagawa, Chromium IPC Reviews, Rakina Zata Amni, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Nate Chapin, loading-re...@chromium.org, alexmo...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, creis...@chromium.org, gavinp...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, navigation...@chromium.org
          Attention needed from Hiroki Nakagawa

          Yoav Weiss (@Shopify) voted Commit-Queue+2

          Commit-Queue+2
          Open in Gerrit

          Related details

          Attention is currently required from:
          • Hiroki Nakagawa
          Submit Requirements:
          • requirement satisfiedCode-Coverage
          • requirement satisfiedCode-Owners
          • requirement satisfiedCode-Review
          • requirement satisfiedReview-Enforcement
          Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
          Gerrit-MessageType: comment
          Gerrit-Project: chromium/src
          Gerrit-Branch: main
          Gerrit-Change-Id: I205f3a02b72e95ecc721da9a7dea26623d2b70ce
          Gerrit-Change-Number: 7976017
          Gerrit-PatchSet: 9
          Gerrit-Owner: Yoav Weiss (@Shopify) <yoav...@chromium.org>
          Gerrit-Reviewer: Hiroki Nakagawa <nhi...@chromium.org>
          Gerrit-Reviewer: Mike West <mk...@chromium.org>
          Gerrit-Reviewer: Rakina Zata Amni <rak...@chromium.org>
          Gerrit-Reviewer: Yoav Weiss (@Shopify) <yoav...@chromium.org>
          Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
          Gerrit-CC: Nate Chapin <jap...@chromium.org>
          Gerrit-CC: gwsq
          Gerrit-Attention: Hiroki Nakagawa <nhi...@chromium.org>
          Gerrit-Comment-Date: Wed, 24 Jun 2026 07:22:51 +0000
          Gerrit-HasComments: No
          Gerrit-Has-Labels: Yes
          satisfied_requirement
          open
          diffy

          Yoav Weiss (@Shopify) (Gerrit)

          unread,
          Jun 24, 2026, 3:23:38 AM (9 days ago) Jun 24
          to Mike West, Hiroki Nakagawa, Chromium IPC Reviews, Rakina Zata Amni, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Nate Chapin, loading-re...@chromium.org, alexmo...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, creis...@chromium.org, gavinp...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, navigation...@chromium.org
          Attention needed from Hiroki Nakagawa

          Yoav Weiss (@Shopify) added 1 comment

          Yoav Weiss (@Shopify) . resolved

          Thanks all for promptly reviewing!!

          Gerrit-Comment-Date: Wed, 24 Jun 2026 07:23:17 +0000
          Gerrit-HasComments: Yes
          Gerrit-Has-Labels: No
          satisfied_requirement
          open
          diffy

          Blink W3C Test Autoroller (Gerrit)

          unread,
          Jun 24, 2026, 3:28:29 AM (9 days ago) Jun 24
          to Yoav Weiss (@Shopify), Mike West, Hiroki Nakagawa, Chromium IPC Reviews, Rakina Zata Amni, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Nate Chapin, loading-re...@chromium.org, alexmo...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, creis...@chromium.org, gavinp...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, navigation...@chromium.org
          Attention needed from Hiroki Nakagawa

          Message from Blink W3C Test Autoroller

          Exportable changes to web-platform-tests were detected in this CL and a pull request in the upstream repo has been made: https://github.com/web-platform-tests/wpt/pull/60854.

          When this CL lands, the bot will automatically merge the PR on GitHub if the required GitHub checks pass; otherwise, ecosystem-infra@ team will triage the failures and may contact you.

          WPT Export docs:
          https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md#Automatic-export-process

          Open in Gerrit

          Related details

          Attention is currently required from:
          • Hiroki Nakagawa
          Submit Requirements:
          • requirement satisfiedCode-Coverage
          • requirement satisfiedCode-Owners
          • requirement satisfiedCode-Review
          • requirement satisfiedReview-Enforcement
          Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
          Gerrit-MessageType: comment
          Gerrit-Project: chromium/src
          Gerrit-Branch: main
          Gerrit-Change-Id: I205f3a02b72e95ecc721da9a7dea26623d2b70ce
          Gerrit-Change-Number: 7976017
          Gerrit-PatchSet: 9
          Gerrit-Owner: Yoav Weiss (@Shopify) <yoav...@chromium.org>
          Gerrit-Reviewer: Hiroki Nakagawa <nhi...@chromium.org>
          Gerrit-Reviewer: Mike West <mk...@chromium.org>
          Gerrit-Reviewer: Rakina Zata Amni <rak...@chromium.org>
          Gerrit-Reviewer: Yoav Weiss (@Shopify) <yoav...@chromium.org>
          Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
          Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
          Gerrit-CC: Nate Chapin <jap...@chromium.org>
          Gerrit-CC: gwsq
          Gerrit-Attention: Hiroki Nakagawa <nhi...@chromium.org>
          Gerrit-Comment-Date: Wed, 24 Jun 2026 07:28:12 +0000
          Gerrit-HasComments: No
          Gerrit-Has-Labels: No
          satisfied_requirement
          open
          diffy

          Hiroki Nakagawa (Gerrit)

          unread,
          Jun 24, 2026, 3:33:27 AM (9 days ago) Jun 24
          to Yoav Weiss (@Shopify), Blink W3C Test Autoroller, Mike West, Chromium IPC Reviews, Rakina Zata Amni, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Nate Chapin, loading-re...@chromium.org, alexmo...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, creis...@chromium.org, gavinp...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, navigation...@chromium.org
          Attention needed from Yoav Weiss (@Shopify)

          Hiroki Nakagawa voted and added 1 comment

          Votes added by Hiroki Nakagawa

          Code-Review+1

          1 comment

          File third_party/blink/web_tests/external/wpt/loading/early-hints/resources/multiple-early-hints-preconnects.html
          Line 10, Patchset 8:// The browser only honors the first Early Hints response, so only the first
          // origin's preconnect should be recorded.
          Hiroki Nakagawa . resolved

          QQ: Is this spec'ed behavior? Or, is this Chromium-specific behavior?

          Yoav Weiss (@Shopify)

          I don't think this is specified, tbh. I can add a comment to that effect.

          Yoav Weiss (@Shopify)

          I was wrong, and this goes against the specified behavior.. So it could just be a Chromium bug

          Yoav Weiss (@Shopify)

          I'll add a TODO. Since this is all tentative tests, this is probably fine for now

          Yoav Weiss (@Shopify)

          Added a TODO and opened https://issues.chromium.org/issues/527144295 to further look into this.

          Hiroki Nakagawa

          Acked, thank you!

          Open in Gerrit

          Related details

          Attention is currently required from:
          • Yoav Weiss (@Shopify)
          Gerrit-Attention: Yoav Weiss (@Shopify) <yoav...@chromium.org>
          Gerrit-Comment-Date: Wed, 24 Jun 2026 07:32:52 +0000
          Gerrit-HasComments: Yes
          Gerrit-Has-Labels: Yes
          satisfied_requirement
          open
          diffy

          Chromium LUCI CQ (Gerrit)

          unread,
          Jun 24, 2026, 4:29:03 AM (9 days ago) Jun 24
          to Yoav Weiss (@Shopify), Blink W3C Test Autoroller, Mike West, Hiroki Nakagawa, Chromium IPC Reviews, Rakina Zata Amni, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Nate Chapin, loading-re...@chromium.org, alexmo...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, creis...@chromium.org, gavinp...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, navigation...@chromium.org

          Chromium LUCI CQ submitted the change

          Change information

          Commit message:
          SpeculationMeasurement - browser-side preconnects

          This CL adds the browser-side of preconnect measurement.
          It does so by following similar patterns to preload reporting, as it
          passes a list of navigation and early-hint preconnects to the renderer
          as part of its navigation params.
          Change-Id: I205f3a02b72e95ecc721da9a7dea26623d2b70ce
          Reviewed-by: Mike West <mk...@chromium.org>
          Reviewed-by: Hiroki Nakagawa <nhi...@chromium.org>
          Reviewed-by: Rakina Zata Amni <rak...@chromium.org>
          Commit-Queue: Yoav Weiss (@Shopify) <yoav...@chromium.org>
          Cr-Commit-Position: refs/heads/main@{#1651563}
          Files:
          • M content/browser/loader/navigation_early_hints_manager.cc
          • M content/browser/loader/navigation_early_hints_manager.h
          • M content/browser/renderer_host/navigation_controller_impl.cc
          • M content/browser/renderer_host/navigation_entry_impl.cc
          • M content/browser/renderer_host/navigation_request.cc
          • M content/renderer/render_frame_impl.cc
          • M third_party/blink/public/mojom/navigation/navigation_params.mojom
          • M third_party/blink/public/web/web_navigation_params.h
          • M third_party/blink/renderer/core/loader/document_loader.cc
          • M third_party/blink/renderer/core/loader/document_loader.h
          • M third_party/blink/renderer/core/loader/frame_fetch_context.cc
          • M third_party/blink/renderer/platform/loader/BUILD.gn
          • A third_party/blink/renderer/platform/loader/fetch/cross_origin_attribute_value.cc
          • M third_party/blink/renderer/platform/loader/fetch/cross_origin_attribute_value.h
          • M third_party/blink/renderer/platform/loader/fetch/resource_fetcher.cc
          • M third_party/blink/web_tests/external/wpt/loading/early-hints/resources/early-hints-helpers.sub.js
          • M third_party/blink/web_tests/external/wpt/loading/early-hints/resources/early-hints-test-loader.h2.py
          • A third_party/blink/web_tests/external/wpt/loading/early-hints/resources/multiple-early-hints-preconnects.h2.py
          • A third_party/blink/web_tests/external/wpt/loading/early-hints/resources/multiple-early-hints-preconnects.html
          • A third_party/blink/web_tests/external/wpt/loading/early-hints/resources/speculation-measurement-early-hints-preconnect.html
          • A third_party/blink/web_tests/external/wpt/speculation-rules/speculation-measurement/performance-speculations-early-hints-preconnect.tentative.h2.window.js
          • A third_party/blink/web_tests/external/wpt/speculation-rules/speculation-measurement/performance-speculations-multiple-early-hints-preconnect.tentative.h2.window.js
          • A third_party/blink/web_tests/external/wpt/speculation-rules/speculation-measurement/performance-speculations-preconnect-response-header.tentative.html
          • A third_party/blink/web_tests/external/wpt/speculation-rules/speculation-measurement/performance-speculations-preconnect-response-header.tentative.html.headers
          Change size: L
          Delta: 24 files changed, 392 insertions(+), 12 deletions(-)
          Branch: refs/heads/main
          Submit Requirements:
          • requirement satisfiedCode-Review: +1 by Mike West, +1 by Rakina Zata Amni, +1 by Hiroki Nakagawa
          Open in Gerrit
          Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
          Gerrit-MessageType: merged
          Gerrit-Project: chromium/src
          Gerrit-Branch: main
          Gerrit-Change-Id: I205f3a02b72e95ecc721da9a7dea26623d2b70ce
          Gerrit-Change-Number: 7976017
          Gerrit-PatchSet: 10
          Gerrit-Owner: Yoav Weiss (@Shopify) <yoav...@chromium.org>
          Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
          Gerrit-Reviewer: Hiroki Nakagawa <nhi...@chromium.org>
          Gerrit-Reviewer: Mike West <mk...@chromium.org>
          Gerrit-Reviewer: Rakina Zata Amni <rak...@chromium.org>
          Gerrit-Reviewer: Yoav Weiss (@Shopify) <yoav...@chromium.org>
          Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
          Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
          open
          diffy
          satisfied_requirement

          Blink W3C Test Autoroller (Gerrit)

          unread,
          Jun 24, 2026, 5:46:39 AM (9 days ago) Jun 24
          to Chromium LUCI CQ, Yoav Weiss (@Shopify), Mike West, Hiroki Nakagawa, Chromium IPC Reviews, Rakina Zata Amni, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Nate Chapin, loading-re...@chromium.org, alexmo...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, creis...@chromium.org, gavinp...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, navigation...@chromium.org

          Message from Blink W3C Test Autoroller

          The WPT PR for this CL has been merged upstream! https://github.com/web-platform-tests/wpt/pull/60854

          Open in Gerrit

          Related details

          Attention set is empty
          Submit Requirements:
          • requirement satisfiedCode-Coverage
          • requirement satisfiedCode-Owners
          • requirement satisfiedCode-Review
          • requirement satisfiedReview-Enforcement
          Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
          Gerrit-MessageType: comment
          Gerrit-Project: chromium/src
          Gerrit-Branch: main
          Gerrit-Change-Id: I205f3a02b72e95ecc721da9a7dea26623d2b70ce
          Gerrit-Change-Number: 7976017
          Gerrit-PatchSet: 10
          Gerrit-Owner: Yoav Weiss (@Shopify) <yoav...@chromium.org>
          Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
          Gerrit-Reviewer: Hiroki Nakagawa <nhi...@chromium.org>
          Gerrit-Reviewer: Mike West <mk...@chromium.org>
          Gerrit-Reviewer: Rakina Zata Amni <rak...@chromium.org>
          Gerrit-Reviewer: Yoav Weiss (@Shopify) <yoav...@chromium.org>
          Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
          Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
          Gerrit-CC: Nate Chapin <jap...@chromium.org>
          Gerrit-CC: gwsq
          Gerrit-Comment-Date: Wed, 24 Jun 2026 09:46:24 +0000
          Gerrit-HasComments: No
          Gerrit-Has-Labels: No
          satisfied_requirement
          open
          diffy

          Kenichi Ishibashi (Gerrit)

          unread,
          Jun 24, 2026, 9:20:38 PM (9 days ago) Jun 24
          to Chromium LUCI CQ, Yoav Weiss (@Shopify), Blink W3C Test Autoroller, Mike West, Hiroki Nakagawa, Chromium IPC Reviews, Rakina Zata Amni, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Nate Chapin, loading-re...@chromium.org, alexmo...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, creis...@chromium.org, gavinp...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, navigation...@chromium.org

          Kenichi Ishibashi added 1 comment

          File third_party/blink/web_tests/external/wpt/loading/early-hints/resources/multiple-early-hints-preconnects.html
          Line 10, Patchset 8:// The browser only honors the first Early Hints response, so only the first
          // origin's preconnect should be recorded.
          Hiroki Nakagawa . resolved

          QQ: Is this spec'ed behavior? Or, is this Chromium-specific behavior?

          Yoav Weiss (@Shopify)

          I don't think this is specified, tbh. I can add a comment to that effect.

          Yoav Weiss (@Shopify)

          I was wrong, and this goes against the specified behavior.. So it could just be a Chromium bug

          Yoav Weiss (@Shopify)

          I'll add a TODO. Since this is all tentative tests, this is probably fine for now

          Yoav Weiss (@Shopify)

          Added a TODO and opened https://issues.chromium.org/issues/527144295 to further look into this.

          Hiroki Nakagawa

          Acked, thank you!

          Open in Gerrit

          Related details

          Attention set is empty
          Submit Requirements:
          • requirement satisfiedCode-Coverage
          • requirement satisfiedCode-Owners
          • requirement satisfiedCode-Review
          • requirement satisfiedReview-Enforcement
          Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
          Gerrit-MessageType: comment
          Gerrit-Project: chromium/src
          Gerrit-Branch: main
          Gerrit-Change-Id: I205f3a02b72e95ecc721da9a7dea26623d2b70ce
          Gerrit-Change-Number: 7976017
          Gerrit-PatchSet: 10
          Gerrit-Owner: Yoav Weiss (@Shopify) <yoav...@chromium.org>
          Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
          Gerrit-Reviewer: Hiroki Nakagawa <nhi...@chromium.org>
          Gerrit-Reviewer: Mike West <mk...@chromium.org>
          Gerrit-Reviewer: Rakina Zata Amni <rak...@chromium.org>
          Gerrit-Reviewer: Yoav Weiss (@Shopify) <yoav...@chromium.org>
          Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
          Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
          Gerrit-CC: Kenichi Ishibashi <ba...@chromium.org>
          Gerrit-Comment-Date: Thu, 25 Jun 2026 01:20:01 +0000
          Gerrit-HasComments: Yes
          Gerrit-Has-Labels: No
          satisfied_requirement
          open
          diffy
          Reply all
          Reply to author
          Forward
          0 new messages