| Commit-Queue | +1 |
navigation params.Yoav Weiss (@Shopify)Sorry if I'm missing... but did we already support the case where a link-preconnect is specified on the final response (not 103 responses)?
Yoav Weiss (@Shopify)Great point! I missed the fact that top-level preconnects happen outside the renderer. I'll add support for that as well.
Added support for both, and changed the commit message.
});Yoav Weiss (@Shopify)(Not blocking this CL) Would it be possible to test the case where multiple 103 early hints responses are served?
Done
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
nhiroki@ - can you take a second look? I added the navigation non-early-hint preconnects
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
From googleclient/chrome/chromium_gwsq/ipc/config.gwsq:
IPC: mk...@chromium.org
📎 It looks like you’re making a possibly security-sensitive change! 📎 IPC security review isn’t a rubberstamp, so your friendly security reviewer will need a fair amount of context to review your CL effectively. Please review your CL description and code comments to make sure they provide context for someone unfamiliar with your project/area. Pay special attention to where data comes from and which processes it flows between (and their privilege levels). Feel free to point your security reviewer at design docs, bugs, or other links if you can’t reasonably make a self-contained CL description. (Also see https://cbea.ms/git-commit/).
IPC reviewer(s): mk...@chromium.org
Reviewer source(s):
mk...@chromium.org is from context(googleclient/chrome/chromium_gwsq/ipc/config.gwsq)
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Code-Review | +1 |
LGTM, thanks!
// The browser only honors the first Early Hints response, so only the first
// origin's preconnect should be recorded.QQ: Is this spec'ed behavior? Or, is this Chromium-specific behavior?
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Code-Review | +1 |
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
// The browser only honors the first Early Hints response, so only the first
// origin's preconnect should be recorded.QQ: Is this spec'ed behavior? Or, is this Chromium-specific behavior?
I don't think this is specified, tbh. I can add a comment to that effect.
// The browser only honors the first Early Hints response, so only the first
// origin's preconnect should be recorded.Yoav Weiss (@Shopify)QQ: Is this spec'ed behavior? Or, is this Chromium-specific behavior?
I don't think this is specified, tbh. I can add a comment to that effect.
I was wrong, and this goes against the specified behavior.. So it could just be a Chromium bug
// The browser only honors the first Early Hints response, so only the first
// origin's preconnect should be recorded.Yoav Weiss (@Shopify)QQ: Is this spec'ed behavior? Or, is this Chromium-specific behavior?
Yoav Weiss (@Shopify)I don't think this is specified, tbh. I can add a comment to that effect.
I was wrong, and this goes against the specified behavior.. So it could just be a Chromium bug
I'll add a TODO. Since this is all tentative tests, this is probably fine for now
// The browser only honors the first Early Hints response, so only the first
// origin's preconnect should be recorded.Yoav Weiss (@Shopify)QQ: Is this spec'ed behavior? Or, is this Chromium-specific behavior?
Yoav Weiss (@Shopify)I don't think this is specified, tbh. I can add a comment to that effect.
Yoav Weiss (@Shopify)I was wrong, and this goes against the specified behavior.. So it could just be a Chromium bug
I'll add a TODO. Since this is all tentative tests, this is probably fine for now
Added a TODO and opened https://issues.chromium.org/issues/527144295 to further look into this.
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Exportable changes to web-platform-tests were detected in this CL and a pull request in the upstream repo has been made: https://github.com/web-platform-tests/wpt/pull/60854.
When this CL lands, the bot will automatically merge the PR on GitHub if the required GitHub checks pass; otherwise, ecosystem-infra@ team will triage the failures and may contact you.
WPT Export docs:
https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md#Automatic-export-process
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Code-Review | +1 |
// The browser only honors the first Early Hints response, so only the first
// origin's preconnect should be recorded.Yoav Weiss (@Shopify)QQ: Is this spec'ed behavior? Or, is this Chromium-specific behavior?
Yoav Weiss (@Shopify)I don't think this is specified, tbh. I can add a comment to that effect.
Yoav Weiss (@Shopify)I was wrong, and this goes against the specified behavior.. So it could just be a Chromium bug
Yoav Weiss (@Shopify)I'll add a TODO. Since this is all tentative tests, this is probably fine for now
Added a TODO and opened https://issues.chromium.org/issues/527144295 to further look into this.
SpeculationMeasurement - browser-side preconnects
This CL adds the browser-side of preconnect measurement.
It does so by following similar patterns to preload reporting, as it
passes a list of navigation and early-hint preconnects to the renderer
as part of its navigation params.
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
The WPT PR for this CL has been merged upstream! https://github.com/web-platform-tests/wpt/pull/60854
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
// The browser only honors the first Early Hints response, so only the first
// origin's preconnect should be recorded.Yoav Weiss (@Shopify)QQ: Is this spec'ed behavior? Or, is this Chromium-specific behavior?
Yoav Weiss (@Shopify)I don't think this is specified, tbh. I can add a comment to that effect.
Yoav Weiss (@Shopify)I was wrong, and this goes against the specified behavior.. So it could just be a Chromium bug
Yoav Weiss (@Shopify)I'll add a TODO. Since this is all tentative tests, this is probably fine for now
Hiroki NakagawaAdded a TODO and opened https://issues.chromium.org/issues/527144295 to further look into this.
Acked, thank you!
IIUC this is a spec specified behavior at least when I implemented Early Hints for prefetch.
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |